Received: by 10.223.148.5 with SMTP id 5csp6858770wrq; Wed, 17 Jan 2018 20:40:03 -0800 (PST) X-Google-Smtp-Source: ACJfBouVr1n6iRZqh/X90v84Gsf1yzj3eDN7AsuFC0xmGPASYwUn1DcpXwoj43FuDveIKnOAOnh8 X-Received: by 10.101.90.10 with SMTP id y10mr25649475pgs.445.1516250402968; Wed, 17 Jan 2018 20:40:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516250402; cv=none; d=google.com; s=arc-20160816; b=IGfnfr2QaZ9D55ZY50KE5JiDrNitklv0Rt1+669uyk41lxpIDFHmq63zvCcZVmbF+n 1DiiRCsvZbSpuCiJEC27w1LaThXTg1OCIsTmcmNnkk6mUJtG6Fjh0PlNdR74BYL5NiVG 6hpw9CZ/LBU/Xl2lXZRXgFSfeC/4rYuDGkP3pvrixarpKjJpUO4DAI1H32CveaYtzghQ vTw+8JpesegfDa9U0EEXV5dR5x8uaYjDBk7DzVRRTio5fh7ha1jbH17jGfLl8XnLwkrb bCIbBWPNEO59aIo6jEAZzMJbuuuZxVFpG8c1umozQv18RFKVE2dupJusgVWxftlwOl4Z OR3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=VUF5n3w2chIhIGn+XL15CsA8cn6WO+anem2/fi2C3us=; b=IaYz1kh+vqvPSo1izuaFEcOJIp37qmOQPAjKGfu5B9F/aQwVQrtos6+wM+bzxVj/1/ kpBRU0cVfkaXoqx4fCT57lMMPOzqcL+wKIzLH3oNGvXeJk4RN80JHIhB+l2gvgVLBnmM IZW4eDTJIiQsLeDZneV+sZjRI6cLCyXRhewQdAMlVAUuVaFGTR4Xd7azpZjbAD9SYbOj +si+Jw2VSFKt1It2mkQOzjQPZjZsULMx7o+fNQhUGUkx09iNJe2pC6NaCmmcnsPxQBIg nuz23wY3CgbYNI02Rh5VwZJEZBtgjPo5hCrtKC5kaD6ayOHruWT/WsZ5WmWpxLGCrAxH KFyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=PwFxeJzk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o16si5089976pgd.563.2018.01.17.20.39.48; Wed, 17 Jan 2018 20:40:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=PwFxeJzk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753956AbeAREjZ (ORCPT + 99 others); Wed, 17 Jan 2018 23:39:25 -0500 Received: from mail-pf0-f173.google.com ([209.85.192.173]:36115 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753175AbeAREjX (ORCPT ); Wed, 17 Jan 2018 23:39:23 -0500 Received: by mail-pf0-f173.google.com with SMTP id 23so13367556pfp.3 for ; Wed, 17 Jan 2018 20:39:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VUF5n3w2chIhIGn+XL15CsA8cn6WO+anem2/fi2C3us=; b=PwFxeJzkECbDqlVK8vZWAGWo0CJFHhlevbDYWEijqxZGi0NGxgcmXx74zpzHcJUkeG yD3GTCLnQzz0xEW8+Lfo19W6hwrjx/PWvfHWF3qTZqji02hzn60L14gqzblae8c1/UpF 3x59v3OVnJ6UJfGGuXATQ7rRDpkXeESIKK+NIB8h9vaCm3Isd0w5HOOzryckkirlGP2u S2izwzdBCRl4fEDiDhA8nPaQjp7E79oVndSAqC6FDZ2XbLS9w5Hty7d4pjpE696TINEX 4Io4OvtAFZT/PxpLx81WYBh7gs3Ut2/HfoSdR8+giiQswFVplFvXgYYb65YUqvYmQoIy yT6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VUF5n3w2chIhIGn+XL15CsA8cn6WO+anem2/fi2C3us=; b=Es8jcMG4+qBwmc9Zw1fAwwv1Xd3MnlnXeedZcRA97lyPMZbk7Knb1bE0cu59noQX42 I6K9FaKzyFKz9f0AngkYQh0rB678QrxCf2ojYwrcBT3yavaTIRbSocPq/RPrriQS46dS bOXzFCYQUhGrwSi5uqXZhAlIEH5iZwlp2qcc9HXF/2HZmMwAZrhCubiidl1vrFOiC7Nn UUHdgeA+seaF5vJJfhuEwy28m2XQOu0lGs4KLSxSFeHpmEP3wStS+OhqYsXTAqH43hpz sZvUS5k5nP+AnneSQ49GxMYL7dYMNjD2SCtmZ6tVLPcse+nfIe2TE0CDiJbvVX4vOWB+ 6Nig== X-Gm-Message-State: AKwxytdGvSlowelpums37thE024ZM6BGRyFnNkmrH6gYSdMoDYO7zmRZ wVyMJWgG4s1o1kalSbiOMPAFhmFz2Eo= X-Received: by 10.84.232.9 with SMTP id h9mr32090778plk.46.1516250363082; Wed, 17 Jan 2018 20:39:23 -0800 (PST) Received: from [192.168.1.114] (107.191.0.158.static.utbb.net. [107.191.0.158]) by smtp.gmail.com with ESMTPSA id y7sm8987796pge.87.2018.01.17.20.39.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Jan 2018 20:39:22 -0800 (PST) Subject: Re: [PATCH] blk-mq: don't dispatch request in blk_mq_request_direct_issue if queue is busy To: Ming Lei , linux-block@vger.kernel.org, Mike Snitzer , dm-devel@redhat.com Cc: Christoph Hellwig , Bart Van Assche , linux-kernel@vger.kernel.org References: <20180118040659.20202-1-ming.lei@redhat.com> From: Jens Axboe Message-ID: <5f7edaad-6541-4e9d-996c-db982fa283a9@kernel.dk> Date: Wed, 17 Jan 2018 21:39:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Thunderbird/58.0 MIME-Version: 1.0 In-Reply-To: <20180118040659.20202-1-ming.lei@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/17/18 9:06 PM, Ming Lei wrote: > If we run into blk_mq_request_direct_issue(), when queue is busy, we > don't want to dispatch this request into hctx->dispatch_list, and > what we need to do is to return the queue busy info to caller, so > that caller can deal with it well. Thanks for fixing this up, applied. -- Jens Axboe