Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20171207093127.735w6kk44f6unukl@dell>
References: <1512135743-16529-1-git-send-email-thierry.escande@collabora.com>
 <1512135743-16529-4-git-send-email-thierry.escande@collabora.com>
 <CAMHSBOXpWxsk9he_AYGN-ROW31yYTMdkJZi9ikmy0MdGOQ5o-A@mail.gmail.com> <20171207093127.735w6kk44f6unukl@dell>
From:   Gwendal Grignou <gwendal@chromium.org>
Date:   Thu, 18 Jan 2018 00:05:16 -0800
Message-ID: <CAMHSBOWhtLVB5DVrouWd1Q_5uiMT=BmqHg_rXOtW4Zb_Q7JL=g@mail.gmail.com>
Subject: Re: [PATCH v5 3/3] platform/chrome: Register cros_ec_accel_legacy driver
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Thierry Escande <thierry.escande@collabora.com>,
        Benson Leung <bleung@chromium.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Linux Kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Dec 7, 2017 at 1:31 AM, Lee Jones <lee.jones@linaro.org> wrote:
> On Fri, 01 Dec 2017, Gwendal Grignou wrote:
>
>> Checked against 3bf98755f9c670c5c10ca05cba22848d65117cb2 (CHROMIUM:
>> iio: accel: Add cros_ec_accel_legacy driver)
>>
>> Fixup f2b141a242e59017dbc774dc916748670a41da0b (FIXUP: CHROMIUM: iio:
>> accel: Add cros_ec_accel_legacy driver) is required for devices with
>> secondary Embedded Controllers.
>
> Is that an Ack or a NAck?
My response was incomplete: it is a nack.
Thierry's patch does match 3bf98755f9, but patch f2b141a242e should be
merged in.
>
> And pleeeeeease don't top post.
Sorry,

Gwendal.
>
>> On Fri, Dec 1, 2017 at 5:42 AM, Thierry Escande
>> <thierry.escande@collabora.com> wrote:
>> > With this patch, the cros_ec_ctl driver will register the legacy
>> > accelerometer driver (named cros_ec_accel_legacy) if it fails to
>> > register sensors through the usual path cros_ec_sensors_register().
>> > This legacy device is present on Chromebook devices with older EC
>> > firmware only supporting deprecated EC commands (Glimmer based devices=
).
>> >
>> > Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
>> > ---
>> >  drivers/mfd/cros_ec_dev.c | 53 ++++++++++++++++++++++++++++++++++++++=
+++++++++
>> >  1 file changed, 53 insertions(+)
>
> [...]
>
> --
> Lee Jones
> Linaro Services Technical Lead
> Linaro.org =E2=94=82 Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog