Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 18 Jan 2018 10:36:42 +0100 (CET)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Kan Liang <kan.liang@intel.com>
cc:     mingo@redhat.com, peterz@infradead.org,
        linux-kernel@vger.kernel.org, acme@kernel.org, eranian@google.com,
        ak@linux.intel.com
Subject: Re: [PATCH V5 1/8] perf/x86/intel/uncore: customized event_read for
 client IMC uncore
In-Reply-To: <1516042629-387021-1-git-send-email-kan.liang@intel.com>
Message-ID: <alpine.DEB.2.20.1801181036210.1847@nanos>
References: <1516042629-387021-1-git-send-email-kan.liang@intel.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 15 Jan 2018, kan.liang@intel.com wrote:

> From: Kan Liang <Kan.liang@intel.com>
> 
> There are two free running counters for client IMC uncore. The custom
> event_init() function hardcode their index to 'UNCORE_PMC_IDX_FIXED' and
> 'UNCORE_PMC_IDX_FIXED + 1'. To support the 'UNCORE_PMC_IDX_FIXED + 1'
> case, the generic uncore_perf_event_update is obscurely hacked.
> The code quality issue will bring problem when new counter index is
> introduced into generic code. For example, free running counter index.
> 
> Introduce customized event_read function for client IMC uncore.
> The customized function is exactly copied from previous generic
> uncore_pmu_event_read.
> The 'UNCORE_PMC_IDX_FIXED + 1' case will be isolated for client IMC
> uncore only.
> 
> Signed-off-by: Kan Liang <Kan.liang@intel.com>

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>