Received: by 10.223.148.5 with SMTP id 5csp7251254wrq; Thu, 18 Jan 2018 03:02:42 -0800 (PST) X-Google-Smtp-Source: ACJfBovNfK759qQVY976tkJvN5yimJNJb2VM9npIfe5HtlbjABp1Wu6qP/Wf1i0aJcJ5G/E3wvtz X-Received: by 10.84.132.14 with SMTP id 14mr14143103ple.64.1516273362483; Thu, 18 Jan 2018 03:02:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516273362; cv=none; d=google.com; s=arc-20160816; b=dVO7mJImkltMUBcDJabeU1M/74zI1TSQzMoi41psWVVz32fm1jeoyJWQkRngq8h3NV BAPuTo1rv9ZgOELwTdZJp9SbYCam6ORYD8FChqLu2jZxWdxifTiSNRoqDYG+2OLRTjzt msN3o4f1naYccSHzx2m1ocXKkI9ApLotF7sx4pAwtqaNC9fcTolNdSmwiSAQKyC5rEup Kd8N5LQ+JE4X+sOFi31RBZiCcMiWgYwzksMmrneWh65NB+jzq/Jm0NTkSySbRUnFwudk yn44cGO5bmVSrqrbqnOr8VBer6465ppLrzMz8h0hTztv5zb7F9Ur3Ybk7PaE88zzKUDo ysKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=o2t/As2eRnobKyK2E/inJB6OlT0AZaDiP5ufq18ysqI=; b=nVPKNjPve0mxFNC63PDku2wWogjYx6UrCJdi4iHsOktkZmUiQosu1Em958QOFLHDpt Vw1Uyicyb0ceioquAXSZVQVy5YyHHg2ZiYw0HNwjMDACwO4D4nN2023IZribCB6ZpbDh fxYlZktKrJChnRuC8zMrXZ5k6VPg03jI4VlJrqbKoVzaEMbSJmK5bkMYwVSqalt+JJ30 RJUtDI+Qzga87eahhU7UCdFtVUUijw9r4D3tpZb3/1/ajE0u5Z2wEyus2tZqdSdgSMHY FZY6wPoJ1PF9tZe9ZHsnIgvc8k8xmRLXpIvLg2W+nDN7oHiCbBh92sodFz/rlj3TPljX /R9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gLoJNks8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a5si6679183pll.754.2018.01.18.03.02.28; Thu, 18 Jan 2018 03:02:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gLoJNks8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754905AbeARKGu (ORCPT + 99 others); Thu, 18 Jan 2018 05:06:50 -0500 Received: from mail-it0-f44.google.com ([209.85.214.44]:45242 "EHLO mail-it0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754759AbeARKGs (ORCPT ); Thu, 18 Jan 2018 05:06:48 -0500 Received: by mail-it0-f44.google.com with SMTP id x42so12858721ita.4 for ; Thu, 18 Jan 2018 02:06:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=o2t/As2eRnobKyK2E/inJB6OlT0AZaDiP5ufq18ysqI=; b=gLoJNks80Gs5bSeU9hZotyA7cb5nd9uhr2HZcrWhps2bXesoN34/t9gez7X74xPzde 4RPyGp4VlDN8hMHQ5eYInr3XTKpPsqJqPgGVyg2DOr5yM++1eQ9L0ezMx3GtcVdysZY+ Fxmu9PgYMwkhg2utrhkLc/HNEa7CyDnSODSEQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=o2t/As2eRnobKyK2E/inJB6OlT0AZaDiP5ufq18ysqI=; b=NTk/uJoZW1FMTcii/M7xoZrbWkqoO7GpEQaWz51+qtWjy3iF+8+W4627aQUj/S98qM hKpBlud/NMvJnrWymxf8wtdbyyWwTFnl2s9TZrnl8rNMnrBQxha5160a4054ERNsq/ft mAOJ1oj98WIIT5oXjvTgH+jc1aIMJp+W1QwbNysGG+6jb69uhEo9NQJ1K8wJApLcCJp9 RFRuxd5bCkrPudoMzkckv/AZqX6BcglOVPc2XKFKEvi1znSAmSwDWiWA963ijvvtwPF4 aqMmcdxK2/o8IobdI6IHGiLVse5AO9R3XN1tNybea5qAU0wVTCtelV+D32Htd2EiXGwk Ih8A== X-Gm-Message-State: AKwxytfW6EXZmL+QTvGZ5wsFiH3dIma77F9xcMBzmiFdgo2jNuc5dV0O NpVELKZBiIcodPtZoqNXST9RaBe5vYDfMlLGzLIHvQ== X-Received: by 10.36.93.20 with SMTP id w20mr26404973ita.101.1516270007491; Thu, 18 Jan 2018 02:06:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.79.198.7 with HTTP; Thu, 18 Jan 2018 02:06:46 -0800 (PST) In-Reply-To: References: From: Linus Walleij Date: Thu, 18 Jan 2018 11:06:46 +0100 Message-ID: Subject: Re: [PATCH] crypto: ux500/hash: Add empty export and import To: Kamil Konieczny Cc: Herbert Xu , "David S. Miller" , Bartlomiej Zolnierkiewicz , linux-crypto@vger.kernel.org, "linux-kernel@vger.kernel.org" , Joakim Bech Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 16, 2018 at 5:32 PM, Kamil Konieczny wrote: > Crypto framework will require async hash export/import, so add empty > functions to prevent OOPS. > > Signed-off-by: Kamil Konieczny Acked-by: Linus Walleij But why isn't the framework code just checking the vtable for NULL? if (foo->fp) foo->fp(bar); Yours, Linus Walleij