Received: by 10.223.148.5 with SMTP id 5csp7321243wrq; Thu, 18 Jan 2018 04:08:58 -0800 (PST) X-Google-Smtp-Source: ACJfBoumzN+9QrKSZQQNs9JBd9KeNveT01HJ8WlIqAtMC3qPkcVjbKBJiUi3HHgBEIShuQ9O299t X-Received: by 10.98.13.14 with SMTP id v14mr15138369pfi.184.1516277338460; Thu, 18 Jan 2018 04:08:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516277338; cv=none; d=google.com; s=arc-20160816; b=DIE7JWZpbAQSWzxiRLW9t1MwzaJ+4jbR6Jf0GLmbZLJHto75Ct8HcvP6e+w517RibI Aj14q9bmK0sNd7UGV2dGs68DlCRv5hq3Yg02GCe+Y+z0BOthSO6/WgwtXdH0BlKsyiQP R1UAPEyr04H2lomDcNyz1z8j2Ddpgmh0xCOfjlt8R93QKJGszm15xbOt9qiMU9GeyRLV uydV3OA8RA9CUAYdyZbmGcumjbmzkHBFKfzhSgk5xCBkRo6DCNfku5l8BxvtIYTAObvQ Xm3J/G/Nh/lGfyEDC2m1bhFSjE3pAQBZI/uVaHSnZqixfs0LnTTPsNOy+HlhxIBcIcoQ l7wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=6WdXuiWGiXRTJFnqjux5Cgpr5LSwA2Jux+e/kkGGwas=; b=t6XiI0doNnE8qNuaUYspi09XqunzHowyDVmh+NtqLZA/pde7YOmvAU/ucDaNOKLoe8 8WFoWCurHJppYb1fBAPI79HXYZ0nDX7OgH84i3iEGywGG/RE+K2ExLdLJqyHTmWaMlNy dBhshxToxF5n3TANtW4sdBP7sGzRKIPtyWCaVDYkbR+ZNx1Wy0PkJr9rmddJ3o1AzB5M MyzzY2GsBz4Y/CRh7OQ1lhIds9vDi2CbNHe2gOOX48Bb2qTkhKb2N0m4nHPlyYnNDsPv PQ4r5wFuv3V2AlaxG+byWmqlSSCkr3Cr3dWFYW0HD1+v4WLjga/qN4FFsaDcmFNuwaa2 qZ4g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n3si5943170pgf.60.2018.01.18.04.08.44; Thu, 18 Jan 2018 04:08:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755304AbeARMGX (ORCPT + 99 others); Thu, 18 Jan 2018 07:06:23 -0500 Received: from [128.1.224.119] ([128.1.224.119]:55438 "EHLO ringil.hmeau.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753975AbeARMGW (ORCPT ); Thu, 18 Jan 2018 07:06:22 -0500 Received: from gondolin.me.apana.org.au ([192.168.0.6] helo=gondolin.hengli.com.au) by norbury.hmeau.com with esmtp (Exim 4.80 #3 (Debian)) id 1ec8up-0001bY-Ct; Thu, 18 Jan 2018 23:03:31 +1100 Received: from herbert by gondolin.hengli.com.au with local (Exim 4.80) (envelope-from ) id 1ec8uY-0005UV-Bj; Thu, 18 Jan 2018 23:03:14 +1100 Date: Thu, 18 Jan 2018 23:03:14 +1100 From: Herbert Xu To: Robin Murphy Cc: boris.brezillon@free-electrons.com, arno@natisbad.org, davem@davemloft.net, hch@lst.de, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: marvell/cesa - Fix DMA API misuse Message-ID: <20180118120314.GG20717@gondor.apana.org.au> References: <55d3177407b00dd4a9d51fe4f8e2bf2282fe8e3d.1515596541.git.robin.murphy@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55d3177407b00dd4a9d51fe4f8e2bf2282fe8e3d.1515596541.git.robin.murphy@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 10, 2018 at 03:15:43PM +0000, Robin Murphy wrote: > phys_to_dma() is an internal helper for certain DMA API implementations, > and is not appropriate for drivers to use. It appears that what the CESA > driver really wants to be using is dma_map_resource() - admittedly that > didn't exist when the offending code was first merged, but it does now. > > Signed-off-by: Robin Murphy Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt