Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Reply-To: minyard@acm.org
Subject: Re: [PATCH -next] ipmi/powernv: Fix error return code in
 ipmi_powernv_probe()
To:     Alexey Kardashevskiy <aik@ozlabs.ru>,
        Wei Yongjun <weiyongjun1@huawei.com>,
        Corey Minyard <minyard@acm.org>, Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Michael Ellerman <mpe@ellerman.id.au>
Cc:     openipmi-developer@lists.sourceforge.net,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
References: <1516188311-144227-1-git-send-email-weiyongjun1@huawei.com>
 <fb154ee5-4934-f6f8-dae5-168c03f0d3a5@ozlabs.ru>
From:   Corey Minyard <tcminyard@gmail.com>
Message-ID: <6ab96d83-5ec3-e882-7bfc-fe072c101666@gmail.com>
Date:   Thu, 18 Jan 2018 08:05:22 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <fb154ee5-4934-f6f8-dae5-168c03f0d3a5@ozlabs.ru>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 01/17/2018 10:04 PM, Alexey Kardashevskiy wrote:
> On 17/01/18 22:25, Wei Yongjun wrote:
>> Fix to return a negative error code from the request_irq() error
>> handling case instead of 0, as done elsewhere in this function.
>>
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>
> Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>

Queued for next release.  Thanks!

-corey

>
>
>> ---
>>   drivers/char/ipmi/ipmi_powernv.c | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/char/ipmi/ipmi_powernv.c b/drivers/char/ipmi/ipmi_powernv.c
>> index c687c8d..bcf493d 100644
>> --- a/drivers/char/ipmi/ipmi_powernv.c
>> +++ b/drivers/char/ipmi/ipmi_powernv.c
>> @@ -250,8 +250,9 @@ static int ipmi_powernv_probe(struct platform_device *pdev)
>>   		ipmi->irq = opal_event_request(prop);
>>   	}
>>   
>> -	if (request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
>> -				"opal-ipmi", ipmi)) {
>> +	rc = request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
>> +			 "opal-ipmi", ipmi);
>> +	if (rc) {
>>   		dev_warn(dev, "Unable to request irq\n");
>>   		goto err_dispose;
>>   	}
>>
>