Received: by 10.223.148.5 with SMTP id 5csp7569564wrq; Thu, 18 Jan 2018 06:59:31 -0800 (PST) X-Google-Smtp-Source: ACJfBouGORuXyDuGCIuM/fVP67bN2jvJGjidaO68UMuYGagzA6mriAJayYgieKTb8tM+TcEop+Ok X-Received: by 10.98.225.7 with SMTP id q7mr6203410pfh.22.1516287571835; Thu, 18 Jan 2018 06:59:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516287571; cv=none; d=google.com; s=arc-20160816; b=Kt5Ty4McKS3yC21f/aJiAY0EI9+7kI1WLkvsrXmwnINTmEvHvKFoyrsPCpXq20t3l+ sx3Rf9eNJBJ96KCw3VcJJE6cGKd2857wVjzjx8PJtOlLCIqLJeyt+ZqmLVVnXRlv/23e V+WNQt3UZguHQ4ofoqCERojTaTRSnGblADhm7RClVcU/4IMap03ZOlamDxIXc0ItbJyy cYJ77Za90HHHyJvopj9FmQO3BWZjcZ62bqvuVclZ4V6kf1E/AZcDcFw/h6rGeQFqmchz CziOEFywVAtIZTl8Q05eLpsiH+9iM3A5/RIsbLnvgQMAuOK07grofu7jFyHImSEfY3LA Y9jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=1grOpkLEAkt7wObYhYuFuB1o81WK3J0vUUtKyDV+9/0=; b=wdtRLzWW6r6fhO6+hjxWubxoVYL2lwNt/rMAz/UUErRAN0Xycf/s2hOphWyb3Kpgaw My3cznyunFDdz0MIQicjpZ1DqlfBNwbxbiYsn3JN+/HPsiGVCbwzTIQz2uaGPXAgI4a9 CTdXHgSfeLJ7wk9AeHTL1EMpVxlXR6l7w1dMUsPWXm46H27Bsu5yDQ3l3giY0Stzq2xJ C8GjyEmJO/oKb/uPFugsGI83m/DWTT6fGbmQpMyum/bBrCNHH5NyJH1ULvl9pUNw9C9D DYd/F5cG2+pykv26SdOdn2geNTGlTpi7w0+u1A5E152WUH7uDXLmEWtzd10idbOW2ch2 awWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gxnGGNeU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s184si6267114pgb.544.2018.01.18.06.59.17; Thu, 18 Jan 2018 06:59:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gxnGGNeU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755800AbeARNIE (ORCPT + 99 others); Thu, 18 Jan 2018 08:08:04 -0500 Received: from mail-wr0-f181.google.com ([209.85.128.181]:37131 "EHLO mail-wr0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753361AbeARNIC (ORCPT ); Thu, 18 Jan 2018 08:08:02 -0500 Received: by mail-wr0-f181.google.com with SMTP id f11so11998201wre.4 for ; Thu, 18 Jan 2018 05:08:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1grOpkLEAkt7wObYhYuFuB1o81WK3J0vUUtKyDV+9/0=; b=gxnGGNeUM0IgiBXMaq5wtE2F0CdeFke6oAxiG7z3Rf7SMnfzMZZLUWaHbNLue147lT aBNsOlKgIUfNDvQWmw+GftBhf6b94Xo3lEkTPXjhMl+YnzNYNvLHtTZ7TfGWyIlfPPQY aareWPds6OZz3HHYJClevT2+OldvGlwLv621v2+y1lFyF88d+O0iiGwsA06pReEHW75w fE+R3dOJPRbM7YnEHrxJk9MtDpoa7py3ZN9M3Iy9HNqn5197x0HCkxW3vHEvn1G2TH57 +FSOqHz77rLPAaxGOp1F1H3RG7y3mjIrJPj5g1q5jD3s2dyDasSjMYcu5sZC3zvSppXk suBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1grOpkLEAkt7wObYhYuFuB1o81WK3J0vUUtKyDV+9/0=; b=e1dfUeRhdmxbN9dBGdkp8tvRalFXp9+P/jOA4ibxyjPhfMOZ781LA2ew6mHkaduMx5 Sl5okwwehi+/Yl48saSJJt0XA1OKP0s2WKMghANTvwwyScwNCoGj7GFl5q7iUq7h92mO maXcRluEZo8jPEuth5oAEnVD8r8CmdjuqrXddq/23F0Uj1wOKUlroKz3Puy2joqITIq3 A4bjL+BwCtAMors+ZjzU+yTrd+lPIZUmRr3cWsXzV51WoOl/4OGLS4RRGn6RqgOkHjPL DZwGVU4RHkvEFdj4ElZ8kwXNUwWFpmXyXbR1KmPrCth5ZXJWtd4ZA9Ev83LGeiRpjdqd Jo9g== X-Gm-Message-State: AKwxytfZxg279H6aDn9zC/ij/RVDdkQO8JTnln9FQ8CPnL9ZqUUR771Y W2nijMslv97tXQuSpg1pf1kVg78Ha4POoci7ciU= X-Received: by 10.223.134.227 with SMTP id 32mr6542559wry.176.1516280881723; Thu, 18 Jan 2018 05:08:01 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.87.129 with HTTP; Thu, 18 Jan 2018 05:08:01 -0800 (PST) In-Reply-To: References: <20180117140159.27611-1-daniel.vetter@ffwll.ch> <20180117140159.27611-2-daniel.vetter@ffwll.ch> From: Emil Velikov Date: Thu, 18 Jan 2018 13:08:01 +0000 Message-ID: Subject: Re: [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state To: Daniel Thompson Cc: Daniel Vetter , DRI Development , LKML , Jingoo Han , Daniel Vetter , Lee Jones Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17 January 2018 at 16:37, Daniel Thompson wrote: > > > On 17/01/18 14:36, Emil Velikov wrote: >> >> On 17 January 2018 at 14:01, Daniel Vetter wrote: >>> >>> Nothing in the entire tree ever sets this, which means this is dead >>> code. Remove it. >>> >>> Cc: Lee Jones >>> Cc: Daniel Thompson >>> Cc: Jingoo Han >>> Signed-off-by: Daniel Vetter >>> --- >>> drivers/video/backlight/generic_bl.c | 5 ----- >> >> >> Fly-by comment, while waiting for coffee to kick-in. >> I think this patch should be after pandora/others have stopped abusing >> BL_CORE_DRIVER1. > > > You sure? > > I can't see why the use or disuse of BL_CORE_DRIVER1 in this driver should > influence another independent driver. > Right my bad. Got mislead by the driver name. -Emil