Received: by 10.223.148.5 with SMTP id 5csp7571703wrq; Thu, 18 Jan 2018 07:00:53 -0800 (PST) X-Google-Smtp-Source: ACJfBouKnSZtoT/ezsZpe8FmYJlg7WF2QoTxDTnIFqNx9wGUxdhgZspfdoLoZ+g2K4hnCrV6gcA6 X-Received: by 10.202.94.134 with SMTP id s128mr3335443oib.18.1516287653193; Thu, 18 Jan 2018 07:00:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516287653; cv=none; d=google.com; s=arc-20160816; b=E9IUrS3jtVaixmqTRPafQL7gtDZuqhWBLSVck2vXUIVYoWDqGtEGsV3YkyP2DOCy0B 3wPUi8PKpE3Pg1m5Rz+bwysqNDxk7y46N++eh+ikhUyUeb+L6hAyqg+k3kyw8OOrRC8q q6bJX6muWlzngdkDrnUF/fAetziV6cMOGhtf5Yl5WwoIdHmEsf2udFEUbplUz57m8/oC klio+ggNZ/WXvCsw0GQQa3bP5yDTVwfk/Ov/xgDSdy+zZtUDXUHV7J+W6530nvXe/sxY Lm6t/bVreTL1XuONU46COa+qJLtxPKbjro7qUKNsj4iC3RIZRtIj5UMk3BjTcYnd5qct N9jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dmarc-filter :arc-authentication-results; bh=yTgc38yfES/VrOySjwms80r4SjAUacON+wTOWvZPtd0=; b=peX9RbRuLW6k1F+LAyNG9VMAWZqpqI2FtCALohlezPwHa+wZYbe3ZJ+cIx41hm5TU3 f2egwYD22te/dfWlD4CYnRJhcX3tF6hEgJMr+pzRYAoNa19TNvPitTYbyL209NdwSPPZ YzSIlx1Of3hbUjI+QEABTilvNwZRCcVptTtBFub7/E61qTwYec3FPfsAA2j4QIM/k3d2 9B944Tbi6znxwkxrRWjFnYCd79k+gGmJeLz90C9AhmbAp2CQLi/PSCKevd6z3T+/doRL g/YEClHA+5wwUeFyVAoEQTE7fcM1KC4NXPEfTJkYRBBBmZ9OwR64abBOAGcUgbYcfI64 S0Xg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k12si4392860pgt.109.2018.01.18.07.00.38; Thu, 18 Jan 2018 07:00:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756514AbeARO5i (ORCPT + 99 others); Thu, 18 Jan 2018 09:57:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:38110 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756351AbeARO5h (ORCPT ); Thu, 18 Jan 2018 09:57:37 -0500 Received: from mail-qt0-f179.google.com (mail-qt0-f179.google.com [209.85.216.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0A94D2176D; Thu, 18 Jan 2018 14:57:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A94D2176D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh+dt@kernel.org Received: by mail-qt0-f179.google.com with SMTP id z10so2714371qti.5; Thu, 18 Jan 2018 06:57:37 -0800 (PST) X-Gm-Message-State: AKwxytfH6lSHib/AWj/TKEleIcQoZtzWTATJx2h7kC0fIueIp9OQwIRo ZzU02xleN7ObFaQ8jgJ5OHdgscVD8EkPExJtEQ== X-Received: by 10.237.58.132 with SMTP id o4mr40797827qte.207.1516287456191; Thu, 18 Jan 2018 06:57:36 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.130.36 with HTTP; Thu, 18 Jan 2018 06:57:15 -0800 (PST) In-Reply-To: <1516272219-25359-1-git-send-email-sudeep.holla@arm.com> References: <1516272219-25359-1-git-send-email-sudeep.holla@arm.com> From: Rob Herring Date: Thu, 18 Jan 2018 08:57:15 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH -next] of: platform: fix OF node refcount leak To: Sudeep Holla Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , Loys Ollivier , Andy Gross , Bjorn Andersson , Frank Rowand Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 18, 2018 at 4:43 AM, Sudeep Holla wrote: > We need to call of_node_put() for device nodes obtained with > of_find_node_by_path(). > > Fixes: 3aa0582fdb82 ("of: platform: populate /firmware/ node from of_platform_default_populate_init()") > Reported-by: Loys Ollivier > Cc: Rob Herring > Cc: Frank Rowand > Signed-off-by: Sudeep Holla > --- > drivers/of/platform.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > Hi Rob, > > You had Acked the original patch and it's queued via ARM SoC. So can you > please provide ack on this if you are OK with the change. Acked-by: Rob Herring