Received: by 10.223.148.5 with SMTP id 5csp7605137wrq; Thu, 18 Jan 2018 07:24:16 -0800 (PST) X-Google-Smtp-Source: ACJfBovybFojyPNs1D7JbZuL14qThRrnZr9SZ87BrQ1ANUpO6ssQwVTfy3h7884vmaigvYOwN7tu X-Received: by 10.99.116.23 with SMTP id p23mr31997488pgc.60.1516289056024; Thu, 18 Jan 2018 07:24:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516289055; cv=none; d=google.com; s=arc-20160816; b=q1/IwqzZxmSQvOg8nbGWiwwztC6y1vM1scfWf02nbE+8jIGGYzttrPT+J94q+DFclV vaj+4ITuPdhMJiCg3SJbJq/AvUwnknZvslIP0xCF74oYVNZ3qJptbzT63f2n1gRAJ+93 fsPSC5u3XiFc79VlzdSNJdS7GbU15XNDb4/llwvCS2HxnxgG8OqUr4qUzxZU+mJh03UO 5biqRoiutl3XnaWGjUENzu5+fiiBQSmuX77KGLrdfqNqrlHl5Sl3caCHLh0vO4AM6c1L kOZKFtTdewEYcPh/PFUn9lSttxBp25nY5SiFwz0JO9ZyW7jNGTgX1nmSx5DuEby1V6+Z angQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=hcz4MDSqETBCj0ksD3XvKi/zAhffb0vak6Jhca9M2t0=; b=Burb1ZltHYLYCqiShwa9k9Gww6pdjKwbUJavGNAg/osy92E4v3O2kMzVOMbWkvkk3j N5KG6opC/NtlrWQ6mPKJZriWjPj6YFfI8Gflu0u0hy1rfjS0Twu6R9SuXxwbz69E0SVI 4l9lKxusOCXstlFoPdynJNOu0sgnQbGp6J8j5+LZRfZWXPbxlweqJi1U2NJO+KowboLN /ZtqHItpr9s61imWCgqj38raSBfe3y/XqI6U6B8UtfoxWKbxVF6aCmy1Hr+Q9YVp124j eD8NCQHU+jyf1h7TS/l1Pm4UQdAGHlHYY+wpvDgkPCVWytaiKRzGjGOaxNMbm8VQlrOg 0Bew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=cGGXef/I; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u77si7110350pfd.165.2018.01.18.07.24.02; Thu, 18 Jan 2018 07:24:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=cGGXef/I; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932653AbeARPXS (ORCPT + 99 others); Thu, 18 Jan 2018 10:23:18 -0500 Received: from mail-it0-f49.google.com ([209.85.214.49]:41322 "EHLO mail-it0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932124AbeARPXQ (ORCPT ); Thu, 18 Jan 2018 10:23:16 -0500 Received: by mail-it0-f49.google.com with SMTP id b77so13889004itd.0 for ; Thu, 18 Jan 2018 07:23:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hcz4MDSqETBCj0ksD3XvKi/zAhffb0vak6Jhca9M2t0=; b=cGGXef/IO/DopY3GIOQuDx8LXezg1gOMPmGNclh5vNuwptAZOQCFLXRm7tFTlksXVw 1/cyGODWecSV2UNB5EhbxK8DxFJ6p0cMcGrvOthes7/G4LxW4Yx6oLFH1OvbBtDs3A+2 jKpYqEwml3rDO/KAzs6/I9tXnuRGEDs45nL1W4C4VJkA9BfAmONgbeN0KIZw4kE/D8He CVOeQUc+yJ7bHP9i7Uso77IfeKBYAq7dSGwimXJ6ycmqibjU8dQmvW7X9M+75yPpJi3q am4M7N5wwhY5/73UHkzDng2qpgEt5CS6jKf3R+j3qKGP5/rp3YZ365+3OwFyXhpVXeYU kSNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hcz4MDSqETBCj0ksD3XvKi/zAhffb0vak6Jhca9M2t0=; b=AuLgjKidbqsra7FlYR53LbUUk5yD6Xw3+HhGeOI6AMYVeSfJ6XhAUR4u9xERSQuqAC ae8ZiFlzpEQvB0kU39CSxJssoIT3AELoM0GxSncrdG53H1EVuPIKFz175bEr1FdHNNYr fY90No2N701QkQKdDJaXHgPnkiqWLSeL+49amPqyGFjXHdOVyy8fVbncZBMEXZOXxpxL bxmX2+GWstxWGg6CS1BVTjqjX/k/klU0BXeTKyyas6sRhSz1BKm0miEppp8SOgwjJapW A69vbMmVsF31G7p4IvNZn2blzUlQI+GHNAPn6a+rFFYzBIQ3ga8dwgZXpIF3F6NtAres NsgA== X-Gm-Message-State: AKwxytdlxgGgQvX1h4EOysV5HMLDDrTe+3ZaBkKZauVPBVGsQSkz8mnA CL22j+pvtXSjLHGcHEx2CK8p3Q== X-Received: by 10.36.184.133 with SMTP id m127mr27840209ite.150.1516288995460; Thu, 18 Jan 2018 07:23:15 -0800 (PST) Received: from [192.168.1.160] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id d186sm3881982itd.22.2018.01.18.07.23.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jan 2018 07:23:14 -0800 (PST) Subject: Re: [PATCH BUGFIX/IMPROVEMENT 0/2] block, bfq: two pending patches To: Paolo Valente Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, broonie@kernel.org, linus.walleij@linaro.org, bfq-iosched@googlegroups.com, oleksandr@natalenko.name References: <20180113110518.2519-1-paolo.valente@linaro.org> From: Jens Axboe Message-ID: <55d37f66-019d-2ded-2559-16930466d644@kernel.dk> Date: Thu, 18 Jan 2018 08:23:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Thunderbird/58.0 MIME-Version: 1.0 In-Reply-To: <20180113110518.2519-1-paolo.valente@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/13/18 4:05 AM, Paolo Valente wrote: > Hi Jens, > here are again the two pending patches you asked me to resend [1]. One > of them, fixing read-starvation problems, was accompanied by a cover > letter. I'm pasting the content of that cover letter below. > > The patch addresses (serious) starvation problems caused by > request-tag exhaustion, as explained in more detail in the commit > message. I started from the solution in the function > kyber_limit_depth, but then I had to define more articulate limits, to > counter starvation also in cases not covered in kyber_limit_depth. > If this solution proves to be effective, I'm willing to port it > somehow to the other schedulers. It's something we've been doing in the old request layer for tagging for a long time (more than a decade), so a generic (and fast) solution that covers all cases for blk-mq-tag would indeed be great. For now, I have applied these for 4.16, thanks. -- Jens Axboe