Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180114141205.26814-1-ulfalizer@gmail.com>
References: <20180114141205.26814-1-ulfalizer@gmail.com>
From:   Masahiro Yamada <yamada.masahiro@socionext.com>
Date:   Fri, 19 Jan 2018 01:47:03 +0900
Message-ID: <CAK7LNATbquS2RDGDK0xYv9bG8UsqFh9HXiyUR-BF995qQ3OjMQ@mail.gmail.com>
Subject: Re: [PATCH] kconfig: Clarify choice dependency propagation
To:     Ulf Magnusson <ulfalizer@gmail.com>
Cc:     Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Sam Ravnborg <sam@ravnborg.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2018-01-14 23:12 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>:
> It's easy to miss that choices are special-cased to pass on their mode
> as the parent dependency.
>
> No functional changes. Only comments added.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---
>  scripts/kconfig/menu.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
> index 92d3f06cd8a2..53964d911708 100644
> --- a/scripts/kconfig/menu.c
> +++ b/scripts/kconfig/menu.c
> @@ -323,6 +323,13 @@ void menu_finalize(struct menu *parent)
>                                 if (menu->sym && menu->sym->type == S_UNKNOWN)
>                                         menu_set_type(sym->type);
>                         }
> +
> +                       /*
> +                        * Use the choice itself as the parent dependency of
> +                        * the contained items. This turns the mode of the
> +                        * choice into an upper bound on the visibility of the
> +                        * choice symbols.
> +                        */

Does the last "choice symbols" mean "choice values"?
The "choice" itself is a symbol with NULL name,
so I'd like to clarify it.


-- 
Best Regards
Masahiro Yamada