Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <CAK7LNATbquS2RDGDK0xYv9bG8UsqFh9HXiyUR-BF995qQ3OjMQ@mail.gmail.com>
References: <20180114141205.26814-1-ulfalizer@gmail.com> <CAK7LNATbquS2RDGDK0xYv9bG8UsqFh9HXiyUR-BF995qQ3OjMQ@mail.gmail.com>
From:   Ulf Magnusson <ulfalizer@gmail.com>
Date:   Thu, 18 Jan 2018 17:58:46 +0100
Message-ID: <CAFkk2KQEsS1L19wOVQJMQdiWGCxTYMq5BmyQ=_RBy9rHt6Un0w@mail.gmail.com>
Subject: Re: [PATCH] kconfig: Clarify choice dependency propagation
To:     Masahiro Yamada <yamada.masahiro@socionext.com>
Cc:     Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Sam Ravnborg <sam@ravnborg.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jan 18, 2018 at 5:47 PM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> 2018-01-14 23:12 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>:
>> It's easy to miss that choices are special-cased to pass on their mode
>> as the parent dependency.
>>
>> No functional changes. Only comments added.
>>
>> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
>> ---
>>  scripts/kconfig/menu.c | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
>> index 92d3f06cd8a2..53964d911708 100644
>> --- a/scripts/kconfig/menu.c
>> +++ b/scripts/kconfig/menu.c
>> @@ -323,6 +323,13 @@ void menu_finalize(struct menu *parent)
>>                                 if (menu->sym && menu->sym->type == S_UNKNOWN)
>>                                         menu_set_type(sym->type);
>>                         }
>> +
>> +                       /*
>> +                        * Use the choice itself as the parent dependency of
>> +                        * the contained items. This turns the mode of the
>> +                        * choice into an upper bound on the visibility of the
>> +                        * choice symbols.
>> +                        */
>
> Does the last "choice symbols" mean "choice values"?
> The "choice" itself is a symbol with NULL name,
> so I'd like to clarify it.

Yep, means the choice values (which are symbols). "Choice values"
would probably be clearer, yeah, or maybe "choice value symbols".

Should I submit a new version? I'm fine with just a
's/symbols/values/' or 's/symbols/value symbols/' otherwise.

Cheers,
Ulf