Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 18 Jan 2018 11:02:55 -0600
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     tip-bot for Andi Kleen <tipbot@zytor.com>
Cc:     linux-tip-commits@vger.kernel.org, linux-kernel@vger.kernel.org,
        gregkh@linuxfoundation.org, ak@linux.intel.com, dwmw@amazon.co.uk,
        mingo@kernel.org, hpa@zytor.com, tglx@linutronix.de
Subject: Re: [tip:x86/pti] module: Add retpoline tag to VERMAGIC
Message-ID: <20180118170255.wgcqrqiflikd3tmz@treble>
References: <20180116205228.4890-1-andi@firstfloor.org>
 <tip-6cfb521ac0d5b97470883ff9b7facae264b7ab12@git.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <tip-6cfb521ac0d5b97470883ff9b7facae264b7ab12@git.kernel.org>
User-Agent: Mutt/1.6.0.1 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jan 17, 2018 at 02:40:43AM -0800, tip-bot for Andi Kleen wrote:
> Commit-ID:  6cfb521ac0d5b97470883ff9b7facae264b7ab12
> Gitweb:     https://git.kernel.org/tip/6cfb521ac0d5b97470883ff9b7facae264b7ab12
> Author:     Andi Kleen <ak@linux.intel.com>
> AuthorDate: Tue, 16 Jan 2018 12:52:28 -0800
> Committer:  Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Wed, 17 Jan 2018 11:35:14 +0100
> 
> module: Add retpoline tag to VERMAGIC
> 
> Add a marker for retpoline to the module VERMAGIC. This catches the case
> when a non RETPOLINE compiled module gets loaded into a retpoline kernel,
> making it insecure.
> 
> It doesn't handle the case when retpoline has been runtime disabled.  Even
> in this case the match of the retcompile status will be enforced.  This
> implies that even with retpoline run time disabled all modules loaded need
> to be recompiled.

If the user overrides the vermagic and loads the module, shouldn't we
update the spectre_v2 sysfs vulnerability status and print a warning
like in v2?

-- 
Josh