Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 18 Jan 2018 18:14:30 +0100
From:   Paul Cercueil <paul@crapouillou.net>
Subject: Re: [PATCH v7 11/14] MIPS: ingenic: Initial JZ4770 support
To:     James Hogan <james.hogan@mips.com>
Cc:     Ralf Baechle <ralf@linux-mips.org>,
        Maarten ter Huurne <maarten@treewalker.org>,
        linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Message-Id: <1516295670.1423.0@smtp.crapouillou.net>
In-Reply-To: <20180117212853.GC27409@jhogan-linux.mipstec.com>
References: <20180105182513.16248-2-paul@crapouillou.net>
        <20180116154804.21150-1-paul@crapouillou.net>
        <20180116154804.21150-12-paul@crapouillou.net>
        <20180117212853.GC27409@jhogan-linux.mipstec.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi James,

Le mer. 17 janv. 2018 =E0 22:28, James Hogan <james.hogan@mips.com> a=20
=E9crit :
> On Tue, Jan 16, 2018 at 04:48:01PM +0100, Paul Cercueil wrote:
>>  Provide just enough bits (clocks, clocksource, uart) to allow a=20
>> kernel
>>  to boot on the JZ4770 SoC to a initramfs userspace.
>>=20
>>  Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>>  Reviewed-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
>=20
>=20
>>  diff --git a/arch/mips/jz4740/time.c b/arch/mips/jz4740/time.c
>>  index bb1ad5119da4..2ca9160f642a 100644
>>  --- a/arch/mips/jz4740/time.c
>>  +++ b/arch/mips/jz4740/time.c
>>  @@ -113,7 +113,7 @@ static struct clock_event_device=20
>> jz4740_clockevent =3D {
>>   #ifdef CONFIG_MACH_JZ4740
>>   	.irq =3D JZ4740_IRQ_TCU0,
>>   #endif
>>  -#ifdef CONFIG_MACH_JZ4780
>>  +#if defined(CONFIG_MACH_JZ4770) || defined(CONFIG_MACH_JZ4780)
>>   	.irq =3D JZ4780_IRQ_TCU2,
>>   #endif
>>   };
>>  --
>>  2.11.0
>>=20
>=20
> MACH_INGENIC selects SYS_SUPPORTS_ZBOOT_UART16550, so I wonder whether
> arch/mips/boot/compressed/uart-16550.c needs updating for JZ4770 like
> commit ba9e72c2290f ("MIPS: Fix build with DEBUG_ZBOOT and=20
> MACH_JZ4780")
> does for JZ4780.
>=20
> Otherwise the non-DT bits look reasonable (I've not really looked
> properly at the DT):
> Reviewed-by: James Hogan <jhogan@kernel.org>
>=20
> Cheers
> James

I will fix it in a separate patch, if you don't mind.

-Paul
=