Received: by 10.223.148.5 with SMTP id 5csp7772581wrq; Thu, 18 Jan 2018 09:17:10 -0800 (PST) X-Google-Smtp-Source: ACJfBouMI44G1+nj4h2fMHB/nJ2/vMvi5j1fbT8dXSFfcwU6VyXxaahN76QmWLGHV8ez7Fo+CIcf X-Received: by 2002:a17:902:3363:: with SMTP id a90-v6mr120485plc.159.1516295830251; Thu, 18 Jan 2018 09:17:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516295830; cv=none; d=google.com; s=arc-20160816; b=aZ9re49DerSZrpxPEkeNQld2Gl+f+++fBjBMXeGPzxEEkri2dA7ld0d51gBHmlSvz6 /iLd1bXrpqSJD8GFL2CZKktFxcEN0eeRLChT1zAk/IWqXFYH20ZUGpxWkljvmGFSvBuL o4KCXncGH9L2VHwAg4D0oFMOUD2ItaqjZet8cczXPN/q+2IxFmYU6GG1ujbxUQRA/3UW ls2lF3p2wO7QZfKPm6472yaT6s1NaCKJFUkblAuovnv8zwW32bOZVhZRkPoQUqOi8rF6 GpTEkkLtoHTM3/oaTVQyRMzNIG73+gd8Q0y69yBy/XrwzDuR//2hkLJ8w2N5J2dxsvtu t12w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=fRjlYEINpAGbDLAQto7cswq5JolJWfdZUzyiXF+IMrg=; b=lT6d2gwl5TE3h/nQX6tMOMz4712mCcPznfSZ+mQVQv2DyoJblVw2MaZoW3jkk6b145 C7j+DVJisQrGJ+Hh/5ga0Kofj1Zd+5E8I1swYv2QApBvK1CVDlYo306u6APIKYSxMSvf XGu0YGI/00Rg8UIjf+RN/KK7JkxpHpG6vW0ujBQMWuquEPcp0Lx5BsYV8Wfpp8VNj2EV NpPPY+/BMeN9UVzfNNYdYGI5V2Xe49bEEdHzjynrDrSjRQUd/vgD0hS7PUSlyEL9z0Rp yEX0eL3MXrTMSQcql+gwhJ/3HrJ8UBiGFMf4jOjNW7s2R5MilQnBKA2X5J0J++apX6YT qzXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aQi1cqR5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d83si7333245pfk.34.2018.01.18.09.16.55; Thu, 18 Jan 2018 09:17:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aQi1cqR5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755395AbeARRQP (ORCPT + 99 others); Thu, 18 Jan 2018 12:16:15 -0500 Received: from mail-io0-f193.google.com ([209.85.223.193]:43851 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754935AbeARRQM (ORCPT ); Thu, 18 Jan 2018 12:16:12 -0500 Received: by mail-io0-f193.google.com with SMTP id 72so1968920iom.10 for ; Thu, 18 Jan 2018 09:16:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=fRjlYEINpAGbDLAQto7cswq5JolJWfdZUzyiXF+IMrg=; b=aQi1cqR5C2IbXbXzdQtayXpHoWYnoQqbLdRDfXJ6pQFaN4rZ8KiPoCNghWVJhpzyOp NzRqrTHquWUW+HaDhr1MofzMRhwPdvq4yg9wpBovSpKQT/RAPNQe2DUARPZlHND2GjwX QCmw7b5FlF8Fefinp+U8a5R+8rM5Bfc+JwvqY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fRjlYEINpAGbDLAQto7cswq5JolJWfdZUzyiXF+IMrg=; b=HjIbJ6h4GHtUNsR/dbPR1pTQqDtng2T64wjvsgs/5Uqe5GqcS7pZpkk492Oe6nHLtP CO6Cp63REjJFZ+zRFWRprdqT3trPy4tp66n31WYrqBSRms/R7WbRGUXSKqjBaP0jEzL3 0N6cQTso6dnhGtStlvJew32NY+CVF3sBYSTfEJXEMt3wq0TrtslkcjlacIea7qeQjdGR c6yFmwrNKLUFAwGzX+qQC5PnS9mVAVDPhLbokUx6hY79N88fhNefgSv+txLAhLBpAwSW XG+DG4+UFAc10pet+KpEmU/NaUuyrOLcTzQXntR6hh8MHf6LCWdjvD0EkxTEmcV7C9/T jWvA== X-Gm-Message-State: AKwxytevJzlQnZpTsebnpP3EUFVcZAq0g1/Qr4IMboH2eVd/7RKbzOch bcSVhqXVHd1xVcK5kgb02bdVcn+la9KfSd+eBKzVQw== X-Received: by 10.107.9.213 with SMTP id 82mr21212384ioj.295.1516295771648; Thu, 18 Jan 2018 09:16:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.2.160.195 with HTTP; Thu, 18 Jan 2018 09:16:11 -0800 (PST) In-Reply-To: <1516286070-24927-1-git-send-email-patrice.chotard@st.com> References: <1516286070-24927-1-git-send-email-patrice.chotard@st.com> From: Ulf Hansson Date: Thu, 18 Jan 2018 18:16:11 +0100 Message-ID: Subject: Re: [PATCH v3 00/14] Add MMCI support for STM32F SoCs family To: Patrice CHOTARD Cc: Russell King , Michael Turquette , Stephen Boyd , Linus Walleij , Rob Herring , Mark Rutland , Alexandre Torgue , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , linux-clk , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18 January 2018 at 15:34, wrote: > From: Patrice Chotard > > This series reworks patches submitted one year ago by Andrea Merello [1] > but without succeed to merged it. > > STM32F4 and STM32F7 SoCs families embeds a variant of the ARM PrimeCell > PL18x SD host controller, for which the mmci driver exists. > This series adds support for these SoCs to the mmci driver. > > As other variants, this one need some specific quirks, that this > series address. > > This series has been tested on following boards : > _ stm32f429-eval > _ stm32f469-disco > _ stm32f746-eval > _ stm32f769-disco > > DT update for stm32f7 pinctrl, stm32f746-eval and stm32f769-disco boards > will be sent later to avoid conflict with pending stm32f7 series [1] which > is not yet merged on kernel mainline. > > [1] https://www.spinics.net/lists/linux-mmc/msg41616.html > [2] https://patchwork.kernel.org/patch/10104447/ > > v3: _ patch 3: use variant->opendrain instead of host->variant->opendrain > _ patch 4: exit from probe() if no pinctrl dt node are found > _ previous patch 15: removed as already applied in pinctrl tree > > v2: _ add Revievied-by, Acked-by in some patches > _ replace bool by u32 for start_err and opendrain fields of struct variant_data > _ split previous patch 3 in two parts, first patch clean the open drain bit code > and second part add pinctrl pins management when no open drain bit is available. > _ replace "pl180" by "PL180" in patch "mmc: mmci: Add STM32 variant" > > Andrea Merello (2): > ARM: dts: stm32: Add pin map for SDIO controller on stm32f4 > ARM: dts: stm32: Enable SDIO controller on stm32f469 disco board > > Patrice Chotard (12): > mmc: mmci: Don't pretend all variants to have MMCIMASK1 register > mmc: mmci: Don't pretend all variants to have MCI_STARBITERR flag > mmc: mmci: Don't pretend all variants to have OPENDRAIN bit > mmc: mmci: Add support for setting pad type via pinctrl > mmc: mmci: Add STM32 variant > ARM: dts: stm32: Add SDIO controller for stm32f746 > ARM: dts: stm32: Add SDIO controller for stm32f429 > ARM: dts: stm32: Enable SDIO controller on stm32429i-eval board > ARM: stm32: Add AMBA support for STM32F4 and STM32F7 SoCs > ARM: configs: stm32: Enable MMC_ARMMMCI support > ARM: configs: stm32: Enable EXT3_FS support > clk: stm32: Add clk entry for SDMMC2 on stm32F769 > > arch/arm/boot/dts/stm32429i-eval.dts | 19 +++++ > arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 31 +++++++++ > arch/arm/boot/dts/stm32f429.dtsi | 11 +++ > arch/arm/boot/dts/stm32f469-disco.dts | 19 +++++ > arch/arm/boot/dts/stm32f746.dtsi | 22 ++++++ > arch/arm/configs/stm32_defconfig | 3 + > arch/arm/mach-stm32/Kconfig | 3 + > drivers/clk/clk-stm32f4.c | 3 +- > drivers/mmc/host/mmci.c | 124 ++++++++++++++++++++++++++++----- > drivers/mmc/host/mmci.h | 6 ++ > 10 files changed, 224 insertions(+), 17 deletions(-) > > -- > 1.9.1 > Thanks, applied patch1 to patch5 for next! Kind regards Uffe