Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 18 Jan 2018 10:18:57 -0800
From:   Vadim Lomovtsev <Vadim.Lomovtsev@caviumnetworks.com>
To:     sgoutham@cavium.com, rric@kernel.org,
        linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>,
        Dean Nelson <dnelson@redhat.com>
Subject: Re: [PATCH v2] net: ethernet: cavium: Correct Cavium Thunderx
 nicvf/nicpf modules names
Message-ID: <20180118181857.GA4207@localhost.localdomain>
References: <1516290160-3396-1-git-send-email-Vadim.Lomovtsev@caviumnetworks.com>
 <1516290789-3585-1-git-send-email-Vadim.Lomovtsev@caviumnetworks.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1516290789-3585-1-git-send-email-Vadim.Lomovtsev@caviumnetworks.com>
User-Agent: Mutt/1.6.1 (2016-04-27)
Received-SPF: None (protection.outlook.com: cavium.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2018 18:19:01.4013 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 493cf1b3-2733-4eeb-bab9-08d55e9ff35c
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB2998
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Self NACK here: modules names has to contain dashes instead
of underscores, as it defined at sources (or update modules
DRV_NAME definitions whithin the source files with underscores).
Shame on me.

Vadim

On Thu, Jan 18, 2018 at 07:53:09AM -0800, Vadim Lomovtsev wrote:
> From: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
> 
> It was found that ethtool provides unexisting module name while
> it queries the specified network device for associated driver
> information.
> 
> This patch is to correct Cavium CN88xx Thunder nicvf/nicpf modules
> names 'nicvf' to 'thunder_nicvf' and 'nicpf' to 'thunder_nicpf'.
> 
> Signed-off-by: Dean Nelson <dnelson@redhat.com>
> Signed-off-by: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
> ---
>  drivers/net/ethernet/cavium/thunder/Makefile | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cavium/thunder/Makefile b/drivers/net/ethernet/cavium/thunder/Makefile
> index 6b4d4add7353..f5642337d0fe 100644
> --- a/drivers/net/ethernet/cavium/thunder/Makefile
> +++ b/drivers/net/ethernet/cavium/thunder/Makefile
> @@ -4,9 +4,9 @@
>  
>  obj-$(CONFIG_THUNDER_NIC_RGX) += thunder_xcv.o
>  obj-$(CONFIG_THUNDER_NIC_BGX) += thunder_bgx.o
> -obj-$(CONFIG_THUNDER_NIC_PF) += nicpf.o
> -obj-$(CONFIG_THUNDER_NIC_VF) += nicvf.o
> +obj-$(CONFIG_THUNDER_NIC_PF) += thunder_nicpf.o
> +obj-$(CONFIG_THUNDER_NIC_VF) += thunder_nicvf.o
>  
> -nicpf-y := nic_main.o
> -nicvf-y := nicvf_main.o nicvf_queues.o
> -nicvf-y += nicvf_ethtool.o
> +thunder_nicpf-y := nic_main.o
> +thunder_nicvf-y := nicvf_main.o nicvf_queues.o
> +thunder_nicvf-y += nicvf_ethtool.o
> -- 
> 2.14.3
>