Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Ryan Lee <RyanS.Lee@maximintegrated.com>
To:     Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.de>
CC:     "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "ryan.lee.maxim@gmail.com" <ryan.lee.maxim@gmail.com>,
        "perex@perex.cz" <perex@perex.cz>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ comments
 style
Thread-Topic: [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ comments
 style
Thread-Index: AQHTidAul7S9MzU4wUavSecUMKJo0qNs5CUAgAAB6QCAAAIpAIANTKDw
Date:   Thu, 18 Jan 2018 21:35:19 +0000
Message-ID: <BY2PR11MB08379E53A58E8C0853FB6708E7E80@BY2PR11MB0837.namprd11.prod.outlook.com>
References: <1515560521-10850-1-git-send-email-ryans.lee@maximintegrated.com>
 <20180110101506.GC9003@sirena.org.uk> <s5htvvuxbcr.wl-tiwai@suse.de>
 <20180110102940.GA13207@sirena.org.uk>
In-Reply-To: <20180110102940.GA13207@sirena.org.uk>
Accept-Language: en-US, ko-KR
Content-Language: en-US
received-spf: None (protection.outlook.com: maximintegrated.com does not
 designate permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0742833a-e682-4640-44b0-08d55ebb5fbd
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2018 21:35:19.9209
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: fbd909df-ea69-4788-a554-f24b7854ad03
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR11MB0839
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>-----Original Message-----
>From: Mark Brown [mailto:broonie@kernel.org]
>Sent: Wednesday, January 10, 2018 2:30 AM
>To: Takashi Iwai <tiwai@suse.de>
>Cc: Ryan Lee <RyanS.Lee@maximintegrated.com>; alsa-devel@alsa-project.org;
>lgirdwood@gmail.com; ryan.lee.maxim@gmail.com; perex@perex.cz; linux-
>kernel@vger.kernel.org
>Subject: Re: [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++
>comments style
>
>On Wed, Jan 10, 2018 at 11:21:56AM +0100, Takashi Iwai wrote:
>> Mark Brown wrote:
>> > On Tue, Jan 09, 2018 at 09:01:58PM -0800, Ryan Lee wrote:
>
>> > > @@ -1,4 +1,4 @@
>> > > -/* SPDX-License-Identifier: GPL-2.0 */
>> > > +// SPDX-License-Identifier: GPL-2.0
>> > >  /* Copyright (c) 2017, Maxim Integrated */
>
>> > Please change the entire header to C++, mixing C and C++ on adjacent
>> > lines looks ugly.
>
>> I'm not sure whether it's a good direction to go, either.
>
>> I rather wonder why SPDX line *must* be in C++ comment style...
>
>Apparently it's to remove any ambiguity for the tooling or something, plus=
 Linus
>decided he likes C++ comments.
>
>I don't understand why this isn't done as a macro like MODULE_LICENSE() an=
d
>so on but the decision was rushed through and not really publicised
>:9

Thank you for your feedback.
I modified two header lines in C++ comment style and send it again.