Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH-next] init/main.c: make local symbol static
To:     Randy Dunlap <rdunlap@infradead.org>,
        =?UTF-8?Q?Christopher_D=c3=adaz_Riveros?= <chrisadr@gentoo.org>,
        mingo@kernel.org, akpm@linux-foundation.org, tglx@linutronix.de,
        keescook@chromium.org, lauraa@codeaurora.org, rostedt@goodmis.org,
        mhocko@suse.com, tal.shorer@gmail.com, viresh.kumar@linaro.org,
        lokeshvutla@ti.com
Cc:     linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
References: <20180118220629.25116-1-chrisadr@gentoo.org>
 <9f473c55-7304-dda3-dea4-2734292927a6@infradead.org>
From:   Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <30828c91-a39d-6342-2774-32386baa30b6@amd.com>
Date:   Thu, 18 Jan 2018 16:31:17 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <9f473c55-7304-dda3-dea4-2734292927a6@infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2018 22:31:22.4101 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3013f90c-c8d3-4f47-3f73-08d55ec335ae
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1137
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/18/2018 4:09 PM, Randy Dunlap wrote:
> On 01/18/2018 02:06 PM, Christopher Díaz Riveros wrote:
>> Fixes the following sparse warning:
>>
>> init/main.c:167:12: warning:
>>   symbol 'envp_init' was not declared. Should it be static?
>>
>> Signed-off-by: Christopher Díaz Riveros <chrisadr@gentoo.org>
> 
> Does the kernel build OK after this change?
> 
> What about the other user(s) of envp_init?

It looks like it's referenced in init/do_mounts_initrd.c.  Rather
than making it static, it should be declared in .h file.

Thanks,
Tom

> 
> 
>> ---
>>  init/main.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/init/main.c b/init/main.c
>> index a8100b954839..ae86addb306c 100644
>> --- a/init/main.c
>> +++ b/init/main.c
>> @@ -164,7 +164,7 @@ static int __init set_reset_devices(char *str)
>>  __setup("reset_devices", set_reset_devices);
>>  
>>  static const char *argv_init[MAX_INIT_ARGS+2] = { "init", NULL, };
>> -const char *envp_init[MAX_INIT_ENVS+2] = { "HOME=/", "TERM=linux", NULL, };
>> +static const char *envp_init[MAX_INIT_ENVS+2] = { "HOME=/", "TERM=linux", NULL, };
>>  static const char *panic_later, *panic_param;
>>  
>>  extern const struct obs_kernel_param __setup_start[], __setup_end[];
>>
> 
>