Received: by 10.223.176.46 with SMTP id f43csp110642wra; Thu, 18 Jan 2018 14:41:00 -0800 (PST) X-Google-Smtp-Source: ACJfBosAiUfbBmKA3DHELbqwAZ/fTNFEKA9peIxOxvaoYajhG0lFLoA50wF7eHogl6KRGdvmdB0/ X-Received: by 10.98.152.149 with SMTP id d21mr37234668pfk.108.1516315260707; Thu, 18 Jan 2018 14:41:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516315260; cv=none; d=google.com; s=arc-20160816; b=oqSxOfEy2C2iuxZ14xgxNHTskN2eFcRIm/k6tACIG9noj28P/HHqIt3he9g5swO+mK XuahJdpQ86+pX8Oy+3dQCt72nAZm4S81Ll6OH8ZCVszsj8enUk/lhuOGPnQ2OWzUKGs2 HJsIPSz40mYYcLRj+LFdUlutKF8TWzDnN+cv6W7boG8XS4YkbG6Rrz4eg5gvO/zPIoZY nuV4OZp1NFSN/82iq4Xm0+9FR7nf00r27XA0iKfpzuKMObjfLlgmWPCoEUoJ02erPSxD zsdlMOFMSp33XDckX4Le9BK0hMMTQoGi0cHfXzdxsNznz/g0a+f/0cAqUOnmGfGlSiBe gUiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=4xtHEHKUzEruip2Ba7ojF08B6c5xgygEWDu3SjFKMNc=; b=KQ607QcTPM+gy7f7EBTZE/3/AAf20Urf9L2lkJoR7bEtoDSeyosm4cRWcIJmAJTIHw E6Enp1x0hSDQyj4VKh/lxp7IhCfJ7mEoPYrjYIVRYmU5ETORsQOEM8+IUYKD41kVaV9A 4IzEwtQ+oIxVAgUHlXiyiDqpJrjCpbLUoxltRkbT/SSWa40a4JdGFNinfGmIJA4o/1eU JFX4lbE4USLsbP5lz4x3x/cUNAaDYGdYnX68Bf2n0UKp/3EveNdpnrXb5lZSpScSybc4 hTkvlHJuezbxTVkZ2ls+dZHQKYoL7Wdkbn3+fpJE7aSeKiVnE2f0sVorsEXvWMSHd8VX QTYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g19-v6si266747plo.829.2018.01.18.14.40.45; Thu, 18 Jan 2018 14:41:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932587AbeARWjl (ORCPT + 99 others); Thu, 18 Jan 2018 17:39:41 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:53590 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932182AbeARWjh (ORCPT ); Thu, 18 Jan 2018 17:39:37 -0500 Received: from akpm3.svl.corp.google.com (unknown [104.133.9.92]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 31802EE4; Thu, 18 Jan 2018 22:39:37 +0000 (UTC) Date: Thu, 18 Jan 2018 14:39:35 -0800 From: Andrew Morton To: Joonsoo Kim Cc: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Namhyung Kim , Wengang Wang Subject: Re: [PATCH 00/18] introduce a new tool, valid access checker Message-Id: <20180118143935.6d782b3ecaba5186dea4eecd@linux-foundation.org> In-Reply-To: <20171222015114.GC1729@js1304-P5Q-DELUXE> References: <1511855333-3570-1-git-send-email-iamjoonsoo.kim@lge.com> <20171222015114.GC1729@js1304-P5Q-DELUXE> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Dec 2017 10:51:15 +0900 Joonsoo Kim wrote: > On Tue, Nov 28, 2017 at 04:48:35PM +0900, js1304@gmail.com wrote: > > From: Joonsoo Kim > > > > Hello, > > > > This patchset introduces a new tool, valid access checker. > > > > Vchecker is a dynamic memory error detector. It provides a new debug feature > > that can find out an un-intended access to valid area. Valid area here means > > the memory which is allocated and allowed to be accessed by memory owner and > > un-intended access means the read/write that is initiated by non-owner. > > Usual problem of this class is memory overwritten. > > > > Most of debug feature focused on finding out un-intended access to > > in-valid area, for example, out-of-bound access and use-after-free, and, > > there are many good tools for it. But, as far as I know, there is no good tool > > to find out un-intended access to valid area. This kind of problem is really > > hard to solve so this tool would be very useful. > > > > This tool doesn't automatically catch a problem. Manual runtime configuration > > to specify the target object is required. > > > > Note that there was a similar attempt for the debugging overwritten problem > > however it requires manual code modifying and recompile. > > > > http://lkml.kernel.org/r/<20171117223043.7277-1-wen.gang.wang@oracle.com> > > > > To get more information about vchecker, please see a documention at > > the last patch. > > > > Patchset can also be available at > > > > https://github.com/JoonsooKim/linux/tree/vchecker-master-v1.0-next-20171122 > > > > Enjoy it. > > > > Thanks. > > Hello, Andrew. > > Before the fixing some build failure on this patchset, I'd like to know > other reviewer's opinion on this patchset, especially, yours. :) > > There are some interests on this patchset from some developers. Wengang > come up with a very similar change and Andi said that this looks useful. > Do you think that this tool is useful and can be merged? > My main fear is that the feature will sit there and nobody will use it. Are there ways around that? For example, can we arrange with the test robot(s) to get vchecker operating on their setups in some automatable fashion and have them checking for bugs? Any other suggestions as to how we could get this feature to be used by others and producing useful results? And has vchecker actually found any real bugs in existing code? If so, a description of that would be illuminating.