Received: by 10.223.176.46 with SMTP id f43csp121864wra; Thu, 18 Jan 2018 14:50:41 -0800 (PST) X-Google-Smtp-Source: ACJfBovE6jnCBC7WcF3A+Sm6cx+s2BvOVn1gGIr2mDYIz7/tynJwOKrx+nh3Zel6iTDsL4rPeYco X-Received: by 2002:a17:902:581a:: with SMTP id m26-v6mr519434pli.158.1516315841699; Thu, 18 Jan 2018 14:50:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516315841; cv=none; d=google.com; s=arc-20160816; b=XDRAWCZ4G857DxUcyQTukJqcupSJ/ZCf+lQQGsbdojgY1zxAt2SdfWdaEMR0R5X3jc w/CfDIAUEUJTm68G38DUbdJXE9s5AFNL5fDTwGiBq/XVHxJLa+wFRX3ecFsHUxHsq0vW knx7AxRzoB2g5F8pyvGlh7lSa0qO04b7dnINZzAwaalpGkzasaX1C/19VobfsEo20xtl 6He6xiC+abdtXQQwIXhwzJDEgIc9muoOj3FXaXXwDD1+OQhpalsO9p+V6pwo57ZGafMn x3M4LR5I3IUhgQMb0n7y6SPj+nFKlLDZvhLI0YR3/3cQLsWe/SPlFLEL/ylOdf6xni71 LROQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date :arc-authentication-results; bh=2P4gj/69nPfjGLsWVrgKQYgnsgxpg9KaxA7TepUKxIQ=; b=am5FIF5lRvV/vW5h1lA8VSBIN1AdmlLMBPMJlZYQH5V8/pbS+pfRyBt1wOlkp5P9RG ky1uanbfMlECj2sRfQHQx7D/5BnxFm6ppV/jAptALLcwYnn/Hd3cMrGShTye0QhV/l54 IuKQkQhcnZwHPMvevKj/tjHJ85ZXsMhJONqX+WkvzEmWtzdjpU6SqO9b3ggw6RJs5Aly X+7h/2A6FKCiWgm1eu8cWfmdkrtIvOBJWxR01O7duzyaQt0j/Y5pZGr82nm2Nu95xCQv nEBtbILVLcroalWMvPaZy9j5E3GHU2bV0wfnqcT2ULNkIvpX5KXxV9aliIFZzBIYeds2 ymnQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c16si5093508pgu.706.2018.01.18.14.50.26; Thu, 18 Jan 2018 14:50:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932683AbeARWrw (ORCPT + 99 others); Thu, 18 Jan 2018 17:47:52 -0500 Received: from gateway34.websitewelcome.com ([192.185.150.114]:32919 "EHLO gateway34.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932493AbeARWrn (ORCPT ); Thu, 18 Jan 2018 17:47:43 -0500 X-Greylist: delayed 1307 seconds by postgrey-1.27 at vger.kernel.org; Thu, 18 Jan 2018 17:47:43 EST Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 41C703AFE3 for ; Thu, 18 Jan 2018 16:25:54 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id cId8edrUIODN4cId8ebLSJ; Thu, 18 Jan 2018 16:25:54 -0600 Received: from [189.155.104.111] (port=45678 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.89_1) (envelope-from ) id 1ecId7-000Zzz-Sf; Thu, 18 Jan 2018 16:25:53 -0600 Date: Thu, 18 Jan 2018 16:25:51 -0600 From: "Gustavo A. R. Silva" To: Felipe Balbi , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] usb: gadget: compress return logic into one line Message-ID: <20180118222551.GA18589@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.155.104.111 X-Source-L: No X-Exim-ID: 1ecId7-000Zzz-Sf X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.155.104.111]:45678 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 4 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Simplify return logic and avoid unnecessary variable assignment. Signed-off-by: Gustavo A. R. Silva --- drivers/usb/gadget/legacy/ncm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/legacy/ncm.c b/drivers/usb/gadget/legacy/ncm.c index fcee1ee0..8465f08 100644 --- a/drivers/usb/gadget/legacy/ncm.c +++ b/drivers/usb/gadget/legacy/ncm.c @@ -102,10 +102,8 @@ static int ncm_do_config(struct usb_configuration *c) } f_ncm = usb_get_function(f_ncm_inst); - if (IS_ERR(f_ncm)) { - status = PTR_ERR(f_ncm); - return status; - } + if (IS_ERR(f_ncm)) + return PTR_ERR(f_ncm); status = usb_add_function(c, f_ncm); if (status < 0) { -- 2.7.4