Received: by 10.223.176.46 with SMTP id f43csp217982wra; Thu, 18 Jan 2018 16:23:52 -0800 (PST) X-Google-Smtp-Source: ACJfBovlaSANscGx5Wvp6UBe3ntnybQIaL+CUMGvmZOd9qxnZiE+xvitInpy/QvzQpjy0ApHA46y X-Received: by 10.99.176.76 with SMTP id z12mr15440605pgo.405.1516321432284; Thu, 18 Jan 2018 16:23:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516321432; cv=none; d=google.com; s=arc-20160816; b=mMfjpILZpylnXqgJsz4RTrnWvDhnBsqtYk7zsrGMmLcXu4BIIHZGn8lIBI8qyp8j1M 7ARpDL8/hq9Cw0ZEe2IofmZxWNSnmimGpdYhyzconxj2BZyKLjV3HTH8Arx16+Gz7fTw /w40M0TxDaoghuicOZnmznK3pVCF9fA5w9mBsruXwTp0jL0eBi9YHnBCoBNYGZ8MA+P5 25x64NqODIPbOy11NvsJsgf4IJS9i+0j08MtOY0m4Xp8Px56GiHhoJjf1C1P7ZdRvQum VPamI23X1xHFZHDOMKhPaULOoC0aY6009LpnD9/zg1+gF4454iVPWOdxu9aWBoaiFd27 ErNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature:arc-authentication-results; bh=jURbgeTawy4pEitIxjOGsXZBrIGOITvRNhgnR15KCFw=; b=q/MEit0GqSGzxgalkh1UZZG0lKku8QUBZiv64Tucc4Tsucp56gLrmbm5ZkO1njJQEz 0wkyq7Ev+NI21Qv/jC32Msw1vXjgaz8ikYF4DGSIzNiyhI6OIfMKSADGINXV70zAlh9H YVrPrBvZE7ITyocemX54Fj3OhXMamN6k6IncUYEabpVpTX8K3EC4JNbCG+qFK9vhshno zoSbF1qD5ZNgoOif1n4bbVdoDxlqCB/nu5tB61+wluMxx1/pSZtUg7QOaNAad1cNoRmN 6gUFmxKktrZbmZg5dH/4kecjI9Zo3sat1507vYJ4+Y9NKDqF2DHRJpNTJq86lGlzPFU/ mdMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@networkplumber-org.20150623.gappssmtp.com header.s=20150623 header.b=c9E9sAWp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c14si8037746pfj.132.2018.01.18.16.23.38; Thu, 18 Jan 2018 16:23:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@networkplumber-org.20150623.gappssmtp.com header.s=20150623 header.b=c9E9sAWp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932645AbeASAXH (ORCPT + 99 others); Thu, 18 Jan 2018 19:23:07 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:37217 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753476AbeASAW6 (ORCPT ); Thu, 18 Jan 2018 19:22:58 -0500 Received: by mail-pg0-f67.google.com with SMTP id z17so24579pgc.4 for ; Thu, 18 Jan 2018 16:22:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jURbgeTawy4pEitIxjOGsXZBrIGOITvRNhgnR15KCFw=; b=c9E9sAWpMIPjjxc48gezdP4vdOQY9jDG+DQCkaSUEdZDTwE3cAZmHLUwyg4IoLBEes 3sDNtKTC3FmmC4KuLkFa3zUbChboE/0yApYuWTFEVkvMzuQMT+9zfpDUtwhcIcigoo6J zR82+gK9oQSaXNwRlO1eamkQAehb0B9Qie4PQFvefoL5iAkbjNu0l0Y9HNyNuuu/9M2Y I2DswIRCzvpKinjHy3qHOWitLKnzTPmpPP1U4XE13GWNv+WP+DpY2Q4X/KSZGZqywpAz 26L+w9X2DMshsIOl/C77D/feNoLcFl1Wvc3fq/Y9P/l1ok3GQDAqU6vZ3rglsVtm7PIu HyRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jURbgeTawy4pEitIxjOGsXZBrIGOITvRNhgnR15KCFw=; b=XEM51VzJiRsKLMBfN7uguyPqsYkLyNVe9kvHjmvyRWYAMjhIv9LqecnxWW7O/2hvOA 7DrCku7x+w+fQkKB7jxf09QPEC9Kp7bOIQQUIJn+EqfyvQENqpBHqiLISgQ2RaqVonIS +qgx0MPz85qHTgYo0xwaYxtbBJIZ+AptUZ0EVG0ltsHHSDL8QFbQAyO3FuUMbyNxi8Na m0PeMCsF1cwmk2alqCFJtYpAYcOLfsD8UMpTs5cimj7GK1iV3yOGVvOvdbkhfHpLsZkI 6sYx672DhIdFKIVfdVdxeSUfT6/geRqZqG+ppV0ImyGOAo6unTCfCfCi3xt0QaldFO3v M2gA== X-Gm-Message-State: AKwxyteVI4OzMgnQqZ1foswvliG3pe54uKOwqQyeLklTVJHKKTYGYfa8 nIy+qpZQjBbcrSTniM4I1sXwwH8tsHw= X-Received: by 10.98.222.198 with SMTP id h189mr30160125pfg.150.1516321378215; Thu, 18 Jan 2018 16:22:58 -0800 (PST) Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id f188sm15562599pfc.22.2018.01.18.16.22.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Jan 2018 16:22:57 -0800 (PST) Date: Thu, 18 Jan 2018 16:22:50 -0800 From: Stephen Hemminger To: "Gustavo A. R. Silva" Cc: "David S. Miller" , bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bridge: return boolean instead of integer in br_multicast_is_router Message-ID: <20180118162250.013954dd@xeon-e3> In-Reply-To: <20180118233745.GA23355@embeddedor.com> References: <20180118233745.GA23355@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Jan 2018 17:37:45 -0600 "Gustavo A. R. Silva" wrote: > Return statements in functions returning bool should use > true/false instead of 1/0. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva LGTM Fixes: 85b352693264 ("bridge: Fix build error when IGMP_SNOOPING is not enabled") Reviewed-by: Stephen Hemminger