Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC2DA20853
Date:   Thu, 18 Jan 2018 19:31:34 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Christopher =?UTF-8?B?RMOtYXo=?= Riveros <chrisadr@gentoo.org>
Cc:     Tom Lendacky <thomas.lendacky@amd.com>,
        Randy Dunlap <rdunlap@infradead.org>, mingo@kernel.org,
        akpm@linux-foundation.org, tglx@linutronix.de,
        keescook@chromium.org, lauraa@codeaurora.org, mhocko@suse.com,
        tal.shorer@gmail.com, viresh.kumar@linaro.org, lokeshvutla@ti.com,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH-next] init/main.c: make local symbol static
Message-ID: <20180118193134.59135fde@gandalf.local.home>
In-Reply-To: <1516318407.2510.76.camel@gentoo.org>
References: <20180118220629.25116-1-chrisadr@gentoo.org>
        <9f473c55-7304-dda3-dea4-2734292927a6@infradead.org>
        <30828c91-a39d-6342-2774-32386baa30b6@amd.com>
        <1516318407.2510.76.camel@gentoo.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 18 Jan 2018 18:33:27 -0500
Christopher Díaz Riveros <chrisadr@gentoo.org> wrote:

> > > What about the other user(s) of envp_init?  
> > 
> > It looks like it's referenced in init/do_mounts_initrd.c.  Rather
> > than making it static, it should be declared in .h file.
> >   
> 
> Ok, I'll try to figure it out, akpm accepted the patch in mm-next but
> was dropped because of testing failures. I'm still very new to all of
> this process.

Yeah, because do_mounts_initrd.c didn't compile. If you do add it to a
header, use a header local in the init directory. Do not expose
envp_init to the entire kernel.

-- Steve