Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1516323645.3417.5.camel@codethink.co.uk>
Subject: Re: [PATCH 4.4 045/115] sched/deadline: Throttle a constrained
 deadline task activated after the deadline
From:   Ben Hutchings <ben.hutchings@codethink.co.uk>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Cc:     stable@vger.kernel.org,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Juri Lelli <juri.lelli@arm.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Luca Abeni <luca.abeni@santannapisa.it>,
        Mike Galbraith <efault@gmx.de>,
        Romulo Silva de Oliveira <romulo.deoliveira@ufsc.br>,
        Steven Rostedt <rostedt@goodmis.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Tommaso Cucinotta <tommaso.cucinotta@sssup.it>,
        Ingo Molnar <mingo@kernel.org>,
        Sasha Levin <alexander.levin@verizon.com>
Date:   Fri, 19 Jan 2018 01:00:45 +0000
In-Reply-To: <20171218152855.351654393@linuxfoundation.org>
References: <20171218152851.886086917@linuxfoundation.org>
         <20171218152855.351654393@linuxfoundation.org>
Organization: Codethink Ltd.
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2017-12-18 at 16:48 +0100, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me
> know.
> 
> ------------------
> 
> From: Daniel Bristot de Oliveira <bristot@redhat.com>
> 
> 
> [ Upstream commit df8eac8cafce7d086be3bd5cf5a838fa37594dfb ]
[...]

I think this needs another fix on top:

commit ae83b56a56f8d9643dedbee86b457fa1c5d42f59
Author: Xunlei Pang <xlpang@redhat.com>
Date:   Wed May 10 21:03:37 2017 +0800

    sched/deadline: Zero out positive runtime after throttling constrained tasks

There's another fix related to this, but it doesn't appear to fix a
regression and I don't know how critical it is:

commit 3effcb4247e74a51f5d8b775a1ee4abf87cc089a
Author: Daniel Bristot de Oliveira <bristot@redhat.com>
Date:   Mon May 29 16:24:03 2017 +0200

    sched/deadline: Use the revised wakeup rule for suspending constrained dl tasks

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.