Received: by 10.223.176.46 with SMTP id f43csp276943wra; Thu, 18 Jan 2018 17:17:53 -0800 (PST) X-Google-Smtp-Source: ACJfBosZApnJ7t8X+feD+5NXSUsQnyPaLJE66rbPkqGcxoekeoQ5opfbRTo1LN1IwX30BQpqV5Ki X-Received: by 10.99.110.138 with SMTP id j132mr12010030pgc.313.1516324673837; Thu, 18 Jan 2018 17:17:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516324673; cv=none; d=google.com; s=arc-20160816; b=xYgNKyVvT15sZwxM/0R55BwnSJTXwoeh/wPUuA//++mgCfSHNJKt7d1AaDPDVUVL42 0yPn9q1dbgNSogGr7xZFWdpNps5Y+9ADx6a6aGRBv64cNJHGBv5d4fzpswYxq7JY6CUn 5NttlY5RA645Aalt8HfJk+4zqmL9utZKNlUIRDPm1N/ScwrSLbQWyQfEgYlVXQZ3Y8Pa fXeE9FWrCn1Fn5naRwvUZ4giARRJAHtULRwluOce/zzvTfkTOHYT7DCeRqvnEjJpGfqc WL4ixx8JnA2MBmqKXLOosHDLuN8y++P++tGcrtHLPvqY4VynUDf0CxbdKGpgnEotEaYu R4IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition:mime-version :user-agent:in-reply-to:references:subject:cc:to:from:message-id :date:arc-authentication-results; bh=aUgj+TEPFeE9ziqeV3O5Fi5m53AMeqTFN+CO4/oTmog=; b=lUkOH4t+hIE0Oep2L5SO8xRJt8YfsTXTnNpwhKaoFiA5FmBt+4FJT3HRC6L9gZeJup 25DcRbcUBbamE3Zs9t6EN40cBFkBNRpkgIH/bWUToy0FBU+FCEWRQnLTKP8tSA6DXTze EC7yaIFX984oyNXyLOezXYjbiiIbmD8ukaA3T2UvymGM0TvN4uIRCN+Y5+/YrkZ55EWW wsOA2ls6oFt9VWJvku+WbD3+B9rG64MOyPqRztDX86nKqFt2q+esPBLbFTJ1IJqsJD8h CLODPNMomcIwYucgI60SgM+WKlNvRZRtao7JysxSjZHT5VkI87w4Ap3d75TT066BDuyR n+bw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 126si8061567pfe.67.2018.01.18.17.17.37; Thu, 18 Jan 2018 17:17:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755283AbeASBQs (ORCPT + 99 others); Thu, 18 Jan 2018 20:16:48 -0500 Received: from gateway34.websitewelcome.com ([192.185.148.196]:15890 "EHLO gateway34.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754090AbeASBQm (ORCPT ); Thu, 18 Jan 2018 20:16:42 -0500 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 5C8F622A77D for ; Thu, 18 Jan 2018 18:55:20 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id cKxke4rGIuMnycKxkeomkg; Thu, 18 Jan 2018 18:55:20 -0600 Received: from gator4166.hostgator.com ([108.167.133.22]:22409) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89_1) (envelope-from ) id 1ecKxk-002qMA-2U; Thu, 18 Jan 2018 18:55:20 -0600 Received: from 189.155.104.111 ([189.155.104.111]) by gator4166.hostgator.com (Horde Framework) with HTTPS; Thu, 18 Jan 2018 18:55:18 -0600 Date: Thu, 18 Jan 2018 18:55:18 -0600 Message-ID: <20180118185518.Horde.Y7_-NYMNMPQFQWHhAcwsWQL@gator4166.hostgator.com> From: "Gustavo A. R. Silva" To: Stephen Hemminger Cc: "David S. Miller" , bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bridge: return boolean instead of integer in br_multicast_is_router References: <20180118233745.GA23355@embeddedor.com> <20180118162250.013954dd@xeon-e3> In-Reply-To: <20180118162250.013954dd@xeon-e3> User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 108.167.133.22 X-Source-L: Yes X-Exim-ID: 1ecKxk-002qMA-2U X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:22409 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 14 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Stephen Hemminger : > On Thu, 18 Jan 2018 17:37:45 -0600 > "Gustavo A. R. Silva" wrote: > >> Return statements in functions returning bool should use >> true/false instead of 1/0. >> >> This issue was detected with the help of Coccinelle. >> >> Signed-off-by: Gustavo A. R. Silva > > LGTM > > Fixes: 85b352693264 ("bridge: Fix build error when IGMP_SNOOPING is > not enabled") > Reviewed-by: Stephen Hemminger Thanks Stephen. -- Gustavo