Received: by 10.223.176.46 with SMTP id f43csp860198wra; Fri, 19 Jan 2018 03:11:54 -0800 (PST) X-Google-Smtp-Source: ACJfBot2+eNAUXlnxIVxSZeOSy2ej5/uH3+eTEllaIBuLR7O7K73QvEPJhp8TkHBkxtJVmzec6XU X-Received: by 10.99.63.14 with SMTP id m14mr39993773pga.358.1516360314098; Fri, 19 Jan 2018 03:11:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516360314; cv=none; d=google.com; s=arc-20160816; b=QU1cc1Qaxu3+L6bc2dsnOiOcqP9quQLnUaDtU9bqdFrBNM2KRPc9tNWQAUIRCnEiFV e+5MnHKXif5ZhA0bnSop2x6drnuxlpJwAG7BKvMkrziPGWC782i71lyPkAaY3HPSz35K eyS06ZhwkAZDl4N5ivZ7dmgY9/V16UcLHhNXvlfqV3fUaKbk1E6NvZGIio9bHnKL1VSr 7P7zvrAOkkTQnT0kvcRAVLbxwQ+l9/DiDBYgM561w0lUt7KaCIvl48LrRn9/0rtyeDk0 xxx8EEQEeT5w8gDhEPRmJWwV+COVH4w5GaJJ3OhV9R+5ZRpojS6Ts3TJVGYZS3rsgta5 UBjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=BQ9xOmpdx+7MmhmvbBgaPrXlqHbjNItDnJ/z45n11ew=; b=ADYdmyYKsHD2VCF5sXaF6fyG34Eu/SoUwlLfOqEH3uEm+lqe6gWfMDrkNJrZsJTcyv BlafhOpEjGdmcXcbI73/FDoPvXt3Mmj0vJ+pLKi9NUhkgfHiXoCuyaX+EMfArpExF2EA rojwlgGXos6ol5H+cUla9kraLqlKumVvgRDvtkE5JlgeTCUzN2OVpj0brpONJH+Jv3pg rc3SMkkKBdL06Fk8510U+ob+lkyK5QXrY7nWb1H5Ykq4DHDhJpnxXZNieQI0rLGLrzRj 2n5Kg4sdk61ixCYOpVdvp6cC4dRtfreBAtjbpl7UeQ7FYaVm+1ApY9/O34u7isObgMGC 1Lfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=L98P/CS+; dkim=pass header.i=@codeaurora.org header.s=default header.b=TnKcH3q/; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x8-v6si747801plo.616.2018.01.19.03.11.40; Fri, 19 Jan 2018 03:11:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=L98P/CS+; dkim=pass header.i=@codeaurora.org header.s=default header.b=TnKcH3q/; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755550AbeASLK5 (ORCPT + 99 others); Fri, 19 Jan 2018 06:10:57 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:60544 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751212AbeASLK3 (ORCPT ); Fri, 19 Jan 2018 06:10:29 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 40CE760A5F; Fri, 19 Jan 2018 11:10:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1516360229; bh=AsvJ+SOFQRslN6hmcHEEPHLzEs1VFTOYfij4cYW9OVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L98P/CS+BCPFJVZ3Vwr7wQRiMBzEMkNuiM2fVglwGD0vfPjdwCPRKNgSfDibv2bFQ AW1A+IBk4GfqdUUtO09JNlRUkJyzoOPhbIOoqthvwZZuec+0ZFjHZCsu+CUvHmGNDP 4raSgZRR+0ceiUE96ymNXcL58KSurThPMfh35Rw4= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from blr-ubuntu-poza.qualcomm.com (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: poza@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id D9D8E60452; Fri, 19 Jan 2018 11:10:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1516360228; bh=AsvJ+SOFQRslN6hmcHEEPHLzEs1VFTOYfij4cYW9OVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TnKcH3q/4r8z9LW38v1Yqu+YBHrQpJxJyawAsAkDhdOzCkqu84GqSPShIG1ukpgHl P6qnCnwbpx1VU65iWGSIdUHrIz0Hcr++JscGT3P80+NwwPq8wqo01aoJpqCXwsTMZq oJLMBIu5z3W58nFeaJIEpXAFByCwKNZnnXSEf/Gg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D9D8E60452 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=poza@codeaurora.org From: Oza Pawandeep To: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Sinan Kaya , Timur Tabi Cc: Oza Pawandeep Subject: [PATCH v6 3/7] PCI/ERR: add mutex to synchronize recovery Date: Fri, 19 Jan 2018 16:40:00 +0530 Message-Id: <1516360204-1586-4-git-send-email-poza@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1516360204-1586-1-git-send-email-poza@codeaurora.org> References: <1516360204-1586-1-git-send-email-poza@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch protects pci_do_recovery with mutex. Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/pcie-err.c b/drivers/pci/pcie/pcie-err.c index a532fe0..8318c84 100644 --- a/drivers/pci/pcie/pcie-err.c +++ b/drivers/pci/pcie/pcie-err.c @@ -20,6 +20,8 @@ #include #include "portdrv.h" +static DEFINE_MUTEX(pci_err_recovery_lock); + struct aer_broadcast_data { enum pci_channel_state state; enum pci_ers_result result; @@ -283,6 +285,8 @@ void pci_do_recovery(struct pci_dev *dev, int severity) pci_ers_result_t status, result = PCI_ERS_RESULT_RECOVERED; enum pci_channel_state state; + mutex_lock(&pci_err_recovery_lock); + if (severity == AER_FATAL) state = pci_channel_io_frozen; else @@ -326,9 +330,11 @@ void pci_do_recovery(struct pci_dev *dev, int severity) report_resume); dev_info(&dev->dev, "Device recovery successful\n"); + mutex_unlock(&pci_err_recovery_lock); return; failed: /* TODO: Should kernel panic here? */ dev_info(&dev->dev, "Device recovery failed\n"); + mutex_unlock(&pci_err_recovery_lock); } -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc., a Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.