Received: by 10.223.176.46 with SMTP id f43csp908540wra; Fri, 19 Jan 2018 04:04:05 -0800 (PST) X-Google-Smtp-Source: ACJfBotaSIzBOn6LShkvOZVQJ7Qs4bzR+av2TxRBsRRd1Qzrujv6xSDCDegIeQ1NwDuf8iOWRg2L X-Received: by 10.98.34.27 with SMTP id i27mr12753684pfi.43.1516363444992; Fri, 19 Jan 2018 04:04:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516363444; cv=none; d=google.com; s=arc-20160816; b=rCk85c+ZvUDrHzTlkesp1xVN+wFVM6wfBou4KWlLM8SMzBOzH+IuIwfVdjQX9QI8QS qXfkCI0eVl5snSVlg3PvgX1KFTeFTREmqUzRKksp4byn0CBOyXeN58sMkUZiGvcyyjnq 8p/sqm+N9wi48V52cT5nqhkFMixWOeqObxWTG7hvNvDCgeWsQgCTLXmZTQpSCYEz/IyY C1+MUH1zK6kGJZhTiaofS7nrxO71EX0AUPEzz/I+NvVVz/tamtz/GASvU9sdCxoXUKOP P3WW3SQVgsVTVsBLvRG5ThIOY79URqqQP3o3CuiKgvY/kYW6vsiZt3ugg2SXAzwGa6F6 CCHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=R2CldVwB9Ke5osmnIzacL//+ytWHvaMV7aTlIFUCCVg=; b=j1PRNuvJI0Jcs6MaVQK5xWccYMTCUlxMwLUV5pXIrVN50ySQe6j+6XkkCBStToCXc1 Uzw1Yjo4G7sIpzoFG73V1ivEC1wFQSJDmAfuvSPafR2/j0sVGXqMx/gkZwEZmnVckFLD +dJW9iL2n+Ho13lMoZKVC55Q4c2DvkwXHFE9mkbCD2Q3JPqr4Pp08h23qE87CYJ0qQwJ 4963EyoVIRULC9W2XeJS2QxJ2UGFzhw/2srRiAMoyCfvuuD0IT3+o0gBhj2nO7y5XTHj JpdbSfxixHQZXEAS4YAAzEwu+QChBEQ0p1CN5forRP0+cNtmQNlGriYTVAIAP2xrfI6h XZaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b7si8216467pgr.640.2018.01.19.04.03.40; Fri, 19 Jan 2018 04:04:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754440AbeASMBu (ORCPT + 99 others); Fri, 19 Jan 2018 07:01:50 -0500 Received: from mail.skyhub.de ([5.9.137.197]:52202 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751200AbeASMBs (ORCPT ); Fri, 19 Jan 2018 07:01:48 -0500 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 3uxMlQ_CJcLe; Fri, 19 Jan 2018 13:01:47 +0100 (CET) Received: from pd.tnic (p200300EC2BD01400747F3329D7103F5F.dip0.t-ipconnect.de [IPv6:2003:ec:2bd0:1400:747f:3329:d710:3f5f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id C9DAC1EC02F2; Fri, 19 Jan 2018 13:01:46 +0100 (CET) Date: Fri, 19 Jan 2018 13:01:40 +0100 From: Borislav Petkov To: "Luck, Tony" , Jia Zhang Cc: "hmh@hmh.eng.br" , "mingo@redhat.com" , "hpa@zytor.com" , "tglx@linutronix.de" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3] x86/microcode/intel: Extend BDW late-loading with LLC size check Message-ID: <20180119120140.7l4dnosytqxh4cuj@pd.tnic> References: <1516321542-31161-1-git-send-email-zhang.jia@linux.alibaba.com> <3908561D78D1C84285E8C5FCA982C28F7B346404@ORSMSX110.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F7B346404@ORSMSX110.amr.corp.intel.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 19, 2018 at 01:03:09AM +0000, Luck, Tony wrote: > if (c->x86 == 6 && > c->x86_model == INTEL_FAM6_BROADWELL_X && > c->x86_mask == 0x01 && > + llc_size_per_core > 2621440 && > c->microcode < 0x0b000021) { > pr_err_once("Erratum BDF90: late loading with revision < 0x0b000021 (0x%x) disabled.\n", c->microcode); > pr_err_once("Please consider either early loading through initrd/built-in or a potential BIOS update.\n"); > > This version looks good to me. > > Acked-by: Tony Luck Applied, thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.