Received: by 10.223.176.46 with SMTP id f43csp969859wra; Fri, 19 Jan 2018 05:03:39 -0800 (PST) X-Google-Smtp-Source: ACJfBosyEr3PuQZe4tM+pv8MTx++jMS6t2LxmdvItx16aA4Xj79BvWLB4/Stogcnq2ozio9rFOBj X-Received: by 10.99.127.85 with SMTP id p21mr39043372pgn.137.1516367018940; Fri, 19 Jan 2018 05:03:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516367018; cv=none; d=google.com; s=arc-20160816; b=hpV9xIv3v6JXxOE1F3yQ9xjLCGypMVPmiTb5zIekA0nt2rUd+AOGhU5SzhKa2ZGCb+ IWFoT2Lrw+DPQKsgIhRT3jKC0Pw33n8uP5PQmGFgzzLs38x7a9qAXW/6t5GbcEwtwaqI kKr9CB1Wb09m6zD3jLBw42tSdwsJCBtY88lJSrl0JAz1idP8Yfk/kTNned3tMigYMlEl oaeaoSgi+g0mJpczoqjkAOc6CZPQLyGCa6mfsW7jna0s8IdgPuwzYW8MLwNNOJoSK3wS qjmK0L1aoa1UwdGcVn1HdOpyyZv9Zfa5cN+i7Ho4O0WVPbgxZtiMT7g3kWe7lPYJR/+8 OF2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=QL84yDFgVVCdWXKt5BSSWORAAkIwxvZWfFvRwCrz6FI=; b=Nu+fp1qcv1CbqEIYrb8RF087okb9sucPTYYwOE7Ron7z0A6xZmgKX//Xfct66lWtXn o9utiGxRCp8c+MaprgB/ebOMxokR8Tpm125/5cU7Y4jbWxUwIClBeytFJcCls1eyRCxk M348Zu0Q/bEx1219ohAhHR9FQJ/TdvBv/XsDh0uZLmfSTgn/ylCkXbtEEhNL5M/OVAQi CJrfBtIIjq7SdAso/vRJQlxD+O3I5rth9UWRZnvY5I44gxDqP/FqXXDcT3bWQ8LbJzSY S3mCJmgXuLuUS+cpV8f9QMUzs/p2iDYKlelY6yFHI0xLkigIHbvnqpISb+96/ERtYA6F wIZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 64-v6si636992plb.607.2018.01.19.05.03.24; Fri, 19 Jan 2018 05:03:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754855AbeASNCT (ORCPT + 99 others); Fri, 19 Jan 2018 08:02:19 -0500 Received: from mail.us.es ([193.147.175.20]:46894 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751200AbeASNCN (ORCPT ); Fri, 19 Jan 2018 08:02:13 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 4F62720A52C for ; Fri, 19 Jan 2018 14:02:11 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 3FDAFBAC40 for ; Fri, 19 Jan 2018 14:02:11 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 3E844BAC3B; Fri, 19 Jan 2018 14:02:11 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.0 required=7.5 tests=ALL_TRUSTED,BAYES_50, HEADER_FROM_DIFFERENT_DOMAINS,SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 3B06BDA2DD; Fri, 19 Jan 2018 14:02:09 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Fri, 19 Jan 2018 14:02:09 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (129.166.216.87.static.jazztel.es [87.216.166.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id E1AE14265A2F; Fri, 19 Jan 2018 14:02:08 +0100 (CET) Date: Fri, 19 Jan 2018 14:02:08 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: "Gustavo A. R. Silva" Cc: Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: return booleans instead of integers Message-ID: <20180119130208.ewf7fmw4qddr6isc@salvia> References: <20180118232512.GA22242@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180118232512.GA22242@embeddedor.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 18, 2018 at 05:25:12PM -0600, Gustavo A. R. Silva wrote: > Return statements in functions returning bool should use > true/false instead of 1/0. > > These issues were detected with the help of Coccinelle. Applied, thanks.