Received: by 10.223.176.46 with SMTP id f43csp984287wra; Fri, 19 Jan 2018 05:15:53 -0800 (PST) X-Google-Smtp-Source: ACJfBovXlwIrZDKH7d1I8kp6eOQwo9UczdBJAPafjEdXdhXdJey/VKV6o19Wy5qgqbz10G5PYYfI X-Received: by 10.99.158.10 with SMTP id s10mr1798282pgd.141.1516367753151; Fri, 19 Jan 2018 05:15:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516367753; cv=none; d=google.com; s=arc-20160816; b=FvGdptFTupguHx++3WkUnqd6MeqzL1nFwhckP1b02RjtclgOZS51yg9dT9a16UBYgN ObiZ7/OvDoOisaAX6g2M51SzsfDJQ2ADrFbIVPQfnSE8RhhwqF+x2B+JvzM6YM6QbRAD c3ZHt2cwjOh+xpRCKMxbnoq8F/tnn9N1IgtRY8rkVekXID6F2GnfotRv+R9LOt6onpjR yKqV24PtqNRTHaV9Td4P58ArOru2oVoqvl8mCQG616bw65YHcMi9xHpHaVYP34PzFcHr CFT/KcCcWPXD0yyDBnMgi7DW3Ai4YNMgEGmSf2josVNq8MwF+T28WxZ/RthalEqvBwCh ISYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=ZSwSXf39Hv2mqCe/tJo6aDXrCiDjBsC0oH7iDJdBD+0=; b=YWmlYbko3ha6EaWZ5I09JS68zWCG33cx0qVFgcToJlOzH4AwTntWQA+D84hu/NhH+A 3CzEAbb7O5voBQpoNEyqc2DPyCT7msg2yaAdYPZk76omZLBaZiqn3YmMedECfAvHigw/ 6ihoGFJZdvT9g+31kBWBWigJCji7CEhaUOUG6/o+pSHgPLNuwdfGSimLuqPPf9S/BLuR ofV+eyptoxSHfKTWotdZMltctBLVJvyQK4F+rXtorOJ6BaokHqAxM20zh70abrB1ZXN+ trSIULevmBh52t4Mkn1EZ6WD99A+U1lHf7oilMCnBCHI6YwQEfYyr1MsNcfbh4YXGRCk xgqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e3-v6si825672pld.142.2018.01.19.05.15.39; Fri, 19 Jan 2018 05:15:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755524AbeASNOI (ORCPT + 99 others); Fri, 19 Jan 2018 08:14:08 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:44732 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754719AbeASNOD (ORCPT ); Fri, 19 Jan 2018 08:14:03 -0500 Received: from localhost (unknown [109.190.253.13]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 7A6AFE64; Fri, 19 Jan 2018 13:14:01 +0000 (UTC) Date: Fri, 19 Jan 2018 14:13:55 +0100 From: Greg Kroah-Hartman To: Daniel Bristot de Oliveira Cc: Ben Hutchings , linux-kernel@vger.kernel.org, stable@vger.kernel.org, "Peter Zijlstra (Intel)" , Juri Lelli , Linus Torvalds , Luca Abeni , Mike Galbraith , Romulo Silva de Oliveira , Steven Rostedt , Thomas Gleixner , Tommaso Cucinotta , Ingo Molnar , Sasha Levin Subject: Re: [PATCH 4.4 045/115] sched/deadline: Throttle a constrained deadline task activated after the deadline Message-ID: <20180119131355.GA1866@kroah.com> References: <20171218152851.886086917@linuxfoundation.org> <20171218152855.351654393@linuxfoundation.org> <1516323645.3417.5.camel@codethink.co.uk> <20180119075304.GE25687@kroah.com> <20180119124003.GA18519@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180119124003.GA18519@kroah.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 19, 2018 at 01:40:03PM +0100, Greg Kroah-Hartman wrote: > On Fri, Jan 19, 2018 at 01:16:01PM +0100, Daniel Bristot de Oliveira wrote: > > On 01/19/2018 08:53 AM, Greg Kroah-Hartman wrote: > > > On Fri, Jan 19, 2018 at 01:00:45AM +0000, Ben Hutchings wrote: > > >> On Mon, 2017-12-18 at 16:48 +0100, Greg Kroah-Hartman wrote: > > >>> 4.4-stable review patch.??If anyone has any objections, please let me > > >>> know. > > >>> > > >>> ------------------ > > >>> > > >>> From: Daniel Bristot de Oliveira > > >>> > > >>> > > >>> [ Upstream commit df8eac8cafce7d086be3bd5cf5a838fa37594dfb ] > > >> [...] > > >> > > >> I think this needs another fix on top: > > >> > > >> commit ae83b56a56f8d9643dedbee86b457fa1c5d42f59 > > >> Author: Xunlei Pang > > >> Date:???Wed May 10 21:03:37 2017 +0800 > > >> > > >> ????sched/deadline: Zero out positive runtime after throttling constrained tasks > > > > > > Now queued up, thanks. > > > > > >> There's another fix related to this, but it doesn't appear to?fix a > > >> regression and I don't know how critical it is: > > >> > > >> commit 3effcb4247e74a51f5d8b775a1ee4abf87cc089a > > >> Author: Daniel Bristot de Oliveira > > >> Date:???Mon May 29 16:24:03 2017 +0200 > > >> > > >> ????sched/deadline: Use the revised wakeup rule for suspending constrained dl tasks > > > > > > I'll hold off on this one until someone actually asks for it, as it's a > > > big change. > > > > > > thanks again for the review, > > > > Hi, > > > > This fix is also needed. Do you guys need some help in the backport? if > > so, please let me know! I will be glad to help. > > I've now backported it, was just some comment and formatting issues that > needed to be adjusted. Nope, my attempt broke the build :( If you could provide a working backport, that would be great. thanks, greg k-h