Received: by 10.223.176.46 with SMTP id f43csp1079873wra; Fri, 19 Jan 2018 06:39:07 -0800 (PST) X-Google-Smtp-Source: ACJfBour8WDFloQI8g8qeuCBCDTSNSduzV1FxV0FMVxAttK6Zx/HNSTuTNvaTGTjlfyBouT4apye X-Received: by 2002:a17:902:4203:: with SMTP id g3-v6mr1647676pld.81.1516372747476; Fri, 19 Jan 2018 06:39:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516372747; cv=none; d=google.com; s=arc-20160816; b=o8qVVgRL8t7c1VH5unwojmdJn6x7hLOIprTyYfPothpg1myzncxQRXWgJa5hgADdD9 gLkw9xTeBmnf0SZvMvIELD3qOHwGf1E3vZjYXV+zlUOzHBf1PgTAY49LTHq+RTpnc040 W6GmDp+KA3XDt2ZIlzEKoPESzOo6G1kHSqy9afBPW3PdQy72c4DRcHEVDIDfJE7ZYtLE bpaKw+PYk5QXm1/3snY97ZZ6h/fkIEtBDncbzg1NVgO5GTCHNLPcwxp6A7jqMcdpes3Y j3Xp1lRCPBauzWhYg9h7sBuHEhv2PY62MBtihD8R89njQ4v43BuNllgZfuPuyMYDXsnZ DP3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=wLEGnKHlzODLsnCvz05sduozN20eaBjG9k432qGX7AE=; b=BKK86ADUTJfcEfHFUrEeswYFXqu/LFAmv+4stUkmoeqMYLIzjVjcXJPXoDXTDHTO24 d3G4VXh5K7xie6VhnGDcXDpQKy0GDgTNBZVDbX4Iyc0FqgolFxVjjqGpq5feMEl4ndWe FmwcIQvqUcuInEnShALUxa/GUwr6h/JzdQmDXyRx2ZMF9xwt+2KvSlAk1IyFbilG0TJw zYOj0DFjTMP8/rcLDMd8DwmObN7RogtcZC7gHA0xQCDxYknGhVl27HxK39J5Y2Mj7Nq/ lmawiehJ6vEHBY313WhdV4l+2a2kcKOcZzwadMdjcGRumL1UtrE99F2riFngnSE+3y+z v+cA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=Ovg1D1vT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f17si7990809pgv.487.2018.01.19.06.38.52; Fri, 19 Jan 2018 06:39:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=Ovg1D1vT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755952AbeASOhf (ORCPT + 99 others); Fri, 19 Jan 2018 09:37:35 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:35784 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755245AbeASOh2 (ORCPT ); Fri, 19 Jan 2018 09:37:28 -0500 Received: by mail-wm0-f45.google.com with SMTP id r78so4004385wme.0 for ; Fri, 19 Jan 2018 06:37:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wLEGnKHlzODLsnCvz05sduozN20eaBjG9k432qGX7AE=; b=Ovg1D1vTgD3Xpaq+rZBnue8GKCbUGQLVa9UzrBpvotrN9KOMMYS/GNcFlC+z6sUFx6 rpwwC8I1XCbrKWDhOZxyy4Empp41jbwNSc5HusrrkX3dBAQMvEO7UakarFOI3DauWznt QdMGTaIVisiTAXHYvT5qPo9xHpc9ODmyD/jfMnNS04nOsTj6wCzBvhHBImXoSKsxongm QTBMDoN+eTLLf7yw1jtyjikCv5oQyW4OhQ0HznUTx/ElvHD/mVr4IWFsHDC+5T4Sm//a 7CH8Yz1n7gxD8D9XNBrbaE4z1UJ2Ym1dJw8Xq8i8jKNgZFVPCUxMD88uW55/Heuv4wrO 4T/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wLEGnKHlzODLsnCvz05sduozN20eaBjG9k432qGX7AE=; b=I9tfh0BHkXHNr66wogWF0q2G9KMg23AYcLnFcozPfHIZbB2/qnxP3a2+Szk0ciBdpb ShdgBBOVTae4kJN66QUdMwCbzrKZe1OTA4CNu6c6EHtG7BwyyiCvDT3aK39HVSBbRA+M eY2eMMUKYgZU/gTUX16gEl65ho/9r8FSaueayVyE4XMpcpGuEZnvGjyOI91l7sTcmMIE vAB7Xo1YAd7kaxgbdQimNJ68Q4T7ThcqjzqL0oQh56PiMTOtGey6WmtlkEMWVQxX8hrh gmZDt9OoR8hWT7BCksRuHEBBlIc/yz/ZwuSsFKD2EFhl9nb6e2p8+FSqdEYr/Qk+uYx1 +dpQ== X-Gm-Message-State: AKwxytfx1kaOyxbxC5GTnGq3nzmNi7sH60pRngGnberYhSf5gghvGsxh MNfwOznDb7JgDklyUaY4gIYBQQ== X-Received: by 10.28.84.87 with SMTP id p23mr8075864wmi.92.1516372647286; Fri, 19 Jan 2018 06:37:27 -0800 (PST) Received: from [172.20.1.75] (host-79-78-33-110.static.as9105.net. [79.78.33.110]) by smtp.gmail.com with ESMTPSA id a139sm1499415wme.1.2018.01.19.06.37.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Jan 2018 06:37:26 -0800 (PST) Subject: Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs To: Roman Gushchin Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Jakub Kicinski , Daniel Borkmann , Alexei Starovoitov References: <20180115191615.13911-1-guro@fb.com> <34c43a17-7832-413e-fea8-4ad0f80f1585@netronome.com> <20180119141739.GA22398@castle.DHCP.thefacebook.com> From: Quentin Monnet Message-ID: <29c01fd7-8f1e-91bf-0be6-a2b220e0e637@netronome.com> Date: Fri, 19 Jan 2018 14:37:25 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180119141739.GA22398@castle.DHCP.thefacebook.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2018-01-19 14:17 UTC+0000 ~ Roman Gushchin > On Mon, Jan 15, 2018 at 07:32:01PM +0000, Quentin Monnet wrote: [...] >> Looks good, thanks Roman! >> Would you mind updating the map names as well? It seems the >> BPF_MAP_TYPE_CPUMAP is missing from the list in map.c. > > Hello, Quentin! > > > Here is the patch. > > > Thanks! > > -- > > From 16245383a894038a63cc1ad4b77629ba704aaa38 Mon Sep 17 00:00:00 2001 > From: Roman Gushchin > Date: Fri, 19 Jan 2018 14:07:38 +0000 > Subject: [PATCH bpf-next] bpftool: recognize BPF_MAP_TYPE_CPUMAP maps > > Add BPF_MAP_TYPE_CPUMAP map type to the list > of map type recognized by bpftool and define > corresponding text representation. > > Signed-off-by: Roman Gushchin > Cc: Quentin Monnet > Cc: Jakub Kicinski > Cc: Daniel Borkmann > Cc: Alexei Starovoitov > --- > tools/bpf/bpftool/map.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c > index a152c1a5c94c..f95fa67bb498 100644 > --- a/tools/bpf/bpftool/map.c > +++ b/tools/bpf/bpftool/map.c > @@ -66,6 +66,7 @@ static const char * const map_type_name[] = { > [BPF_MAP_TYPE_HASH_OF_MAPS] = "hash_of_maps", > [BPF_MAP_TYPE_DEVMAP] = "devmap", > [BPF_MAP_TYPE_SOCKMAP] = "sockmap", > + [BPF_MAP_TYPE_CPUMAP] = "cpumap", > }; > > static unsigned int get_possible_cpus(void) > Good, thank you! Acked-by: Quentin Monnet