Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <CAEbi=3ef8JHf_Jpru1B2L3+Xz-Oz4p_t84Lh=5kuTFo0YEz=5A@mail.gmail.com>
References: <cover.1515766253.git.green.hu@gmail.com> <e9577ec0f6b6ca17077aa2f576c8bef191c3d7c2.1515766253.git.green.hu@gmail.com>
 <CAK8P3a0HGhx3WpF-AwC+7m8+FoaiQBTYoCLqhECrATBRLX7x5g@mail.gmail.com> <CAEbi=3ef8JHf_Jpru1B2L3+Xz-Oz4p_t84Lh=5kuTFo0YEz=5A@mail.gmail.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Fri, 19 Jan 2018 15:52:40 +0100
Message-ID: <CAK8P3a38hCHULZt=fGXJebcoiEGCwA0fre_kixA7sUpPP2xf5g@mail.gmail.com>
Subject: Re: [PATCH v6 31/36] dt-bindings: nds32 CPU Bindings
To:     Greentime Hu <green.hu@gmail.com>
Cc:     Greentime <greentime@andestech.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arch <linux-arch@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Rob Herring <robh+dt@kernel.org>,
        Networking <netdev@vger.kernel.org>,
        Vincent Chen <deanbo422@gmail.com>,
        DTML <devicetree@vger.kernel.org>,
        Al Viro <viro@zeniv.linux.org.uk>,
        David Howells <dhowells@redhat.com>,
        Will Deacon <will.deacon@arm.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        linux-serial@vger.kernel.org,
        Geert Uytterhoeven <geert.uytterhoeven@gmail.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Mark Rutland <mark.rutland@arm.com>, Greg KH <greg@kroah.com>,
        Guo Ren <ren_guo@c-sky.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        David Miller <davem@davemloft.net>,
        Jonas Bonn <jonas@southpole.se>,
        Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
        Stafford Horne <shorne@gmail.com>,
        Vincent Chen <vincentc@andestech.com>,
        Rick Chen <rick@andestech.com>, Zong Li <zong@andestech.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jan 19, 2018 at 3:32 PM, Greentime Hu <green.hu@gmail.com> wrote:
> 2018-01-18 19:02 GMT+08:00 Arnd Bergmann <arnd@arndb.de>:
>> On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu <green.hu@gmail.com> wrote:
>>> From: Greentime Hu <greentime@andestech.com>
>>>
>>> This patch adds nds32 CPU binding documents.
>>>
>>> Signed-off-by: Vincent Chen <vincentc@andestech.com>
>>> Signed-off-by: Rick Chen <rick@andestech.com>
>>> Signed-off-by: Zong Li <zong@andestech.com>
>>> Signed-off-by: Greentime Hu <greentime@andestech.com>
>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>> ---
>>>  Documentation/devicetree/bindings/nds32/cpus.txt |   37 ++++++++++++++++++++++
>>>  1 file changed, 37 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/nds32/cpus.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/nds32/cpus.txt b/Documentation/devicetree/bindings/nds32/cpus.txt
>>> new file mode 100644
>>> index 0000000..9a52937
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/nds32/cpus.txt
>>> @@ -0,0 +1,37 @@
>>> +* Andestech Processor Binding
>>> +
>>> +This binding specifies what properties must be available in the device tree
>>> +representation of a Andestech Processor Core, which is the root node in the
>>> +tree.
>>> +
>>> +Required properties:
>>> +
>>> +       - compatible:
>>> +               Usage: required
>>> +               Value type: <string>
>>> +               Definition: should be one of:
>>> +                       "andestech,n13"
>>> +                       "andestech,n15"
>>> +                       "andestech,d15"
>>> +                       "andestech,n10"
>>> +                       "andestech,d10"
>>> +                       "andestech,nds32v3"
>>
>> Based on https://lkml.org/lkml/2017/11/27/1290, this should say that
>> the device tree should always list 'andestech,nds32v3' as the most
>> generic 'compatible' value and list exactly one of the others in
>> addition.

> I will remove the others and just left "andestech,nds32v3" in here.

No, is not what we want here, the CPU node should list exactly which core
is used, what we need in the description is a clarification that
andestech,nds32v3 must be used in addition to the more specific
string.

       Arnd