Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68FDE21719
Date:   Fri, 19 Jan 2018 11:04:46 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc:     mingo@redhat.com, oleg@redhat.com, srikar@linux.vnet.ibm.com,
        linux-kernel@vger.kernel.org, namhyung@kernel.org
Subject: Re: [PATCH] trace_uprobe: Display correct offset in uprobe_events
Message-ID: <20180119110446.3d040c5f@gandalf.local.home>
In-Reply-To: <20180106054246.15375-1-ravi.bangoria@linux.vnet.ibm.com>
References: <20180106054246.15375-1-ravi.bangoria@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat,  6 Jan 2018 11:12:46 +0530
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:

> Recently, how the pointers being printed with %p has been changed
> by commit ad67b74d2469 ("printk: hash addresses printed with %p").
> This is causing a regression while showing offset in the
> uprobe_events file. Instead of %p, use %px to display offset.
> 
> Before patch:
> 
>   # perf probe -vv -x /tmp/a.out main
>   Opening /sys/kernel/debug/tracing//uprobe_events write=1
>   Writing event: p:probe_a/main /tmp/a.out:0x58c
> 
>   # cat /sys/kernel/debug/tracing/uprobe_events
>   p:probe_a/main /tmp/a.out:0x0000000049a0f352
> 
> After patch:
> 
>   # cat /sys/kernel/debug/tracing/uprobe_events
>   p:probe_a/main /tmp/a.out:0x000000000000058c
> 

Thanks, I'll pull this into my tree.

-- Steve