Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 19 Jan 2018 08:02:35 -0800
From:   Guenter Roeck <linux@roeck-us.net>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc:     "shufan_lee(?????|)" <shufan_lee@richtek.com>,
        'Jun Li' <jun.li@nxp.com>, ShuFanLee <leechu729@gmail.com>,
        "cy_huang(??????)" <cy_huang@richtek.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver
Message-ID: <20180119160235.GA21066@roeck-us.net>
References: <1515567552-7692-1-git-send-email-leechu729@gmail.com>
 <VI1PR0402MB3917ECDD1A8DCADFF5916BEA89EF0@VI1PR0402MB3917.eurprd04.prod.outlook.com>
 <eb1dfcd6f98545acac817db3289b1295@ex1.rt.l>
 <20180119082218.GA22976@kuha.fi.intel.com>
 <25ced79e8ea84908bf6110a613ed81a2@ex1.rt.l>
 <20180119092413.GB22976@kuha.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180119092413.GB22976@kuha.fi.intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jan 19, 2018 at 11:24:13AM +0200, Heikki Krogerus wrote:
> Hi,
> 
> On Fri, Jan 19, 2018 at 09:01:24AM +0000, shufan_lee(?????|) wrote:
> > Hi Heikki,
> > 
> >   For example, the flow of tcpci_init is a little bit different.
> >   In tcpci_init, there are more parameters need to be set for RT1711H.
> 
> Different init parameters is really not a reason for a fork of the
> driver. The configuration of the TCPC will depend on the platform and
> TCPC vendor most cases.
> 
Agreed. dwc3 usb support is an excellent example on how to handle this
kind of variation.

Guenter