Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 19 Jan 2018 09:16:36 -0800
From:   Tejun Heo <tj@kernel.org>
To:     Ivan Vecera <ivecera@redhat.com>
Cc:     linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
        viro@zeniv.linux.org.uk
Subject: Re: [PATCH driver-core] kernfs: fix regression in kernfs_fop_write
 caused by wrong type
Message-ID: <20180119171636.GE3460072@devbig577.frc2.facebook.com>
References: <20180119081854.13609-1-ivecera@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180119081854.13609-1-ivecera@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jan 19, 2018 at 09:18:54AM +0100, Ivan Vecera wrote:
> Commit b7ce40cff0b9 ("kernfs: cache atomic_write_len in
> kernfs_open_file") changes type of local variable 'len' from ssize_t
> to size_t. This change caused that the *ppos value is updated also
> when the previous write callback failed.
> 
> Mentioned snippet:
> ...
> len = ops->write(...); <- return value can be negative
> ...
> if (len > 0)           <- true here in this case
>         *ppos += len;
> ...
> 
> Fixes: b7ce40cff0b9 ("kernfs: cache atomic_write_len in kernfs_open_file")
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>

Oops.

  Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun