Received: by 10.223.176.46 with SMTP id f43csp1379307wra; Fri, 19 Jan 2018 10:38:57 -0800 (PST) X-Google-Smtp-Source: ACJfBosoQiOuvXPvVmwytAQJQ6Fvk3ly4St9PA9ZzzLaKsT3x9uQIG+tB0k4i1Ul1SAoW/tloqkw X-Received: by 2002:a17:902:8487:: with SMTP id c7-v6mr2081845plo.410.1516387137399; Fri, 19 Jan 2018 10:38:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516387137; cv=none; d=google.com; s=arc-20160816; b=ZPZwz0sUX77wtsU+cS3vCie7Emvdywngb3TuruWuCV4TNpqvpRQQtaJ+9JZJOzydrm YUtNRWl2p/xPu3Ld7rviG9qcXrpNAN/WvS426pVGmJhJ7VUx4K97yDB/nrwSIotTh986 697IkmW8bKgx8NdbbUJER5z3AUWf/pYh4mome2MadCsnJ8q5UgJF/2IsBTvgZwP+5RbK jznerl9bUMP1amkQYUnVFROF8eCaq36ejkiCETt7lwxUvej2uQhHwJoUyASovrKAAs9G +BL3aJpeqFpe+UBtl3wUObuyZr5tmbwc6CE8Zgz9AtH2c3BjH+x9kq5p6nMu+XSqQhwI i/bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=Wf7m4oKcLADwg2cKu7YPJv4VCr6TpcZOUHEir2CXhuI=; b=FE8EEJVF2BG1Llp5hZ94jn8MWzUKS1acmXQrk8p4JNP/+MDXGRRQWk5BjzTZ45G5Ni tfNb1XvABMGb2SiIBFuHYcKgORjhC0Jm81amubuZWg+Oxqw+H4/VTp6jWlT3KBOUjuGX ZAJhkTyOU2ZwO7t9GUnwdtto9CfaX/5X9gzK48Bxo2MraBPf0LeBzCfq9WAo9ypcks7C M2wwKE19SGJ4Xbymaqpv0AO5lTxpwMcebLT3ztHJYqfj6VlHCVN/IxheyQyNd3SwSmyK rj3LWqt6iotUh4EnglXpzdG8SJfEPUEAeF5rm63pkqs5oxPFSaqq2kWjxekHXpWepFgH Up6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ed0vH0v5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f5si8663105pgr.235.2018.01.19.10.38.43; Fri, 19 Jan 2018 10:38:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ed0vH0v5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932321AbeASSgw (ORCPT + 99 others); Fri, 19 Jan 2018 13:36:52 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:36062 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755899AbeASSgq (ORCPT ); Fri, 19 Jan 2018 13:36:46 -0500 Received: by mail-pf0-f193.google.com with SMTP id 23so1980643pfp.3 for ; Fri, 19 Jan 2018 10:36:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Wf7m4oKcLADwg2cKu7YPJv4VCr6TpcZOUHEir2CXhuI=; b=Ed0vH0v5KZhwFbE1Ohign20oKD6uNP7eQnDKHwzPpTkk+rYpKnPb4Pn3psC264RyC+ 2OOklV07YhxqNnrj5iYyxr0DFMIPCHQR0/MNnFTNuOiAInKaWGmVVvxT4VigFpss2JHL UliqtGUsG7iCLtizOaOOTFddSAQtLIPBxe8Wx97+IuHJBprjLkZXBEk9xGOgf6CANamW CwUI1K2xM810QUheqfMdxVrIVYxTfzZuWVLnqppMTd7NroFqjRScHlkot1kuhqMN6Ddu WrEVHobLYw1v0t6Y7fIUCjhEAchVOaV7v7uKu1xAFU8v60DkTFo3uV/mhb1a1AMOPvSs iQ0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Wf7m4oKcLADwg2cKu7YPJv4VCr6TpcZOUHEir2CXhuI=; b=l5DApFPIfpVPQW4P/rP8yMRX1XxnkoPmAHUOENsXdiXV9hJgV2m0AlL6EPIIe1EvN+ Vl1chYh+fUQKpGWehjuk6G0EmygEpHW3aMdDQJ0AHmR18VlvlAwTZStY06c/d5c49L3k 1pNaokspKquoL0tNYjI+/b/uS0ImKiun9WAN5GU/IVWPGJ7kOshodw6tsOZUty6vNK+P oUIgcKGAbkk3UxPxXNJwAVDd3KbTgAOoLx37blT7Qd4Y2wyrZAF389MqhhlTUoIPBpLe LXLzn7rvMuHEYnM9qfp1/a8byhWJgd8X21paFlSSSQIUDXd+NG4gw6+4l4h4M/ILlUG4 F6nQ== X-Gm-Message-State: AKwxytdNMZ9suHP7OW8oBu2eMJdKBujzhzCh7KOY7s+kR7N/OmpJESJt qseAf0knYcp56upIS1VeXy0= X-Received: by 2002:a17:902:622:: with SMTP id 31-v6mr2041959plg.448.1516387005565; Fri, 19 Jan 2018 10:36:45 -0800 (PST) Received: from shreeya-VirtualBox ([103.212.140.148]) by smtp.gmail.com with ESMTPSA id c11sm14654310pgv.40.2018.01.19.10.36.44 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 19 Jan 2018 10:36:45 -0800 (PST) From: Shreeya Patel To: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Cc: Shreeya Patel Subject: [PATCH v3 1/4] Staging: rtl8723bs: Replace true with x and false with !x Date: Sat, 20 Jan 2018 00:06:40 +0530 Message-Id: <6a57c658e7e0e66c9d7e9496769593cad4399647.1516386028.git.shreeya.patel23498@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace true and false keywords with "x" and "!x" respectively to follow the kernel coding style. Signed-off-by: Shreeya Patel --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 30 ++++++++++++++---------------- 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c index 93ac083..aa52c31 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c @@ -191,8 +191,8 @@ static u32 sdio_read32(struct intf_hdl *pintfhdl, u32 addr) rtw_hal_get_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn); if ( ((deviceId == WLAN_IOREG_DEVICE_ID) && (offset < 0x100)) || - (false == bMacPwrCtrlOn) || - (true == adapter_to_pwrctl(padapter)->bFwCurrentInPSMode) + (!bMacPwrCtrlOn) || + (adapter_to_pwrctl(padapter)->bFwCurrentInPSMode) ) { err = sd_cmd52_read(pintfhdl, ftaddr, 4, (u8 *)&le_tmp); #ifdef SDIO_DEBUG_IO @@ -248,8 +248,8 @@ static s32 sdio_readN(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pbuf) rtw_hal_get_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn); if ( ((deviceId == WLAN_IOREG_DEVICE_ID) && (offset < 0x100)) || - (false == bMacPwrCtrlOn) || - (true == adapter_to_pwrctl(padapter)->bFwCurrentInPSMode) + (!bMacPwrCtrlOn) || + (adapter_to_pwrctl(padapter)->bFwCurrentInPSMode) ) return sd_cmd52_read(pintfhdl, ftaddr, cnt, pbuf); @@ -352,8 +352,8 @@ static s32 sdio_writeN(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pbuf) rtw_hal_get_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn); if ( ((deviceId == WLAN_IOREG_DEVICE_ID) && (offset < 0x100)) || - (false == bMacPwrCtrlOn) || - (true == adapter_to_pwrctl(padapter)->bFwCurrentInPSMode) + (!bMacPwrCtrlOn) || + (adapter_to_pwrctl(padapter)->bFwCurrentInPSMode) ) return sd_cmd52_write(pintfhdl, ftaddr, cnt, pbuf); @@ -513,7 +513,7 @@ static u32 sdio_write_port( padapter = pintfhdl->padapter; psdio = &adapter_to_dvobj(padapter)->intf_data; - if (padapter->hw_init_completed == false) { + if (!padapter->hw_init_completed) { DBG_871X("%s [addr = 0x%x cnt =%d] padapter->hw_init_completed == false\n", __func__, addr, cnt); return _FAIL; } @@ -577,7 +577,7 @@ static s32 _sdio_local_read( HalSdioGetCmdAddr8723BSdio(padapter, SDIO_LOCAL_DEVICE_ID, addr, &addr); rtw_hal_get_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn); - if (false == bMacPwrCtrlOn) + if (!bMacPwrCtrlOn) return _sd_cmd52_read(pintfhdl, addr, cnt, pbuf); n = RND4(cnt); @@ -616,8 +616,8 @@ s32 sdio_local_read( rtw_hal_get_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn); if ( - (false == bMacPwrCtrlOn) || - (true == adapter_to_pwrctl(padapter)->bFwCurrentInPSMode) + (!bMacPwrCtrlOn) || + (adapter_to_pwrctl(padapter)->bFwCurrentInPSMode) ) return sd_cmd52_read(pintfhdl, addr, cnt, pbuf); @@ -662,8 +662,8 @@ s32 sdio_local_write( rtw_hal_get_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn); if ( - (false == bMacPwrCtrlOn) || - (true == adapter_to_pwrctl(padapter)->bFwCurrentInPSMode) + (!bMacPwrCtrlOn) || + (adapter_to_pwrctl(padapter)->bFwCurrentInPSMode) ) return sd_cmd52_write(pintfhdl, addr, cnt, pbuf); @@ -843,8 +843,7 @@ void ClearInterrupt8723BSdio(struct adapter *padapter) struct hal_com_data *pHalData; u8 *clear; - - if (true == padapter->bSurpriseRemoved) + if (padapter->bSurpriseRemoved) return; pHalData = GET_HAL_DATA(padapter); @@ -1161,8 +1160,7 @@ void sd_int_hdl(struct adapter *padapter) if ( - (padapter->bDriverStopped == true) || - (padapter->bSurpriseRemoved == true) + (padapter->bDriverStopped) || (padapter->bSurpriseRemoved) ) return; -- 2.7.4