Received: by 10.223.176.46 with SMTP id f43csp1448687wra; Fri, 19 Jan 2018 11:42:57 -0800 (PST) X-Google-Smtp-Source: ACJfBou78VkaqLbi9xtsw8OcxkYsA+lSMTOviEARWrxt/4XuB4YfPpsgEmIyiNuJS7zJG2XKlYh0 X-Received: by 10.101.75.193 with SMTP id p1mr17785150pgr.63.1516390977226; Fri, 19 Jan 2018 11:42:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516390977; cv=none; d=google.com; s=arc-20160816; b=fVtHy7dgd3DG6es09pS1AHbCu1TLz+F7wZVm3iDi8y3q4NIu1HzBogv/Z73XRzdsSz qpv2Yrp7aBEFHKEiXzAbjrMHOxgjyqEns1BMGDPK9F+m1YYlrB5EpHkn4NKUG6sxwypA mocclb7uo37JpvZI/Rc1wXHqtpGPt/Racq34MlIch59WpNFJ6wOSeeHcBrW61p1dkXVM UkM8i3NG4U6WD7+8t1EO8K472kbjTdo1VXViZbUM58rWFDe/d80IVohNHbLsqtdAi9dL tq3V4rEBJaqAcT3yh63Yyo1RN/cFOQHVyBDae3EMAppranpkAm3SJfWtoBrl++KDcLQj 9YCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=LGSnjyo2bm8JHLcb58CVOvKUd+AWJ414ycl1920KdNc=; b=Hxu0PKgqbxYXZVg8khDS6p41sjJOpJ4Cetk3OdxI5X6UDnQq08/YjMc2/TpdNjeNNK 40VCC+gVnudhhMrcLbxkjlMXf1643tRmLgzO4x6dhzlpyojZkcz/SDV3mc8y0c9EcvbW Kxw3iy+joPLuODys1PRGMr21rcxTBbihlP7yzvRAfPKI7F9JwndVgJC8Np9E6f09osJ3 TVhC/DCNPWOIDA6QalZUlp2EqAF8/ncc4hv2qVJv7EMi2YPGzJyy8JRXfP9KcSc6byi9 Zp92M0hKT9YelnMoX18lH8eP5smnYB7klwTcug/837OERZxYUuG4ydWbIanuMc57e2N4 5w9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=R+YXEmp4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x141si8921392pgx.601.2018.01.19.11.42.43; Fri, 19 Jan 2018 11:42:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=R+YXEmp4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756462AbeASTlz (ORCPT + 99 others); Fri, 19 Jan 2018 14:41:55 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:46798 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756223AbeASTlS (ORCPT ); Fri, 19 Jan 2018 14:41:18 -0500 Received: by mail-pg0-f65.google.com with SMTP id s9so2161562pgq.13; Fri, 19 Jan 2018 11:41:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LGSnjyo2bm8JHLcb58CVOvKUd+AWJ414ycl1920KdNc=; b=R+YXEmp4B+89QYRkjlBUvz5B1MHqDAZWXb4Roa78YstCjKln20LYlc73O2zhwBjbfm /l2u3AWXtUxENpkLhXjiKTCOCs3+4rcHikCMmiMd9eSX4c09nPue3nJuCHNYVJwLBeLn /ovYMlOajLMdwIxmcyDwD7xn9bG1eNnYOfCY1dYWen12+KHgzC1xp5OTZLbwm92VfO2V HuTTJb2b3hNw4fMq1G/4+S7t+Wedip35k0DAJoV2VHnYZMBK4l0TtHv1pJK03Dpkmk+r FSZkXh4KK8J+nv7JLZ6dr3jllqGVWLq86f0yX3dKdMmjyVNAvvzpeauHY+MUVgT85t6a xx/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=LGSnjyo2bm8JHLcb58CVOvKUd+AWJ414ycl1920KdNc=; b=d4o4a4QzT5BHQxdmJihWMy5hi8fefZ3g7m/2I+eKto5mLOod8byuAnVIFfGiA16+Ra vcGhfPXGqqqzuytS3f5iBTMXJ/a/CasaceCMSk361JiEhvosQn/ABPfdKWeNbTc27a65 V0P1cNru3C3jkQS9aao8LhYuhPppm8trGXTQajx/RQzoZKQQ75FXcT26ffmUYRc+2EID guqyQCETK+eXQUA/2nCKl77MCizFR4xSbY0hDk/77rsYJvvWOPyiLRwt1iX33dVSkJLx QA0Kk2RQfSEDQSmdtebzfCPHbBQb2kqd0rjKpjA/CIFmNCQ0gaowFTd9WoU5wswN93wp UQWQ== X-Gm-Message-State: AKwxytc8u/EYagdvkL8119ycydJKJPgLo5v6nrNkLVxBK2v8aEOF5+AM /vDateI80vVt7BbYn6GI9ioHFsJ4 X-Received: by 2002:a17:902:4906:: with SMTP id u6-v6mr2156731pld.148.1516390877186; Fri, 19 Jan 2018 11:41:17 -0800 (PST) Received: from dtor-ws.mtv.corp.google.com ([2620:0:1000:1611:da80:8749:c06f:9515]) by smtp.gmail.com with ESMTPSA id p1sm18947830pgr.44.2018.01.19.11.41.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Jan 2018 11:41:16 -0800 (PST) From: Dmitry Torokhov To: Benjamin Tissoires , Hans de Goede , Lyude Paul Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/7] Input: libps2 - use BIT() for bitmask constants Date: Fri, 19 Jan 2018 11:41:07 -0800 Message-Id: <20180119194111.185590-4-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.16.0.rc1.238.g530d649a79-goog In-Reply-To: <20180119194111.185590-1-dmitry.torokhov@gmail.com> References: <20180119194111.185590-1-dmitry.torokhov@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Let's explicitly document bit numbers with BIT() macro. Signed-off-by: Dmitry Torokhov --- include/linux/libps2.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/linux/libps2.h b/include/linux/libps2.h index 365c50b097ded..649295a5ff47d 100644 --- a/include/linux/libps2.h +++ b/include/linux/libps2.h @@ -20,11 +20,11 @@ #define PS2_RET_NAK 0xfe #define PS2_RET_ERR 0xfc -#define PS2_FLAG_ACK 1 /* Waiting for ACK/NAK */ -#define PS2_FLAG_CMD 2 /* Waiting for command to finish */ -#define PS2_FLAG_CMD1 4 /* Waiting for the first byte of command response */ -#define PS2_FLAG_WAITID 8 /* Command execiting is GET ID */ -#define PS2_FLAG_NAK 16 /* Last transmission was NAKed */ +#define PS2_FLAG_ACK BIT(0) /* Waiting for ACK/NAK */ +#define PS2_FLAG_CMD BIT(1) /* Waiting for a command to finish */ +#define PS2_FLAG_CMD1 BIT(2) /* Waiting for the first byte of command response */ +#define PS2_FLAG_WAITID BIT(3) /* Command executing is GET ID */ +#define PS2_FLAG_NAK BIT(4) /* Last transmission was NAKed */ struct ps2dev { struct serio *serio; -- 2.16.0.rc1.238.g530d649a79-goog