Received: by 10.223.176.46 with SMTP id f43csp1449311wra; Fri, 19 Jan 2018 11:43:31 -0800 (PST) X-Google-Smtp-Source: ACJfBot+uUnoNoCbBWvzlMVvWKHs10+8amBMcc/aCOiYByqVpmCjp8dQ43Niyz8MbNUoZSGIjAag X-Received: by 2002:a17:902:d217:: with SMTP id t23-v6mr2160855ply.303.1516391011056; Fri, 19 Jan 2018 11:43:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516391011; cv=none; d=google.com; s=arc-20160816; b=aJfeDAaHcA72IEA60dkFfugkvDM9iAVEGycZhgv8NyEdW7KW600zd/pTmSc3+k71tY 1ERhNnSSYZojPT2L4gAXj7198J8bAMg8BZ80aw4ggmazZ+Fl0h2m+l6ZS7U8uWhCxNYo ppQUeV7IBak5mOUtRgmEoJCZ9uYwNIXXv5WZTUqjFfoHWiVt+0oxl5S3Kd8LIkmqdFdF zL/Oq6BCOb5DkI2GhGcujrnFrGvbk5o4mQQoyDnLefwgscGpEW0YWzHI2LCXmoDsYzUl 4OPWTNMGBy+2/5VnLUzdftgzHyGdu31RAoXY6NVJ2ruTbbfPBxeevLw+n6taZO16mybQ x+SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=AK2eb9Q9+meBCglTZBvTFy2kPnl04osu9XKVK2fmYe8=; b=k5eHyknFbBxsjI9moB2rY9iIso8r6f9Hp/2FBhVHEOcwWV/fwBCuAWDtTaVmh2FYG5 oKy575hHLnpcFyg2822p6iHnX9qTpLQm/PkK2XjWwRZNcN0w0HO9ENM/yA0VRW3JZRdi SJilbHXe1SxD0mk3z/pXJjKKiQI2Lmni6is5I2R4Vq3NMYiWnn4OSClJrPHvPGUMUwhf KWQMhB2dGgiXUQS8T0O3Tcf6mNvLm9kX0JFEmtmh8QE1IaS9faVbtlv1Ls7eW4KPpFrz Yq2Io7dF3GxiUsZR0hDBA6nVhxsC4y4J7xJvou19LPA42BUONFxFh9il+Ik6xHrSg0NK gdWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DJf8j3n2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i189si8631720pgc.691.2018.01.19.11.43.16; Fri, 19 Jan 2018 11:43:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DJf8j3n2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756256AbeASTlX (ORCPT + 99 others); Fri, 19 Jan 2018 14:41:23 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:39377 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755932AbeASTlP (ORCPT ); Fri, 19 Jan 2018 14:41:15 -0500 Received: by mail-pg0-f68.google.com with SMTP id w17so2168241pgv.6; Fri, 19 Jan 2018 11:41:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=AK2eb9Q9+meBCglTZBvTFy2kPnl04osu9XKVK2fmYe8=; b=DJf8j3n2z7ndfAcNUrRYoEspzTFtJuFvOisEDD0HeRf/TUdIpdeFEoDPU79hacKbcm vqG5pi9mUKOBB5OFslL54tXtcgjxVj2iYdfDQzEzG7wGBSrZ6TxcdUA4hrD83+ozvTOc V6J11M39S3TyInkuWtebdCnQQ7VFGf0y5ZH2HwzFTaCf2il2XNg/G6Xq+yPlr9ZTS+eI cvfkJfDdQfxgxsR1HLD2/ySTntCxUPksh6QZctTl5wx7mHrL3BSA5qNsJJ+Lvapp26Dz ME+SUYxiJH+nhQnfVAumucY+snBLcssqY2ZinlqURu77I0uOn6WEgS/eydxaGl5oV4lO SCfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=AK2eb9Q9+meBCglTZBvTFy2kPnl04osu9XKVK2fmYe8=; b=EdOnFJvnEGIrPcn4RW/oWKKQwnvFk0bAzdJSGLfxUVMilEA3ewljjo/izgqwfHPAoO WzJhnPIo7nwUL9Cyx41j+9iRgtl2jCWLJxSGZmBmG+r32CGZgA4dKyDcpmivNTCxZcja eEBJOiJIMj9AkdELbQmz3vJhFtmA8p3Dv6mzZzMYj7VaIckOWGp2/0Ldzpl9+zkrCAMq aeIfc1Q4eXzko/sA48BHkGLbaetoxJBT9T+q9IVpBwm43FRssbCe/bRtf6sBdQr39ndu C+8U5BbifcZcomhlJmhEZG/yl6T9z7qbZW/of/trgV8RrkgSJOW7i9Xe9OHCGXATx25j kg3Q== X-Gm-Message-State: AKwxytfXKa7r4i7gQ8WLhKGPJWpv7M+v5NCwwpPHkipYQUipi7DhqFSa hhnSfhjAziFI1ByCq3jTjQA= X-Received: by 10.99.111.11 with SMTP id k11mr12645730pgc.414.1516390874718; Fri, 19 Jan 2018 11:41:14 -0800 (PST) Received: from dtor-ws.mtv.corp.google.com ([2620:0:1000:1611:da80:8749:c06f:9515]) by smtp.gmail.com with ESMTPSA id p1sm18947830pgr.44.2018.01.19.11.41.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Jan 2018 11:41:14 -0800 (PST) From: Dmitry Torokhov To: Benjamin Tissoires , Hans de Goede , Lyude Paul Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/7] libps2 facelift Date: Fri, 19 Jan 2018 11:41:04 -0800 Message-Id: <20180119194111.185590-1-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.16.0.rc1.238.g530d649a79-goog Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, The main reason for the patch series is to have a bit more manageable debug info for PS/2 init sequence: raw i8042 debug is way too noisy, one has to decode sliced commands by hand, etc, etc. With proposed changes you get a nice parsed command flow: [14421.985416] __ps2_command: psmouse serio2: f5 [] - 0/00000000 [] [14421.993112] __ps2_command: psmouse serio2: f6 [] - 0/00000000 [] [14422.007738] __ps2_command: psmouse serio2: e1 [] - 0/00000000 [03 04] [14422.042522] __ps2_command: psmouse serio2: e2 [81 4a 80] - 0/00000000 [] [14422.057091] __ps2_command: psmouse serio2: e2 [2c] - 0/00000000 [20] [14422.057118] psmouse serio2: trackpoint: Elan TrackPoint firmware: 0x04, buttons: 3/3 [14422.072062] __ps2_command: psmouse serio2: f3 [64] - 0/00000000 [] [14422.086839] __ps2_command: psmouse serio2: e8 [03] - 0/00000000 [] [14422.094306] __ps2_command: psmouse serio2: e6 [] - 0/00000000 [] [14422.094504] input: TPPS/2 Elan TrackPoint as /devices/rmi4-00/rmi4-00.fn03/serio2/input/input33 [14422.128629] __ps2_command: psmouse serio2: f4 [] - 0/00000000 [] Additionally libps2 now can handle command and parameter byte retransmissions and we relaxed rules for getting initial ACK to the command byte, which hopefully will help properly detect devices that are not silent when we start probing them. Thanks. Dmitry Torokhov (7): Input: libps2 - fix switch statement formatting Input: libps2 - use u8 for byte data Input: libps2 - use BIT() for bitmask constants Input: psmouse - move sliced command implementation to libps2 Input: libps2 - add debugging statements Input: libps2 - support retransmission of command data Input: libps2 - relax command byte ACK handling drivers/input/mouse/elantech.c | 12 +- drivers/input/mouse/logips2pp.c | 2 +- drivers/input/mouse/psmouse-base.c | 26 --- drivers/input/mouse/psmouse.h | 1 - drivers/input/mouse/synaptics.c | 8 +- drivers/input/serio/libps2.c | 322 +++++++++++++++++++++++++------------ include/linux/libps2.h | 34 ++-- 7 files changed, 249 insertions(+), 156 deletions(-) -- Dmitry