Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE
 programs
To:     Quentin Monnet <quentin.monnet@netronome.com>,
        Roman Gushchin <guro@fb.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-team@fb.com, Jakub Kicinski <jakub.kicinski@netronome.com>,
        Alexei Starovoitov <ast@kernel.org>
References: <20180115191615.13911-1-guro@fb.com>
 <34c43a17-7832-413e-fea8-4ad0f80f1585@netronome.com>
 <20180119141739.GA22398@castle.DHCP.thefacebook.com>
 <29c01fd7-8f1e-91bf-0be6-a2b220e0e637@netronome.com>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <cca7e942-634d-f1ad-e42b-5b1d2ba5a868@iogearbox.net>
Date:   Fri, 19 Jan 2018 23:19:44 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <29c01fd7-8f1e-91bf-0be6-a2b220e0e637@netronome.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 01/19/2018 03:37 PM, Quentin Monnet wrote:
> 2018-01-19 14:17 UTC+0000 ~ Roman Gushchin <guro@fb.com>
>> On Mon, Jan 15, 2018 at 07:32:01PM +0000, Quentin Monnet wrote:
> 
> [...]
> 
>>> Looks good, thanks Roman!
>>> Would you mind updating the map names as well? It seems the
>>> BPF_MAP_TYPE_CPUMAP is missing from the list in map.c.
>>
>> Hello, Quentin!
>>
>>
>> Here is the patch.
>>
>>
>> Thanks!
>>
>> --
>>
>> From 16245383a894038a63cc1ad4b77629ba704aaa38 Mon Sep 17 00:00:00 2001
>> From: Roman Gushchin <guro@fb.com>
>> Date: Fri, 19 Jan 2018 14:07:38 +0000
>> Subject: [PATCH bpf-next] bpftool: recognize BPF_MAP_TYPE_CPUMAP maps
>>
>> Add BPF_MAP_TYPE_CPUMAP map type to the list
>> of map type recognized by bpftool and define
>> corresponding text representation.
>>
>> Signed-off-by: Roman Gushchin <guro@fb.com>
>> Cc: Quentin Monnet <quentin.monnet@netronome.com>
>> Cc: Jakub Kicinski <jakub.kicinski@netronome.com>
>> Cc: Daniel Borkmann <daniel@iogearbox.net>
>> Cc: Alexei Starovoitov <ast@kernel.org>
>> ---
>>  tools/bpf/bpftool/map.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c
>> index a152c1a5c94c..f95fa67bb498 100644
>> --- a/tools/bpf/bpftool/map.c
>> +++ b/tools/bpf/bpftool/map.c
>> @@ -66,6 +66,7 @@ static const char * const map_type_name[] = {
>>  	[BPF_MAP_TYPE_HASH_OF_MAPS]	= "hash_of_maps",
>>  	[BPF_MAP_TYPE_DEVMAP]		= "devmap",
>>  	[BPF_MAP_TYPE_SOCKMAP]		= "sockmap",
>> +	[BPF_MAP_TYPE_CPUMAP]		= "cpumap",
>>  };
>>  
>>  static unsigned int get_possible_cpus(void)
>>
> 
> Good, thank you!
> 
> Acked-by: Quentin Monnet <quentin.monnet@netronome.com>

Applied to bpf-next, thanks for following up Roman!