Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <fd9de06f-df7e-4114-8dda-0483c338b394@arm.com>
References: <1516272219-25359-1-git-send-email-sudeep.holla@arm.com> <fd9de06f-df7e-4114-8dda-0483c338b394@arm.com>
From:   Andy Gross <andy.gross@linaro.org>
Date:   Fri, 19 Jan 2018 17:34:00 -0600
Message-ID: <CAPBZ5QfuExQtM91wPCooiCoztoyt8ihXXWPccGi=_zca+eO5JA@mail.gmail.com>
Subject: Re: [PATCH -next] of: platform: fix OF node refcount leak
To:     Sudeep Holla <sudeep.holla@arm.com>
Cc:     devicetree <devicetree@vger.kernel.org>,
        Linux Kernel list <linux-kernel@vger.kernel.org>,
        Loys Ollivier <lollivier@baylibre.com>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 19 January 2018 at 09:37, Sudeep Holla <sudeep.holla@arm.com> wrote:
> Hi Andy,
>
> On 18/01/18 10:43, Sudeep Holla wrote:
>> We need to call of_node_put() for device nodes obtained with
>> of_find_node_by_path().
>>
>> Fixes: 3aa0582fdb82 ("of: platform: populate /firmware/ node from of_platform_default_populate_init()")
>> Reported-by: Loys Ollivier <lollivier@baylibre.com>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Frank Rowand <frowand.list@gmail.com>
>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>> ---
>>  drivers/of/platform.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>
> Can you pick up this with other fixes you would send after v4.16-rc1 or
> do you prefer me to route through ARM-SoC directly ? Let me know.

I can pick this up for fixes, no problem.  I can send it along right
now if you like.  This is a pretty low risk patch.

Regards,

Andy