Received: by 10.223.176.46 with SMTP id f43csp169375wra; Fri, 19 Jan 2018 15:37:21 -0800 (PST) X-Google-Smtp-Source: AH8x226GYXh0wQ4zza7wSDV9BvSsSwTjYceM3barjiMPaHcNp9bTiUwRsvogyFbW6JVCfetPm8ww X-Received: by 10.98.211.21 with SMTP id q21mr171674pfg.89.1516405041378; Fri, 19 Jan 2018 15:37:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516405041; cv=none; d=google.com; s=arc-20160816; b=tjpm3m2sm8rcD2p4k6QKlH02eWJqdZDMBVJvkvd8peGJcoKAb1NzuUoNJ/jZdOw/rH Qslrt0hDgxVZ/Aq3NgR/tb95S0TpdLP5ShcxH6IGRaBobyMrInNxa6v6O/6QoU493Tzb BMn+zX6OHSJGCZktbNdfnt+pUK0RmDnFQ4v0dZNvFcIG/xREdhcsjUpD9UeOoTRYWGNj yewOyGfAyxiYcUe4KuxGClARLeMW2N3H+bNglUycH6ii7pG6PvitCP3PCTdfNyKgV3iv 8ET/v4eexW0tLeCT4URlhRxZVpEMVF8mwx4jxl3O6RcgBfwxaaw6G/PZKhv7aXJFZHQK IRZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=goTi0lJoC+rNfnFq5+JcZNmc+6PCzIwNv5cJ2ciFF04=; b=Kv4X8Mu7YL6ppSmoOR83tudzz8cmzUAdmcojY3mjcqZ56w/jleW9OWawTBN9VNZvmV ihkbmaQFVu/5hXyqAH5kEl+pNkkc81HOT6sFSuGJ37nIQHY8bPKpRgTl8ADHgUImDVdd c39QTSaO5MTogS7KRy+EQEPp4QdviLORaPohcBzzwlUd/VRHVtH5DK2c6QaUtTHTIWQ4 P65TzE18jZohE9u4aXN37sY8Zjyep65kmA66epoRshiyOMLcRsbTll4CJWdhJpm+cTYr 53uEiGrLjdZluJAAFppTR3YiWBISh/7gfb7ekGjYscM842TaPAbUCIggWhRuyGWTzdOW cDUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i2si1234348pgo.550.2018.01.19.15.37.06; Fri, 19 Jan 2018 15:37:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932377AbeASXgR (ORCPT + 99 others); Fri, 19 Jan 2018 18:36:17 -0500 Received: from eddie.linux-mips.org ([148.251.95.138]:37218 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754339AbeASXgK (ORCPT ); Fri, 19 Jan 2018 18:36:10 -0500 Received: (from localhost user: 'ladis' uid#1021 fake: STDIN (ladis@eddie.linux-mips.org)) by eddie.linux-mips.org id S23992079AbeASXgHbRk4H (ORCPT + 1 other); Sat, 20 Jan 2018 00:36:07 +0100 Date: Sat, 20 Jan 2018 00:36:06 +0100 From: Ladislav Michl To: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Bjorn Helgaas , Greg Kroah-Hartman , Thomas Gleixner Subject: Re: [PATCH 0/2] Fix double mem region release Message-ID: <20180119233606.GA18837@lenoch> References: <20180119180310.GA31540@lenoch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180119180310.GA31540@lenoch> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 19, 2018 at 07:03:10PM +0100, Ladislav Michl wrote: > Two one-liners for the same issue, second bug occurrence is just > a copy&pasted mistake from 2011... > > Ladislav Michl (2): > devres: Fix double mem region release in devm_ioremap_resource() > PCI: Fix double mem region release in devm_pci_remap_cfg_resource() Hmm, that is really shame :-/ My test setup triggered "Trying to free nonexistent resource" warning, but dissasembly of lib/devres.o shows no call to devres_destroy, which seems that WARN_ON in __devm_release_region() is optimized out. Strange. So far sorry for the noise, I'll try figure out what broke after weekend. > drivers/pci/pci.c | 1 - > lib/devres.c | 1 - > 2 files changed, 2 deletions(-) > > -- > 2.15.1 >