Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 20 Jan 2018 01:00:12 +0100
From:   Francois Romieu <romieu@fr.zoreil.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Jia-Ju Bai <baijiaju1990@gmail.com>, nic_swsd@realtek.com,
        alexander.h.duyck@redhat.com, David Miller <davem@davemloft.net>,
        dhowells@redhat.com, paulmck@linux.vnet.ibm.com,
        will.deacon@arm.com, netdev@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: net: r8169: a question of memory barrier in the r8169 driver
Message-ID: <20180120000012.GB14475@electric-eye.fr.zoreil.com>
References: <9a373156-41e5-a78b-cd31-c4b9bdba2696@gmail.com>
 <20180118150658.GE2249@hirez.programming.kicks-ass.net>
 <20180119011118.GB15920@electric-eye.fr.zoreil.com>
 <20180119171442.GY2228@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180119171442.GY2228@hirez.programming.kicks-ass.net>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Peter Zijlstra <peterz@infradead.org> :
> On Fri, Jan 19, 2018 at 02:11:18AM +0100, Francois Romieu wrote:
> > Peter Zijlstra <peterz@infradead.org> :
> > [...]
> > > There is only 1 variable afaict. Memory barriers need at least 2 in
> > > order to be able to do _anything_.
> > 
> > I don't get your point: why don't {cur_tx, dirty_tx} qualify as said
> > two variables ?
> 
> There wasn't any cur_tx in the code you provided.

/* A skbuff with nr_frags needs nr_frags+1 entries in the tx queue */
#define TX_FRAGS_READY_FOR(tp,nr_frags) \
        (TX_SLOTS_AVAIL(tp) >= (nr_frags + 1))

#define TX_SLOTS_AVAIL(tp) \
        (tp->dirty_tx + NUM_TX_DESC - tp->cur_tx)

Both are also used in rtl_tx.

I don't get your point. Even a single variable is scattered through
the system.

-- 
Ueimor