Received: by 10.223.176.46 with SMTP id f43csp303242wra; Fri, 19 Jan 2018 18:08:51 -0800 (PST) X-Google-Smtp-Source: AH8x227bZwiUofekZ8/OvDWOGX3PdhGhj082GhXpVujdWPARJsfs7x+qoFyc42eF+Cs46T9sA+PI X-Received: by 10.99.8.135 with SMTP id 129mr505562pgi.2.1516414131356; Fri, 19 Jan 2018 18:08:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516414131; cv=none; d=google.com; s=arc-20160816; b=PvjF9Z2OsDQo9OTRUfaagNMecmThXLIt+VrRp4SFXZ9kPlDECIchgehDAtoO+AGelF +uMw4si7NI0bYI/7e+MASzKI/XlQxt9iCnDLearJdF2R6v0nIrYKN/hPizlyVd7O6E0c hR1dPy9wOIUGDqZCjIEIKksOGcqq0RuWdV/2+U/xnq82VGHHQm22pN69LM8gu0+EX7Ou Aczlu0QX5Uki6quxpYztGY2xB7Ph0MYJ65vAdvRVa6CJ4k5l4Li7C+PxwNhYpVWp5JgQ oyYGSwKQciaUj1sFqhjTYBrkAAANpCG0OmQESjQv7m24vAKannUNhQy8Xbd8GoNn+kt8 hd+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=9YjybV2XXQqBstC0D2gxqKP97FFoAKjRIvt4/KyPWZg=; b=1HE9p2yXOFpQrKgBEqtnVo7FuGjTRWAnEaRuzkLEa2rievL/xzriShShvayn3o2mHl S3g1Ggibtzte2Jc+096RRANmNgUfHuodCKoHu3VKuLitlDP6sXR2tKe88rDulFwZ4hla JCV6gpDSgNF3+87gZRqbjvRHgO78pSF7AitryA2/QVzLVPhRBaM//hLycokg5kPiMnLD pq2rbSPhup7MW1oQErkeXnp6KeaAJxL5MyHjpprXNl5hsKiFXmyAfFaHmLn8zSkaDaCx QndJT7qqAFj3Da9rVaBjsx2qjzMCGae7ZQiV8Hmh3LbWGCbNHDtBs5iq1rn6h5WDGpOD WxAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j11-v6si1295986pll.485.2018.01.19.18.08.37; Fri, 19 Jan 2018 18:08:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756263AbeATCIC (ORCPT + 99 others); Fri, 19 Jan 2018 21:08:02 -0500 Received: from mga14.intel.com ([192.55.52.115]:60584 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754766AbeATCIA (ORCPT ); Fri, 19 Jan 2018 21:08:00 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jan 2018 18:07:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,383,1511856000"; d="scan'208";a="11594260" Received: from unknown (HELO localhost.localdomain) ([10.232.112.44]) by orsmga008.jf.intel.com with ESMTP; 19 Jan 2018 18:07:58 -0800 Date: Fri, 19 Jan 2018 19:11:20 -0700 From: Keith Busch To: "jianchao.wang" Cc: axboe@fb.com, hch@lst.de, sagi@grimberg.me, maxg@mellanox.com, james.smart@broadcom.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V5 0/2] nvme-pci: fix the timeout case when reset is ongoing Message-ID: <20180120021119.GJ12043@localhost.localdomain> References: <1516270202-8051-1-git-send-email-jianchao.w.wang@oracle.com> <20180119080130.GE12043@localhost.localdomain> <0639aa2f-d153-5aac-ce08-df0d4b45f9a0@oracle.com> <20180119084218.GF12043@localhost.localdomain> <84b4e3bc-fe23-607e-9d5e-bb5644eedb54@oracle.com> <20180119115255.GH12043@localhost.localdomain> <3cc0d180-0b7e-e71f-66ce-43f4dfffb701@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3cc0d180-0b7e-e71f-66ce-43f4dfffb701@oracle.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 19, 2018 at 09:56:48PM +0800, jianchao.wang wrote: > In nvme_dev_disable, the outstanding requests will be requeued finally. > I'm afraid the requests requeued on the q->requeue_list will be blocked until another requeue > occurs, if we cancel the requeue work before it get scheduled. We should kick the request list in nvme_start_queues.