Received: by 10.223.176.46 with SMTP id f43csp405759wra; Fri, 19 Jan 2018 20:16:58 -0800 (PST) X-Google-Smtp-Source: AH8x225AYwtvY9+s52qNXqDvkeNIrbzSWZaAj+s6ajnX7WJYD1HNXv0ldeGBjO8e6G5WtA7VbdU3 X-Received: by 10.98.56.150 with SMTP id f144mr867003pfa.167.1516421818672; Fri, 19 Jan 2018 20:16:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516421818; cv=none; d=google.com; s=arc-20160816; b=xAAWXheG5zFH+AFUv1kwnFhF0/LyJCqke5kB8Z/TIN5L2/IUlWtsLDwnTt7k4+hxTs ZaMZodOUXXxKiemx0AP+IVdwmOBX3t/KIEBJHNuA0TQd/XMXAdsXqPAAjM/ryskgengi YfDUUgEC1MAy7I4rOS/GpNRNZTKA7424aJcgNnlfsb9UPuofpU0GzpICAytR6TTVw77e qXO3vLT9V0dgT1AajxKQOtgbDd08xJ6ljjbF2R8xU0TD4oQFgsfm5zlOt1pXzjdwBCWF D8lIz9zxfXkoCOJqsq3LFTDmm8kJdsZhf1GRRHdSUwqZcvAvVaiuNBuEkX2WwHp0K94h kMRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:spamdiagnosticmetadata :spamdiagnosticoutput:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature:arc-authentication-results; bh=DWpgxBxsI2KX8FF2wOomIOsv1A4WXVA1q1mfnPPaLpU=; b=LKqvU9tEIuM3R+iTo8KL5oBdfy9PUKAXY2x3chWQ0AgwR6VwXTtUJJ7aDKubQ9bByx E1Fx9PBNeXThJKwbnyA+C41peg8DJ1b7UNV3R9H12jQKMTPQKbctxuXXQoQ+tuY7t+vn 67cD3O/kyMJQUzGX393Qq7VFMq0zqfn2SKJO13Thi05Hl/r9mCKMtkX3otFiaBUjryVx vNqW2WJkZCMOGL9A6ynYqzBN7zt42FfTlqIyKlsn3Iz/6D1sVL59JB5GWPg7Dy+az6wR 3qwpPI4nT4Nhl2JOF8U1qJ3aW1QsEZfj+sFxScmhhxmTUVlt/GuuklTjwEOEcrEBmBZZ ELVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector1-amd-com header.b=RzvICwHC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i188si9353197pgc.177.2018.01.19.20.16.44; Fri, 19 Jan 2018 20:16:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector1-amd-com header.b=RzvICwHC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754766AbeATEOL (ORCPT + 99 others); Fri, 19 Jan 2018 23:14:11 -0500 Received: from mail-by2nam03on0049.outbound.protection.outlook.com ([104.47.42.49]:3360 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754041AbeATEOH (ORCPT ); Fri, 19 Jan 2018 23:14:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=DWpgxBxsI2KX8FF2wOomIOsv1A4WXVA1q1mfnPPaLpU=; b=RzvICwHCltIsgaZjmpFE3+7k9eQgpFjNIxpq6RIF5GskQKmwo0w3Yc8alGc5afcYg03r2Ia+2p2PSDKUY7S6JyzWeuP4iklXFFv4atufOOYhqOXUswfqTxpfsuLUPsEsGGzDKsPRQRCWZb/Fh20fkyz7JCF+00k6WlpyDHKphXk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Received: from [10.236.65.116] (165.204.78.1) by BN6PR12MB1137.namprd12.prod.outlook.com (10.168.226.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Sat, 20 Jan 2018 04:14:02 +0000 Subject: Re: Boot regression with bacf6b499e11 ("x86/mm: Use a struct to reduce parameters for SME PGD mapping") on top of -rc8 To: Linus Torvalds , Laura Abbott Cc: Borislav Petkov , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Brijesh Singh , X86 ML , Linux Kernel Mailing List References: <9fdddcb1-d122-7d52-9204-7066ada5ccba@redhat.com> From: Tom Lendacky Message-ID: <62c64d88-8a97-8c97-d8ee-29b577c72c99@amd.com> Date: Fri, 19 Jan 2018 22:13:56 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: CY4PR0601CA0096.namprd06.prod.outlook.com (52.132.96.165) To BN6PR12MB1137.namprd12.prod.outlook.com (10.168.226.139) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 619188ca-5188-4682-8799-08d55fbc3df1 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(48565401081)(2017052603307)(7153060)(7193020);SRVR:BN6PR12MB1137; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1137;3:RzsGjImSh+tWLIXZY+nYzBa/wKxP5D2Jeuqf0WuTIyu3o4lRInm9dMmP1aXl6ds9C5RZNh19kJ/ndT+gjNx4ehWTQZAqKbZSVRHAiX4ih+GPGDM99tE9R3F3PdQMgrtscuAu0ClrLi6HjRx55uyvRNAAyDgOV1wqoyI4Ht/S+UFCmWmvEKZWw6IBaW82EY6y24LoRkceXq2YtnLW1pYxvLODRpkfPtT/kWD8dCbknsTLMT2L+JYJ5d5XNTHmhqnG;25:T1+h3BlAdJYlsM/I3vA1rrz2cTfeznZ4kUiAtCaeUlcMJNejCaVOXSAhsWtALnBNvSl1fuKXWYXVP0cY7sRXRFKcT5rSx5m5VIK7A4wW/Zb0O57NowtC8wuA9eugukRwByVpsuGWMgYedXkyhNfDmBHyBsQ8QXXPFblSEiVJfOY3urOojU/BUwiVei8mjToUUkQWWlSzH+rFV6JIr2Dobee/cIrbN6l5gfkUR1iv3Zgbd+OBzIUzFeRrr0PNhBZ3FeJ5QlYZONDHdod4dQZQrfFkY7kZrltnt1kxHAADko2EZyFpZLqtK4VdIL7VBetUngo/lCOw8LqyEtDkDpboog==;31:PuoKMtjpYY3bGy6naZDuufjBmbIhQsteA+Q3Jk1A7DW+/Rhf4FQq5oTLd02+BhkE6ig+KqKeD3if7cOnRkWGaGExMlbgFWwhBxpvZwwiHwSMdh/m0OlzuKFlNFbaaF/wwcOU+alUhIjAXn7oQFj2yvrAqhD73PklWVrV7vulfjSEH7S8Nta+G/GXJ/SzpV5yXnx6+NqVhhfdZmXGTs2fNwzjRCtHrB/ARiroHUBjWz8= X-MS-TrafficTypeDiagnostic: BN6PR12MB1137: X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1137;20:COmJalde8hOhik08OxNyb9lXIGQzz8LeePG3IwIgbFrgieUKXkaCz2fG8DP3+07VKmTcNL9ZYuPvjVQSB5Xqp49jfFEzU01wE8B9UwxNI5zLx/zzFXJFyfblwOaowIpLXl1eBBYjvTV1AzbAlj2Iak9kMlW6AcBjY7CXQz5jWtd/2gaemxcHLR624SHpADhIdjzATIjVP9FcejsDfCtxfApB/7whqVpaJL19jSel4w+A+u6ncAxp1EOx7hfFrSX3jQRne1WzJU8+pmtpM1WywrL4kT9TUONQaV9vlMMy6TQ3m3oF/BLn4GOtCntWXfRo05tRhQlHsA8hSVgDfGDf8SxB2JzZBCmYevgt02KiHMWrhUvQsYeGlU2vE64mX3YHeM15y/3frYJxmVf1OOO2fp064QPcRRjE+fkhrW7m2oOWpoTt/mdhmVHn9vKV4RF6TJIlVdYayr8o2TUh08/nD5m3JUkzw99qZD4XKAMVZYOC4KsY9fbLZboaFd/sSAud;4:gqcy8h0woTS4FOC2hXkM/37qqvCIeTjkSwo4QaBSsCVhVE9/hcdmL5lfREcS0vzETXqJ+nnSTGkTKk+3EKEbHQNT2xDmnzarT84JKi/PkEv4uoRQukosPZo8lbEVsO9ZXeIIojKSsA83/hxgm/FlGaFGVCBJJxowXofcrBwZ+/Z+E+JbabUSHI+li+/KQgeFaNM2KPMYGMw3doTdx16hy7rCWfbVGDtxORlSXBzZKtZxEz9oa43tlrpkgcSFZvNWKGiXmEt6CBgY/g/SxPajZyoes4PVL//clwsCme5edaJrxGpb8O7DI1oa4uxILu6U X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(20558992708506); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(8121501046)(5005006)(3231023)(2400081)(944501161)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041288)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:BN6PR12MB1137;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:BN6PR12MB1137; X-Forefront-PRVS: 0558D3C5AC X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(376002)(39380400002)(366004)(396003)(39860400002)(346002)(199004)(189003)(68736007)(8936002)(386003)(25786009)(76176011)(52116002)(31686004)(3260700006)(105586002)(36756003)(478600001)(72206003)(47776003)(77096007)(86362001)(31696002)(26005)(4326008)(53546011)(6116002)(3846002)(230700001)(66066001)(5660300001)(6666003)(110136005)(65956001)(65806001)(23676004)(97736004)(2950100002)(6246003)(50466002)(7736002)(316002)(54906003)(2906002)(16526018)(2486003)(229853002)(90366009)(16576012)(58126008)(106356001)(64126003)(53936002)(83506002)(65826007)(81156014)(52146003)(305945005)(81166006)(6486002)(8676002)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1137;H:[10.236.65.116];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjEyTUIxMTM3OzIzOnR4UGNyTEZyZVpTcURBUWtpSTY4NkJ1YkJG?= =?utf-8?B?MUNMTE9VKzI4OWZIRlZ0QjBHK2gzclpUTmFqQ0ZCV2F4YmE3eGlVV3ViTlN1?= =?utf-8?B?TTU2bGRucHdNUVhvay9aSjA2bTdqYUZRZzc2QVBhVlQvdmkycmJBT1RDZnJY?= =?utf-8?B?RWtVT1Q1c3B4MzlzUEQ3cVZHa3ZRTHlNVGo4WjRmSUJneDREbmRKNjltQ3RX?= =?utf-8?B?Z3BvTjZaSzBTeWY3cEdkYkFmS2lvcXBuNmd0QkpmNUk1OXRFM3UxajZyT0FL?= =?utf-8?B?TnNsTXdJdCtxM3E0UkZSSGZoNFlsSzFrUWROR2lzcXVOeURsV0MvU3pVRFZS?= =?utf-8?B?b2g0NFZQWDRHWkZpMW1WMThjVEhhOThtQmhFNjNiRTBRUGtBaEo3VFJRT3dK?= =?utf-8?B?YUs5S0JSekx1VkFVTmxYVzNVNVhZQ3lmVlhRTjdXYW82ZnN6ZlJOMERiQ2Jn?= =?utf-8?B?OXd6QTVrZDhIRUltZVV2ZWdMdE5BRzY3OVhITGxtM1hmZm9wcE1UZ1IwYWNV?= =?utf-8?B?QXhNSG9rTGJMNGR1ZTd6S3NUdmV1VGUxejlobld5aFJSNnhTa3RjaVZHeThw?= =?utf-8?B?UHpWYmM4c3N0a1Z2aWdBWlFMRmt0MG44Rk5iQXRzS1hZVDdkeXZnTUlXMnpS?= =?utf-8?B?SlBPaHJWTlpEd0lINUFnZzVyUkRjQlYvZnFVQkRLQ2l1cVlLSm84VTlUY21v?= =?utf-8?B?eVo3akRDUVFhVkhLd1pYZXY3T3ZteTVSZnNmZVM4VDI1dEtWcXNyRklTbHJ4?= =?utf-8?B?RUttZ2VmSFFORmlTNHJqeGx5Uy9KUlVmcWRLck9Zd0k3NEpUUDlMRndVbU05?= =?utf-8?B?c0dqVlJJZHN1eExFQ2xobVhFQkg1WmZFam54SDRDUnNhY0dRcHNqa2F6MFA1?= =?utf-8?B?dVRGS045QnNvMmRLU1JJMGZxNTBJbDgzQ211UjJLUUx6bjdlVXRSd1BYWHZV?= =?utf-8?B?WWR2bS90Ylk4bFF5MFdieVNlVWJFVWFCZHRhdXRtcjEvQjFSUWJGZVgxbWRa?= =?utf-8?B?eURYNFFSbkljSThjMXhrL1FsaUxwTXV1aFY2UXNRMFhLUVQ5OHRibzNSQnMy?= =?utf-8?B?M2tPWkd4eTY2Tjh6c1FzSlhoandma2hOWFBPbUhwNVljbWJya0RseUxTSTNY?= =?utf-8?B?NW5uWlplZ3o3SWcwcWE5WjJtaG80azI5QWdNNXVJNm5XTTBzOEhXbW8yTzFD?= =?utf-8?B?aHM3UUgrNExuRVNuZERnTGlNa2UvNzlubGxNU0lKejJOakJJWU5Lc2xKSi9t?= =?utf-8?B?bUxLa2R2OHBxRUhnVjdUQnJBY2FwWG1IOHk3UFhUZEQxa2ZSbk1uVk9JYURy?= =?utf-8?B?ZkJqWlQ1Y3QrR05BeTMranVwR3NYR3pBaURWUFVSdi9aQitZVmgycEI3RlJW?= =?utf-8?B?czZxS2lRZEJESVNGeEZDT0E0N1NGVHNhZjBSZmE4RnpEUm05U2JZeWJQVlRI?= =?utf-8?B?R0lZdnJYMmFvdU11NkI0N0dNRVBOVnkxanFNUVlTMWhyTWdlaUNLeGNyTTdY?= =?utf-8?B?WGN0Nkk1TS9yc3NjaVVYZ1BNS0tSL3FWbmdmU1RiSzlES05NcmxGZ1RFUU4w?= =?utf-8?B?dnlOUkdxWk1UMlNwUVhEd0pSYWE1VkdURkJtMmpackV4dTM5WmZaQTJiMmxD?= =?utf-8?B?SFRyMG1qRVpZUDJOSjVUWGw3S2thYVBPbXY4MDVuQmJQcTRLVUoyekNuMEIv?= =?utf-8?B?SHd6c1ZQbzNuNmpjSVZjRVFwcy9MVXJ2OTVvRVNmeTZDREQ0a3JFREVYdkdG?= =?utf-8?B?K3YvZjJvdlU1R3YyZ0ZaWWJEQWN4ODNzOGlHRlRjYVRuMjBDcVZwcVZhb1R3?= =?utf-8?B?eEhTWGFSRFY2ZHpOSEZCaGF4RUZObEtCRUc3d2MzeEZNcWJHSExhOEZHSkZO?= =?utf-8?B?L3FUcHdCNW5JbjZIbjlkUjRJeUJHWXZyaitxWVhxNlk1VGxuWThJY1dKa0FE?= =?utf-8?Q?7Iihv4aGfl2fSDKjSWT38SCzcZrsxI=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1137;6:gV4BOld72nyqZuvrHpjq5xhEjyktsjCc3mdAbirWISupD8+6FWLRdaIls1vzP9XXfnXFTi5eB9Yo2fYxjGBReb9Oqd+QzTlUIshwf5heBMnATs6f56bR1L1rVnGJyXP/4si7KP8GHHZp5SR8ZVbWIlxEcr6gwGKtqEg9P2ntRwtK8Af4zODfoFeViNUdHU1C+xGPiPzz/VURmxX2l+72n63/1ZA3FURxVcPyg5c12ZVRYTn6I1nck+xWM27f6Dpep7+rPY5Rw3cPv0oHqW5sJMkKdKx4yq9KtFx4eWA8Y02YlBmdg3NqMpPupUd/mkVBmohWxoViPCroOHFsi6XbIz8EhbCvwPVKlHzove6+AHM=;5:xpwBZeAOc71rCGSR1QBC5Dp+DoNjcqZ/usE+RhMSxDpLTgsab5k0wpaSWr+ONZqzEfWMCeRdNNM/MxneAgmdp2to3OeQpp9k5bnqp427hboajas1uxJ4od6s/S9xNr5QXB9x0EZGNsBRBENjZWaaWgxsSATTgfenAwzFydyquHo=;24:gU8dDXflm3IfP4i0ghTmBr2uH2Z+XAEHUe8M+Hm5vlcR7XW+Yc2LCuTJOdyHIaOkVIQoLXztYD9qNy4ZsWzGxomYULs2StsTuIjy1nBJJ5E=;7:XrcwWQbVa2sFyzUp6bR74rr8aCEnS+UoocrW3cQdXf4Jlb7vSeLPdqZrWhh+xI9RLTw8SWrAUdMntskVxfN6Su99dcVGdSwA7s7golW3h/JtnpaWdRhuKdzJzm3FSbziae0KPahDH1v+XxeBChvLhJc7mLWQZr+iqxrzD3UYRf5l40MsnuGA4DuWUObqRpMdywqqJ5fV9ua8tYuhA8jdH8urSrYGBbiPu8kGMXVG11sMeCKq4wq8qiwsFmuaZeXM SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1137;20:wXbu2N1JzYNbWxpsqQ289lyRO5nELEHB/VDbpXA7bs58jxM4sBRlBSHO2H9abQBdr5MiMlb8rwJqF5uvMQ/kgTiHiqhJifiwJMa389KiCIdL+wTGimmC1qy9pBIEzEQJJOqZcV4X1+TzHcMT4/fNmVfNnhqH5pTmpGVIvV7b7qWyu4ZH4TSfdRAjv0Zb4nnHnJjs61FDdkaA1PwPUqCrWZgcX+qPfujlFOZvCjNymEiYMKx8tI5zNvWctcFNj4aF X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2018 04:14:02.8178 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 619188ca-5188-4682-8799-08d55fbc3df1 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1137 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/19/2018 8:38 PM, Linus Torvalds wrote: > On Fri, Jan 19, 2018 at 5:23 PM, Laura Abbott wrote: >> >> Fedora got multiple reports of an early bootup crash post -rc8. >> Bisection showed bacf6b499e11 ("x86/mm: Use a struct to reduce >> parameters for SME PGD mapping") . It doesn't revert cleanly >> but if I revert the few other changes in arch/x86/mm/mem_encrypt.c >> as well it boots up fine. > > Odd. I've tried to read through that patch three times to find > anything it actually changes, and I can't find anything. > > It looks like that patch should have absolutely no actual behavioral impact. > > But clearly I'm missing something. Can anybody see what the mistake in > the conversion is? I'll take a closer look at this, but it really shouldn't have any effect, especially on a non-AMD box (which I'm assuming this is?) and with memory encryption off by default. Thanks, Tom > > Linus >