Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: ipv6 redefinition build issue with 4.15-rc8
To:     Jonas Bonn <jonas@southpole.se>, Daniel Wagner <wagi@monom.org>,
        Neil MacLeod <neil@nmacleod.com>
Cc:     connman@lists.01.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Weimer <fweimer@redhat.com>
References: <CAFbqK8m9grXyAV_mWSzMGS12Mikekg6NsOM-B7pkXiXpnWVgZg@mail.gmail.com>
 <794202f5-e993-444f-f3fd-891276795926@monom.org>
 <b4f9df2d-09cb-b9ba-4742-1957c08a5a51@southpole.se>
 <CAFbqK8mtYtgLiviaBQvk_hT+yMr2VcNZux_5+c8gN36iCeCCiA@mail.gmail.com>
 <CAFbqK8=k0F6Xszz-nu8ECs17ckLiO3h1E_X2SV+cabBUOZxxew@mail.gmail.com>
 <0d51f6a6-0edc-1c18-3412-5a37cdc83873@hauke-m.de>
 <ba894de3-f968-52c5-6504-0e0d21b385a0@monom.org>
 <bff0e61d-ed89-d907-66b5-0bc30a1e36fe@southpole.se>
From:   Hauke Mehrtens <hauke@hauke-m.de>
Message-ID: <144ac8a0-316c-c673-ea40-e220b1600d14@hauke-m.de>
Date:   Sat, 20 Jan 2018 12:11:46 +0100
MIME-Version: 1.0
In-Reply-To: <bff0e61d-ed89-d907-66b5-0bc30a1e36fe@southpole.se>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 01/18/2018 09:49 AM, Jonas Bonn wrote:
> On 01/17/2018 11:34 PM, Daniel Wagner wrote:
>>
>> On 01/17/2018 11:20 PM, Hauke Mehrtens wrote:
>>>
>>> Do we want to do any changes to the kernel header files? I do not know
>>> of any clean workaround to make this work, we can probably hack
>>> something for connman, but I think it is not worth the trouble.
>>
> 
> Well, it's not _just_ a connman issue, even though it apparently only
> shows up there, currently.
> 
> The problem with the kernel patch is that it now pulls in lib-compat.h
> which causes problems if it appears before netinet/in.h.  The following
> code is sufficient to show the issue:
> 
> #include <linux/libc-compat.h>
> #include <netinet/in.h>
> #include <linux/in6.h>
> 
> int main(int argc, char** argv)
> {
> }
> 
> lib-compat checks if _NETINET_IN_H is defined... it's not.  So it
> defines __UAPI_DEF_IN6_ADDR.
> 
> Then netinet/in.h checks (via bits/in.h) if _LINUX_IN6_H is defined...
> it's not, so it defines the struct in6_addr (and others).
> 
> Then linux/in6.h gets pulled in and redefines the function because the
> earlier libc-compat check told it to do so.
> 
> If you comment out the first #include statement then it compiles fine.
> 
> libc-compat has, as you say, a requirement to be ordered after system
> headers in order for this to work... that doesn't feel terribly robust.
> 
> Anyway, the bug is probably in the glibc headers that are not checking
> the __UAPI_DEF*'s but rather using another broken heuristic... right
> place to fix this is probably there.
> 
> /Jonas

Florian Weimer said here "A lot of combinations are broken, especially
when kernel headers are included first.":
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1411192.html

That was on a older version of these two patches:
https://www.mail-archive.com/search?l=linux-kernel@vger.kernel.org&q=subject:%22Re%5C%3A+%5C%5Bmusl%5C%5D+Re%5C%3A+%5C%5BPATCH+resent%5C%5D+uapi+libc+compat%5C%3A+allow+non%5C-glibc+to+opt+out+of+uapi+definitions%22&o=newest&f=1

My understanding is that you should include libc headers before Linux
headers, otherwise you *could* run into problems. There are some
workarounds done to also support including Linux headers first, but they
are not working in all cases.

Hauke