Received: by 10.223.176.46 with SMTP id f43csp898227wra; Sat, 20 Jan 2018 06:57:21 -0800 (PST) X-Google-Smtp-Source: AH8x2248N+1Axpr3A92vIHOnZssddvrRN7PuzMP01nUpigscNmAgkZvoMKg8S+hezQjv0x7dkEMX X-Received: by 2002:a17:902:1683:: with SMTP id h3-v6mr1030162plh.0.1516460240940; Sat, 20 Jan 2018 06:57:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516460240; cv=none; d=google.com; s=arc-20160816; b=nPdotnNPEy8l10ZZ57yBR2T3kThnndEBMKwExZcRCjguJG6NEi9ipGHXZPzFby6ygP 1PNUIb1Itc40sfBzgQ1JVXgvDngP0B3LvgSWRo8qDGMnNs+5tI1jGArkV+VywwCkkqZd NnxtRGnftEhqxJEt8WL1uC0xGXfyPl2Mis7uDnciJwRpk6KqNxjU4ZZ2ieOloYAO0Gd8 1e2+JmzEzC04LchM0V7MZ8YHPz7HvcA84I4GjQ20FfWoNIXi0Ba1aAphfQ0j6IcduUko udiDv3yGfT9xT3WJ3sk5ro7nSQOXHVkc0Um0kl/98ObH5+bFa+/4OHBsMQccjzoC0OkA UQ9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=VyUuAdV3Pj4zYiYxJuHr+6/XizZq4FlrF0Ry6rW1gA8=; b=Verrv6fWgx6IDBQ6FelMoqq0KKbG+qyH1RMPyPQlfeY3tGzoxv9tx6uy6UxcZJ3gZ4 JCx/HWC9GQMbkEna8LziGrE7iYlx26ODf/WJ8kMlJu4z9qgVWazsOwyelGefxuDxTWYo 2BvmzbEuWCn2/n2iZjQS8WFntnq+dT4u5XF7EUvBIpEqScFZ0eqZwnaGQF67+xBY74i4 4eima8F8IlPX8qa2haVIhfs2qi1sXj35P4DigVIMJiWEfNBRIKdMZb3YHo9CdhwbSGhQ MRreCnMU2/nclmKv5Gh+qJyAJitZyRp9bUHeW4RoeSUrVy5EQewFgLFFa3hdhhV6JqQ2 0VlQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=sourceforge.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p3-v6si1757515pld.39.2018.01.20.06.57.06; Sat, 20 Jan 2018 06:57:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=sourceforge.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755590AbeATO4D (ORCPT + 99 others); Sat, 20 Jan 2018 09:56:03 -0500 Received: from mout.web.de ([217.72.192.78]:50964 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754051AbeATOz4 (ORCPT ); Sat, 20 Jan 2018 09:55:56 -0500 Received: from [192.168.1.3] ([77.182.145.92]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LopeB-1fI00M0mvD-00gnnI; Sat, 20 Jan 2018 15:55:41 +0100 Subject: Re: [PATCH] Intel-IOMMU: Delete an error message for a failed memory allocation in init_dmars() To: =?UTF-8?B?SsO2cmcgUsO2ZGVs?= , iommu@lists.linux-foundation.org Cc: David Woodhouse , LKML , kernel-janitors@vger.kernel.org References: <20180120133452.GB28161@8bytes.org> From: SF Markus Elfring Message-ID: <6b452dfb-b2fc-2417-26b3-bbcdf11ed06f@users.sourceforge.net> Date: Sat, 20 Jan 2018 15:55:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180120133452.GB28161@8bytes.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:oBpJw1XvvseX6Ie9eQ7VOSwFiamd53vNmnLVhCE/2kFByv58SEY AxLcgGoR5SA+4a+dR2v3K8/q7gYsF9znBiqA4EpkvAnOj0IbQZuajmrs66MyXrTeCNBzK3h R9gFLe8KCZz+fjoMhZxUQ/vGZejg0BvaSS9zzLvE8jQRYTUHM4cQUr4zzDDlW0DRTOcH0pi nYbKDTets4sE1DmBF5TYg== X-UI-Out-Filterresults: notjunk:1;V01:K0:cFZefSgTqZU=:JxTtalgb6oB5OSgkKPKdVv Yp8ETSH5tkyNAOhWM/agmgWMC24m2MqU7QhekoryBj8nVR7Pj4TXQ8fxfoMNOkB2fo5hwhKdt pWk6kRJTola0jlgCL2Jl3hd7KAae5tETEsi3rAvMYTkYvAMnU8vY8d2AHpp+mTsKPg0CXEQRW xb9ZQwcHzHs9iuDSlVGrXRyaQtgpCt2Na42zJEuVMNODKW2lxui/fQHKOx7MOXSMLluFvpDTt R/royiomKuNxVQxZZeD1gBAW5cFoFAKiR/X6VfppTjGJzKitGmfYXRf2Y+470tPV6VapnLCn2 lJxTSmpQgfwOE+5mX4JTH9Z/y6zqGuyMfqRzxju90VlSPq2/gDmyrkvasIWccneWmILPIDQOQ vyK2gaWNNCmLLbd/a898xxQaxIQ/CaWnBeA59OTn6CkKBcAkhbu70AXt3vdt5nOZVdcAwqcm3 y9Vks6ARlSgMk4SANSEgG2XMKhhkWX1YAnmgUJqzlum6hYPosLCj11YttGGbFMTsf6UV44JlP ew3ROBrZDXqA8ERfQpMSdEmeE1ewKWCmCj1xOXm8tT50Zn+a0Y5N8+raxObcmIDmEyFVHWh+B qRLLlMhCmfk0c+eBlv3sHYYxc7P1np1IqcHqOYd8VV6mmPrhmy1lXfrI71KLkl1qUy4p+BJEb NTdgGiKitoiWAhkSAwdtPG+Jp3ooDsFes2nOuhZ9LG5G88nyYqH5J7khAghUGi1Eb7NINBJod SzFh14Csj/Jn4cUEbWs9bZqX0ihHeTk9qBNnQS1kTkHwBuKaeKeTLYcJ7u5XJTMQiiowRGUaw 1khwbI+/IiJa8Gj5t1cTfFZ2C1yjphTtWijId0d50V4CDkkK5s= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Date: Sat, 20 Jan 2018 13:51:49 +0100 >> >> Omit an extra message for a memory allocation failure in this function. >> >> This issue was detected by using the Coccinelle software. >> >> Signed-off-by: Markus Elfring > > NACK on this one and the other two IOMMU patches you sent. Do you need any more background information for this general transformation pattern? > The messages give the user/developer useful information about what the memory > that failed to allocate would have been used for. Do you find the Linux allocation failure report insufficient for this use case? Regards, Markus