Received: by 10.223.176.46 with SMTP id f43csp1072362wra; Sat, 20 Jan 2018 10:11:38 -0800 (PST) X-Google-Smtp-Source: AH8x226ktFPoTW3oBCxKxb5gAqsQOmmrWphttCj+jvBTfy98mtN8tLB6HtMD9Gy/aT/HdHUHH2E2 X-Received: by 10.101.64.67 with SMTP id h3mr2675809pgp.168.1516471898822; Sat, 20 Jan 2018 10:11:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516471898; cv=none; d=google.com; s=arc-20160816; b=EaRU2xl05j9+7KGPIHxvjF2nHS6OhSVSlKQVpN1nfSD+41pLypT1O5d2nfrtRmXjmg dz1NB6ym31iEkX/ARA4Hr0UJojOR/dV/GMNG3XxFNQndeNLSFc6OVQfN1JC1LioKACzu rYVKFMprT+vxZEmsTo7XyZJ0B2qkASu724PqedbQBuZAOzXgfzx3o2tswiUQk4X7ZNZe yfBJv7cZwlilpcUvzX84AwpV2qFKmvKeRlrGGWZp+h8BfWRNDG1dAKh1zYSFWcd2QUwh nbe6MOfukjx4sXQCNSqL80+53RttmAnamSG0Lpx//V7WZEt2XK07uvZCFLCATguGpXSE hqnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=HdcNk5qNjPKWxO0K8a+TUK6WMjn2B1G/My/emAg2uI4=; b=byrvqyzC/35sA+z7NSxzl2xr5rRMYlDbZrAOZR0e74+Xwws6PEYHXmRvLx/rFvBum5 /68OyrWOu5rqh+VNIG9hylUmZZ7kmp9ZHOdBeZDNHi4YjDtmuq1wVxf0eyCKqlCl366z nZUwZQno0DBNGWQjDWGkRNxyuDvgLlwbAcQzNkvswP793VHYc8RbQzJ6Lv3SMUapv/Ud 9tPG8UZs/lHjaIrzDi/pQHl+LP0DkjD/ZeQZIndXE8IvCfOUOGjZ7NEegXmuFtIRoCn5 tqOtYPt1n9BWAsO+43uYQDBKXEXwAbbDKbwTkILXKzL3NK+YELwXBCk04aC6hpQRNruE VMHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.de header.s=amazon201209 header.b=KcoJBCK6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a15si10779116pgn.436.2018.01.20.10.11.24; Sat, 20 Jan 2018 10:11:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.de header.s=amazon201209 header.b=KcoJBCK6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756597AbeATSJb (ORCPT + 99 others); Sat, 20 Jan 2018 13:09:31 -0500 Received: from smtp-fw-6001.amazon.com ([52.95.48.154]:41035 "EHLO smtp-fw-6001.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755008AbeATSJW (ORCPT ); Sat, 20 Jan 2018 13:09:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1516471762; x=1548007762; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=HdcNk5qNjPKWxO0K8a+TUK6WMjn2B1G/My/emAg2uI4=; b=KcoJBCK6N00l35lLEtNzdWNM8uSU8pN/8/0eHyr4KsAihL38aZT1ZIrC 1VUpakb65SakMPvPx3l4cjBxJU6FcReiGKiqgg2Ohom7FxXPlCwDi+cLP pjDSGUBA1SwdL7TgEugssnh+1qk+IQ+q4AMyE+/P+YlxFxVe6SSuHcy6P 8=; X-IronPort-AV: E=Sophos;i="5.46,387,1511827200"; d="scan'208";a="328343537" Received: from iad6-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-1a-7d76a15f.us-east-1.amazon.com) ([10.124.125.6]) by smtp-border-fw-out-6001.iad6.amazon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 20 Jan 2018 18:09:14 +0000 Received: from u54e1ad5160425a4b64ea.ant.amazon.com (iad1-ws-svc-lb91-vlan2.amazon.com [10.0.103.146]) by email-inbound-relay-1a-7d76a15f.us-east-1.amazon.com (8.14.7/8.14.7) with ESMTP id w0KI95m2080593 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 20 Jan 2018 18:09:08 GMT Received: from u54e1ad5160425a4b64ea.ant.amazon.com (localhost [127.0.0.1]) by u54e1ad5160425a4b64ea.ant.amazon.com (8.15.2/8.15.2/Debian-3) with ESMTP id w0KI92Ya011333; Sat, 20 Jan 2018 19:09:03 +0100 Received: (from karahmed@localhost) by u54e1ad5160425a4b64ea.ant.amazon.com (8.15.2/8.15.2/Submit) id w0KI92vM011328; Sat, 20 Jan 2018 19:09:02 +0100 From: KarimAllah Ahmed To: linux-kernel@vger.kernel.org Cc: KarimAllah Ahmed , Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , x86@kernel.org, kvm@vger.kernel.org Subject: [PATCH] kvm: x86: Use X86_CR4_PAE instead of X86_CR4_PAE_BIT while validating sregs Date: Sat, 20 Jan 2018 19:08:36 +0100 Message-Id: <1516471717-11197-1-git-send-email-karahmed@amazon.de> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the mask (X86_CR4_PAE) instead of the bit itself (X86_CR4_PAE_BIT) while validating sregs. Cc: Paolo Bonzini Cc: Radim Krčmář Cc: Thomas Gleixner Cc: Ingo Molnar Cc: H. Peter Anvin Cc: x86@kernel.org Cc: kvm@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: KarimAllah Ahmed --- arch/x86/kvm/x86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index abd1723..6f452bc 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -7664,7 +7664,7 @@ int kvm_valid_sregs(struct kvm_vcpu *vcpu, struct kvm_sregs *sregs) * 64-bit mode (though maybe in a 32-bit code segment). * CR4.PAE and EFER.LMA must be set. */ - if (!(sregs->cr4 & X86_CR4_PAE_BIT) + if (!(sregs->cr4 & X86_CR4_PAE) || !(sregs->efer & EFER_LMA)) return -EINVAL; } else { -- 2.7.4