Received: by 10.223.176.46 with SMTP id f43csp1573175wra; Sat, 20 Jan 2018 23:20:04 -0800 (PST) X-Google-Smtp-Source: AH8x2272LIMod3LnKv2TSJWt7mPo37v4oj3Oauh+vb6V77Ls3vBeXLzmwM/2bUXE+Ec2n8w6Qaml X-Received: by 10.99.65.133 with SMTP id o127mr3948752pga.13.1516519204376; Sat, 20 Jan 2018 23:20:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516519204; cv=none; d=google.com; s=arc-20160816; b=xbK3bMdXc7SDrW2sxxcPg8uV79Mqrc7zhVRpIsndiNv2zJ4ZE6bBfH/Bd3c9FA2ihB dn4XZoZgUiJwdDwIMVci4jQ51GemiVcPbZS/bE6/RT26WNmHr6HSDBnWHJRUOMcZIODI u5OkX94EsMRt2FgfiDXXI6taXhaKSuttV/GVmdHfWv2fb2d5LID268Et+9UBND8/LeOS woLG8nCy9EJiV6gtQB7cBdkJISpco4eAe2XpRBWW4/drTNyGG5+iC1DE1xiQZ44c3OpF 17fMH291cDmqj4uhiZ1j4Gsqms1XnDdpX51sBI6m8hAD+L5PSslPlgHPz9kpCszGak+C y5iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=w/xKzbVgxC5lCq3B320yBT6lcwYXID/fLPvcZI7vgKI=; b=SjaM5kDi4XdMDRLEXKUIwVLHwXGUGqk5MhtQklcYEFDofhrvwk3S1Gf0w+vyypxhd5 A5StkisaWqvlMh5LYsSzNMWND+PjtB6/WqrXBsefsd0e+AfrSfTgUU79hi+iI2yI4tXl IcaKMnjWGNodijECMzSTkI4dEv+kH9AWaBCYKQX4MDKv9rY7ANjVrnJu987vDplhL7wT llCTAw14JZQ38NldU5TnG/88LcNV51wLX9jnDBa2mPN/38cyHvwb17ZZwNfXMK+a9e6Z Wy477fsCFW4YJ7dmpDD1x6q6/BHpziwiq1Cx9CSP3Q2Gb3MoE2jfUhXODE0WcepzahyW DDcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@8bytes.org header.s=mail-1 header.b=LXemxisZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f13si11621401pgs.423.2018.01.20.23.19.39; Sat, 20 Jan 2018 23:20:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@8bytes.org header.s=mail-1 header.b=LXemxisZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750933AbeAUHTH (ORCPT + 99 others); Sun, 21 Jan 2018 02:19:07 -0500 Received: from 8bytes.org ([81.169.241.247]:33576 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750847AbeAUHTF (ORCPT ); Sun, 21 Jan 2018 02:19:05 -0500 Received: by theia.8bytes.org (Postfix, from userid 1000) id 286A4219; Sun, 21 Jan 2018 08:19:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=8bytes.org; s=mail-1; t=1516519144; bh=50miEt1bqb4FJAl1o69xnyAAlISAeHSuJQhsin+1NF8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LXemxisZORNrNKhNr3HY2CWx2n4DiqQy064IaRKwGTBTm71mtf2+pqxsoL92UQPh9 1LY3Q765mjG9DKBdXUFNrB/bjw34GACpoH5LTDneqHPPAN01SRJ+agmoTolevMfVns C13lxncR/2KxvG+6uGvByUJmNvA2VI2qaTO0MpcKRzR07uFLWrw4poI85+uQsQF5ku d/IA0giPzZJLwKasQmcZlGLhW7zMWn4niYtNAVHcWIQTPIilSrGYmB2Jz+Ybs3w2i/ JCM5hpakXmGn4bWPYPHeu1zIkP9LQ9H2+MUhqOjONjHRZuO8r6QDTuTcsoqJVgkdHk RyJ1Pw7TCSLEw== Date: Sun, 21 Jan 2018 08:19:04 +0100 From: =?iso-8859-1?Q?J=F6rg_R=F6del?= To: Joe Perches Cc: SF Markus Elfring , iommu@lists.linux-foundation.org, David Woodhouse , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] Intel-IOMMU: Delete an error message for a failed memory allocation in init_dmars() Message-ID: <20180121071903.GD28161@8bytes.org> References: <20180120133452.GB28161@8bytes.org> <6b452dfb-b2fc-2417-26b3-bbcdf11ed06f@users.sourceforge.net> <20180120194004.GC28161@8bytes.org> <1516498672.24895.2.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516498672.24895.2.camel@perches.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 20, 2018 at 05:37:52PM -0800, Joe Perches wrote: > While Markus' commit messages are nearly universally terrible, > is there really any signficant value in knowing when any > particular OOM condition occurs other than the subsystem that > became OOM? > > You're going to be hosed in any case. > > Why isn't the generic OOM stack dump good enough? Because if we know the exact allocation attempt that failed right away, we can more easily check if we can rewrite it so that it is more likely to succeed, e.g. rewriting one higher-order allocation to multiple order-0 allocations. Joerg