Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1516575958.3417.22.camel@codethink.co.uk>
Subject: Re: [PATCH 4.4 39/63] net: reevalulate autoflowlabel setting after
 sysctl setting
From:   Ben Hutchings <ben.hutchings@codethink.co.uk>
To:     Shaohua Li <shli@fb.com>
Cc:     stable@vger.kernel.org, Martin KaFai Lau <kafai@fb.com>,
        Eric Dumazet <eric.dumazet@gmail.com>,
        Tom Herbert <tom@quantonium.net>,
        "David S. Miller" <davem@davemloft.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>
Date:   Sun, 21 Jan 2018 23:05:58 +0000
In-Reply-To: <20180101140049.154545057@linuxfoundation.org>
References: <20180101140042.456380281@linuxfoundation.org>
         <20180101140049.154545057@linuxfoundation.org>
Organization: Codethink Ltd.
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2018-01-01 at 15:24 +0100, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Shaohua Li <shli@fb.com>
> 
> 
> [ Upstream commit 513674b5a2c9c7a67501506419da5c3c77ac6f08 ]
[...]
> Note, this changes behavior a little bit. Before commit 42240901f7c4
> (ipv6: Implement different admin modes for automatic flow labels), the
> autoflowlabel behavior of a sock isn't sticky, eg, if sysctl changes,
> existing connection will change autoflowlabel behavior. After that
> commit, autoflowlabel behavior is sticky in the whole life of the sock.
> With this patch, the behavior isn't sticky again.
[...]

I think the getsockopt() handling for IPV6_AUTOFLOWLABEL also needs to
be updated, as it will now return 0 unless the option has been
explicitly set.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.