Received: by 10.223.176.46 with SMTP id f43csp2263951wra; Sun, 21 Jan 2018 15:40:44 -0800 (PST) X-Google-Smtp-Source: AH8x226ug48UOxWHbE7nB/UdIjQGEgyz4hKNWfgvSJMnswzLIa2u/h3sTRDUpwmVjQExmo2OaXb9 X-Received: by 10.101.70.15 with SMTP id v15mr5559293pgq.327.1516578044668; Sun, 21 Jan 2018 15:40:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516578044; cv=none; d=google.com; s=arc-20160816; b=acrKdlNFA4Nfuz+wT38hEbJDBcbsHa9o1Ay/QUbROd3F9PF7wZBRwsJ7G6dPad1ja3 3HrvaCEOqFD5NBSZZwAfOaUR3UkN2E4Q6vg6GP/vx/4O44C1GKXEWcT4NP/uJ3LKZQ9q dVn47ePiVTFLIZ9dDWvLhiztoomT198DCHUV5CPK3Y+/qER5XqdJ/fBq2WrIZt7W3X56 XBFpZv4GNH/lPUnvWYR0TlomC9JS/JijFrUbSnDtXuhaFelPJgniMK6qKJd9FMyy6DOo I2c3dEEGwOC5EAg+QdTRse/PFKDI2/gUtd91iETK0LhBAj/8nmJHyXCLMctizemhmKtN ZBpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=Z+G9kTNJjXVYDOYtpBw9j7B2KhaukZSanOsy6Do14b0=; b=X72sGqWBXuIfV9H1Bwu/V8evuNrNORS6UEbgygly8FAHHggdqmPJGsbFnmLALmTNRC Iz2X1sBkqtYJGSKsbC2yH+WsVZZggufqIS7oWpm0tn3whL8p1KT81sHP1BwY8malnhCS HVZ0Vau3MBb6RVrlG35qZr/y7KVXA/bwJV7BjinfE6ybQ//tkAxWLXqkSpFN1nRBDAQr cUktNdErafCmTbzGSlkt6GnJuUSb7mtr4PUHcejRrxGGqUa8xbjqKgjhhQ3MNC7qjc3U 27uihlJ/nfLUjWi1SaUp3dYLqgWsfqi6gkZW+XhIDdRfPh0ytWDZ8X0f0bgl52wNv+Cz HY3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w16si4087000pge.666.2018.01.21.15.40.19; Sun, 21 Jan 2018 15:40:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750973AbeAUXjt (ORCPT + 99 others); Sun, 21 Jan 2018 18:39:49 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:43304 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877AbeAUXjs (ORCPT ); Sun, 21 Jan 2018 18:39:48 -0500 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.87 #1 (Red Hat Linux)) id 1edPDD-0007Ax-Ez; Sun, 21 Jan 2018 23:39:43 +0000 Date: Sun, 21 Jan 2018 23:39:43 +0000 From: Al Viro To: Davidlohr Bueso Cc: starvik@axis.com, jesper.nilsson@axis.com, akpm@linux-foundation.org, linux-cris-kernel@axis.com, linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: Re: [PATCH] arch/cris: use get_user_pages_fast() Message-ID: <20180121233943.GO13338@ZenIV.linux.org.uk> References: <20180121225929.11782-1-dave@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180121225929.11782-1-dave@stgolabs.net> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 21, 2018 at 02:59:29PM -0800, Davidlohr Bueso wrote: > Since we currently hold mmap_sem across both gup calls (and > nothing more), we can substitute it with two _fast() > alternatives and possibly avoid grabbing the lock. > > This was found while adding mmap_sem wrappers, and was also > previously reported by Al: https://lkml.org/lkml/2017/11/17/777 See commit 9a949e8ff92246c0753b2805c2a001cb991fffe5 Author: Al Viro Date: Sat Nov 18 14:37:46 2017 -0500 cris: switch to get_user_pages_fast() no point holding ->mmap_sem over both calls. Signed-off-by: Al Viro in -next...