Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Michael Kelley (EOSG)" <Michael.H.Kelley@microsoft.com>
To:     Thomas Gleixner <tglx@linutronix.de>,
        Vitaly Kuznetsov <vkuznets@redhat.com>
CC:     kbuild test robot <lkp@intel.com>,
        "kbuild-all@01.org" <kbuild-all@01.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        =?iso-8859-2?Q?Radim_Kr=E8m=E1=F8?= <rkrcmar@redhat.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        Ingo Molnar <mingo@redhat.com>,
        Roman Kagan <rkagan@virtuozzo.com>,
        Andy Lutomirski <luto@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Mohammed Gamal <mmorsy@redhat.com>
Subject: RE: [PATCH v3 3/7] x86/hyper-v: reenlightenment notifications support
Thread-Topic: [PATCH v3 3/7] x86/hyper-v: reenlightenment notifications
 support
Thread-Index: AQHTjve0/syLYf1/CEOWlxOZdVplSKN7AKAAgAAHVJKAAWAhgIACtaFg
Date:   Mon, 22 Jan 2018 01:22:21 +0000
Message-ID: <DM5PR2101MB10309A7D99F89B5AD8AB1343DCEC0@DM5PR2101MB1030.namprd21.prod.outlook.com>
References: <20180116182700.1042-4-vkuznets@redhat.com>
 <201801191841.QZ26OYif%fengguang.wu@intel.com>
 <87o9lqdt15.fsf@vitty.brq.redhat.com>
 <alpine.DEB.2.20.1801200846210.1998@nanos>
In-Reply-To: <alpine.DEB.2.20.1801200846210.1998@nanos>
Accept-Language: en-US
Content-Language: en-US
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=mikelley@ntdev.microsoft.com;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2018-01-22T01:22:19.5501850Z;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure
 Information Protection;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic;
 Sensitivity=General
x-originating-ip: [24.22.167.197]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;DM5PR2101MB1030;7:UEPm4Al0fTrNLbvNyO0ajntytD/aujSS53SVww71WhNJyuQs95fLqRCXp/YtNYA4DkHC8zJPaBsxEL54+w4yswNhdlN4i2IOZTcNC0b9vLO6fg8StWTF0nN3xZ5jhqfalYnR8yIwPpqEHMMbM9EAp8fHv9wv91hyjDREIUOPpD3JQUXuJ7deq1E1kNu757gHDAz4+OCwLpmpU5KDPGhf6DiCuU7lYdFbmJedL+7kV0wTOsbb4x9BNw5VlsjeWIsh
x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR;
x-ms-office365-filtering-correlation-id: 15217081-a066-470b-56a7-08d5613695ce
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(4534125)(4602075)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603307)(7193020);SRVR:DM5PR2101MB1030;
x-ms-traffictypediagnostic: DM5PR2101MB1030:
x-microsoft-antispam-prvs: <DM5PR2101MB1030207D94DFAD047CDE5790DCEC0@DM5PR2101MB1030.namprd21.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(9452136761055)(189930954265078)(219752817060721)(228905959029699);
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(10201501046)(3231046)(2400081)(944501161)(93006095)(93001095)(3002001)(6055026)(61426038)(61427038)(6041288)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123564045)(6072148)(201708071742011);SRVR:DM5PR2101MB1030;BCL:0;PCL:0;RULEID:(100000803126)(100110400120);SRVR:DM5PR2101MB1030;
x-forefront-prvs: 0560A2214D
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(346002)(39380400002)(39860400002)(396003)(366004)(199004)(189003)(13464003)(53936002)(9686003)(8676002)(6306002)(305945005)(345774005)(6436002)(15650500001)(55016002)(7416002)(5660300001)(81166006)(7736002)(74316002)(229853002)(105586002)(8936002)(106356001)(81156014)(33656002)(68736007)(2950100002)(86362001)(2900100001)(3280700002)(3660700001)(6116002)(5250100002)(5890100001)(10090500001)(966005)(4326008)(6506007)(2906002)(10290500003)(99286004)(66066001)(6246003)(97736004)(3846002)(110136005)(22452003)(76176011)(26005)(7696005)(86612001)(54906003)(316002)(72206003)(102836004)(575784001)(25786009)(14454004)(6346003)(59450400001)(93886005)(478600001)(8990500004)(53546011);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB1030;H:DM5PR2101MB1030.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en;
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=Michael.H.Kelley@microsoft.com; 
x-microsoft-antispam-message-info: eMZIO2f0vv9Pe3rZOz0YhgjJaQY9hI0Ef6DwAIaDws/gsrFujRVAJRrb1AUB4RETrZLHkJuLofkWQfUH12tZxA==
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15217081-a066-470b-56a7-08d5613695ce
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2018 01:22:21.0548
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1030
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 19 Jan 2018, Thomas Gleixner wrote:

> -----Original Message-----
> From: Thomas Gleixner [mailto:tglx@linutronix.de]
> Sent: Friday, January 19, 2018 11:48 PM
> To: Vitaly Kuznetsov <vkuznets@redhat.com>
> Cc: kbuild test robot <lkp@intel.com>; kbuild-all@01.org; kvm@vger.kernel=
.org;
> x86@kernel.org; Stephen Hemminger <sthemmin@microsoft.com>; Radim Kr=E8m=
=E1=F8
> <rkrcmar@redhat.com>; Haiyang Zhang <haiyangz@microsoft.com>; linux-
> kernel@vger.kernel.org; devel@linuxdriverproject.org; Michael Kelley (EOS=
G)
> <Michael.H.Kelley@microsoft.com>; Ingo Molnar <mingo@redhat.com>; Roman K=
agan
> <rkagan@virtuozzo.com>; Andy Lutomirski <luto@kernel.org>; H. Peter Anvin
> <hpa@zytor.com>; Paolo Bonzini <pbonzini@redhat.com>; Mohammed Gamal
> <mmorsy@redhat.com>
> Subject: Re: [PATCH v3 3/7] x86/hyper-v: reenlightenment notifications su=
pport
>=20
> On Fri, 19 Jan 2018, Vitaly Kuznetsov wrote:
> > kbuild test robot <lkp@intel.com> writes:
> >
> > > Hi Vitaly,
> > >
> > > Thank you for the patch! Perhaps something to improve:
> > >
> > > [auto build test WARNING on tip/auto-latest]
> > > [also build test WARNING on v4.15-rc8 next-20180118]
> > > [cannot apply to tip/x86/core kvm/linux-next]
> > > [if your patch is applied to the wrong git tree, please drop us a not=
e to help improve the
> system]
> > >
> > > url:
> https://na01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub=
.com%2F0day-
> ci%2Flinux%2Fcommits%2FVitaly-Kuznetsov%2Fx86-kvm-hyperv-stable-clocksorc=
e-for-L2-
> guests-when-running-nested-KVM-on-Hyper-V%2F20180119-
> 160814&data=3D02%7C01%7CMichael.H.Kelley%40microsoft.com%7Ce95c66107da644=
6826830
> 8d55fda2c2b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6365203130627776=
23&s
> data=3DkAXl3mLVUdJi%2BsB4Ub0fmUHQfl6NuUDjW%2FAY9%2BFLZE4%3D&reserved=3D0
> > > config: x86_64-allmodconfig (attached as .config)
> > > compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
> > > reproduce:
> > >         # save the attached .config to linux build tree
> > >         make ARCH=3Dx86_64
> > >
> > > All warnings (new ones prefixed by >>):
> > >
> > >    In file included from include/linux/kasan.h:17:0,
> > >                     from include/linux/slab.h:129,
> > >                     from include/linux/irq.h:26,
> > >                     from arch/x86/include/asm/hardirq.h:6,
> > >                     from include/linux/hardirq.h:9,
> > >                     from include/linux/interrupt.h:13,
> > >                     from arch/x86/include/asm/mshyperv.h:8,
> > >                     from arch/x86//entry/vdso/vdso32/../vclock_gettim=
e.c:20,
> > >                     from arch/x86//entry/vdso/vdso32/vclock_gettime.c=
:33:
> > >    arch/x86/include/asm/pgtable.h: In function 'clone_pgd_range':
> > >    arch/x86/include/asm/pgtable.h:1129:9: error: implicit declaration=
 of function
> 'kernel_to_user_pgdp'; did you mean 'u64_to_user_ptr'? [-Werror=3Dimplici=
t-function-
> declaration]
> > >      memcpy(kernel_to_user_pgdp(dst), kernel_to_user_pgdp(src),
> > >             ^~~~~~~~~~~~~~~~~~~
> >
> > Sorry but I'm failing to see how this (and all the rest) is related to
> > my patch ...
>=20
> You added '#include <linux/interrupt.h>' to mshyperv.h which is included =
in
> vclock_gettime.c and pulls in other stuff which fails to expand....

Is the declaration of hyperv_reenlightenment_intr() even needed in
mshyperv.h?  The '#include <linux/interrupt.h>' is there for the __irq_entr=
y
annotation on that declaration.   There's a declaration of the parallel (an=
d
unannotated) hyperv_vector_handler(), but that looks like a fossil that
isn't needed either.

Michael

>=20
> Thanks,
>=20
> 	tglx