Received: by 10.223.176.46 with SMTP id f43csp2438525wra; Sun, 21 Jan 2018 20:11:32 -0800 (PST) X-Google-Smtp-Source: AH8x226PthWtdobvHDWSKuG/aLkMflbdyUbM+c+wI30T5w2ppwkpQc0NzNOX+jwGPqAEF67rGgrN X-Received: by 10.98.12.23 with SMTP id u23mr7101703pfi.81.1516594292733; Sun, 21 Jan 2018 20:11:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516594292; cv=none; d=google.com; s=arc-20160816; b=m+AadT6rbdHwUzF5qfg3cjeCWY1ewgZhuEkFw0pSDZtIrr+Lh5zKYAeQXmzmb49V6G wk2J/1R3AyrtBAw6GDtvLrHhXLIGaQjXcIXng6wXctmVhuI7DYLBfdpBZbgzrdMX+8sm hP85Pnxl+pkv6ignzXgrobfFrkKmiaQeQYOSM9bBJO3qfqH7wzeCLltLCICVh/GZVlF4 mjLK3tdNMdxm2Q8R2JqrXABTidEibOp3uHx8wTE+UdbiArBMBlTpIPp00WqEaT6kKSfK Dx8fN1GxWn+dS2AGCOMh2a6Wd+E4i8IGjExndmKaBN+VjQ/JQQZfDcH0NOH5RnzHflEm yH6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :references:subject:cc:to:mime-version:user-agent:from:date :message-id:arc-authentication-results; bh=9R0ECHcoINHZtjB5BF61IhS3xQFbTv2VGoiloPbHJSw=; b=znOJCUzlVe/89e8cgYWOoyUWeOI84ou0VqbLKJk3QIDAKIWy3t9I8qcw8phG4sCX3s Q/8OtLQ7HGMGzmc/E/cfxZp7j0aX0uWnVh/NSi4b+8sFhD68lgVSGmcVIca7nnYVW5Lg 4H1Ot5dFFyl+hbr8O9/pRLBF35CoOLabaras1TeME7CB5bftFa1jS5s+dsvJNoQnutfa dJs7f27tw7RPQZpDCpxvuDwB1DcOJVSIXCiaEupbFspMFqOzuei5RkKBsJN69HerCT+2 22nTw40cxjn/7E2cm8vfbTUAd4m7MzX/PqDFrKEfup9IXiQgcdPUPbVnNETv73AcP8Yy eqAw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b5-v6si3041278ple.457.2018.01.21.20.10.43; Sun, 21 Jan 2018 20:11:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751107AbeAVEJq (ORCPT + 99 others); Sun, 21 Jan 2018 23:09:46 -0500 Received: from regular1.263xmail.com ([211.150.99.141]:56234 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750955AbeAVEJo (ORCPT ); Sun, 21 Jan 2018 23:09:44 -0500 Received: from jeffy.chen?rock-chips.com (unknown [192.168.167.152]) by regular1.263xmail.com (Postfix) with ESMTP id 52261A1; Mon, 22 Jan 2018 12:09:38 +0800 (CST) X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 Received: from [172.16.22.190] (localhost [127.0.0.1]) by smtp.263.net (Postfix) with ESMTPA id 208BD308; Mon, 22 Jan 2018 12:09:30 +0800 (CST) X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: randy.li@rock-chips.com X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-SENDER: cjf@rock-chips.com X-DNS-TYPE: 0 Received: from [172.16.22.190] (unknown [103.29.142.67]) by smtp.263.net (Postfix) whith ESMTP id 12003BKJPBJ; Mon, 22 Jan 2018 12:09:36 +0800 (CST) Message-ID: <5A6563FA.8080602@rock-chips.com> Date: Mon, 22 Jan 2018 12:09:30 +0800 From: JeffyChen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Randy Li , Robin Murphy , linux-kernel@vger.kernel.org, tfiga@chromium.org CC: Mark Rutland , devicetree@vger.kernel.org, xxm@rock-chips.com, Joerg Roedel , jcliang@chromium.org, linux-rockchip@lists.infradead.org, iommu@lists.linux-foundation.org, Rob Herring , linux-arm-kernel@lists.infradead.org, Heiko Stuebner Subject: Re: [PATCH v4 08/13] iommu/rockchip: Control clocks needed to access the IOMMU References: <20180118115251.5542-1-jeffy.chen@rock-chips.com> <20180118115251.5542-9-jeffy.chen@rock-chips.com> <5A60AE41.2050101@rock-chips.com> <1f4b3c0d-1414-0012-a072-f4a11f432c21@rock-chips.com> <5A654925.9020203@rock-chips.com> In-Reply-To: <5A654925.9020203@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Randy, On 01/22/2018 10:15 AM, JeffyChen wrote: > Hi Randy, > > On 01/22/2018 09:18 AM, Randy Li wrote: >>> >> Also the power domain driver could manage the clocks as well, I would >> suggest to use pm_runtime_*. > > actually the clocks required by pm domain may not be the same as what we > want to control here, there might be some clocks only be needed when > accessing mmu registers. > > but i'm not very sure about that, will confirm it with Simon Xue. confirmed with Simon, there might be some iommus don't have a pd, and the CONFIG_PM could be disabled. so it might be better to control clocks in iommu driver itself.