Received: by 10.223.176.46 with SMTP id f43csp2564318wra; Sun, 21 Jan 2018 23:01:38 -0800 (PST) X-Google-Smtp-Source: AH8x226Uo4oDOxfq0CtEu3JvdMKGXpJW+avGHkMnRPke7pFP3AXzvhUDd2UaeGhipS966fc6foj4 X-Received: by 10.99.138.75 with SMTP id y72mr6417091pgd.90.1516604498188; Sun, 21 Jan 2018 23:01:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516604498; cv=none; d=google.com; s=arc-20160816; b=TFeSCanyZGrbvZRhJbwx1f5NSAbrJj5xV3nUpLa4I8mVIYgfLqlB2tQUybIvLO/fW8 7ARaaYVta8XAsuYpKu99f1hS8324DNB3o2rB88vvBlqVc5nzC6U9gPcc1NiHAV3KxKZz 35c/nfU3RiD+wpTdx1w4RrPpy2Pb/gM//GslOlYkjJqQo7p58GYTvEEMRwNtUpJTBUrb M2PX3axRMgW0yGqKq+YPBbBcCQ9re/TetRQyqmOPhmnjt6gHAY2PeOrEh3afunykojKE dXbQWu4dHGEAcvWvZdqBH+CBwdLCxjW660Or74KyboCSVKIE133ZLGu6vZx3YB0wglZ7 HGeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=WOMvJ3xDyOt7LZ2gYmexjyW0DUdbzyoeqnW67tBX2Jk=; b=ckiY/BdzWpP5M6jQ3HDlsbYSAykbM0g3JrbYaXe4lyMLiAgDCJolWUDzAVxHf48POK BN92u8ol1KTu83q7Ey0tMFWV0hJiLXxhv0MimixCEqqcoFHGw0s453qov98N/g5CH2ja YrrKmlzIrU4RJj1bvB3bHaljGSPHW+QoQnKCBrZq+kgRuIRGOnsfwR+8WIcwwqlYgLQq OFWmySnOjbFO0BECbV9PNzZTvdPufh61X52PTbr7/vNPq5SJGfzyyJCjA9/ybqmuqWZi M8DD2+8VDqAleHTDEHoUrKACjtpaD2SwsTdKaak4LVz9+6+sdNWUc4AMdc2ntK8/Nxmh p7EA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@posteo.de header.s=2017 header.b=Htt6Tbe5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m14si13521838pgs.302.2018.01.21.23.01.24; Sun, 21 Jan 2018 23:01:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@posteo.de header.s=2017 header.b=Htt6Tbe5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751183AbeAVHAx (ORCPT + 99 others); Mon, 22 Jan 2018 02:00:53 -0500 Received: from mout01.posteo.de ([185.67.36.65]:35194 "EHLO mout01.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbeAVHAv (ORCPT ); Mon, 22 Jan 2018 02:00:51 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 7A16120F47 for ; Mon, 22 Jan 2018 08:00:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1516604450; bh=sPdojxRqF/wxDOMNrcZA40sIbtzTDFY1e/0z/wFNKq0=; h=Subject:To:Cc:From:Date:From; b=Htt6Tbe50fw3G1oXgEjS/qTY8TMM8D3Pt8OQYn9AF0oX+c/RqcvL88ImnVonGPTlA Qc0yc7P8WgckcIY6gOREpFWYMhdte3WJPOMfwbA3v6FPC+4B4/6FIWQv+wjJeTr1Y0 4nKbVNai68ftrF9nID3An+8LhXlh3IsfJbjXPfH1KaEfOvTKVNmVlzW81sQ5xU1x5Q ivO8YXsLUzgDFxlNrjVNjSjYbgT0n0g4RvBGQF7Ed+i/UCtZCx06kpTxy7fM0Gh8f4 w8Ki56uXybzz7h9H73DGTc5cJfTYCPfjE5wpouAQBAoS47ekHOrMk4eciJWC0icLP9 sdeGsMS5ueHPw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 3zQ2Q86Rzfz9rxM; Mon, 22 Jan 2018 08:00:48 +0100 (CET) Subject: Re: [PATCH] Input: edt-ft5x06: Delete an error message for a failed memory allocation in edt_ft5x06_ts_probe() To: SF Markus Elfring , linux-input@vger.kernel.org, Andi Shyti , Dmitry Torokhov , =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= , Rob Herring , Simon Budig , =?UTF-8?Q?Stefan_Sch=c3=b6fegger?= Cc: LKML , kernel-janitors@vger.kernel.org References: <45f8a6c2-423b-5bc1-6512-c5b954c5620b@users.sourceforge.net> From: Martin Kepplinger Message-ID: <850ca75e-6b13-8e08-b97e-2512e0841152@posteo.de> Date: Mon, 22 Jan 2018 08:00:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <45f8a6c2-423b-5bc1-6512-c5b954c5620b@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-01-21 20:19, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 21 Jan 2018 20:10:03 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by: Martin Kepplinger > --- > drivers/input/touchscreen/edt-ft5x06.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c > index c53a3d7239e7..9d2799c90150 100644 > --- a/drivers/input/touchscreen/edt-ft5x06.c > +++ b/drivers/input/touchscreen/edt-ft5x06.c > @@ -978,10 +978,8 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client, > dev_dbg(&client->dev, "probing for EDT FT5x06 I2C\n"); > > tsdata = devm_kzalloc(&client->dev, sizeof(*tsdata), GFP_KERNEL); > - if (!tsdata) { > - dev_err(&client->dev, "failed to allocate driver data.\n"); > + if (!tsdata) > return -ENOMEM; > - } > > chip_data = of_device_get_match_data(&client->dev); > if (!chip_data) >